From patchwork Mon Oct 7 15:28:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 175350 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp4445932ill; Mon, 7 Oct 2019 08:39:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqzQbxId7eqqnY9tsitCtN0ZovLBw5AegWMSWGnA5i+CmrHWWeDPoG6QWPXs7AJ/hdB4XvnX X-Received: by 2002:ac8:7513:: with SMTP id u19mr31087742qtq.111.1570462741077; Mon, 07 Oct 2019 08:39:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570462741; cv=none; d=google.com; s=arc-20160816; b=gw42E2XcPqRoX1O6jCpOS8dFLNgTyDHn431oZEO+T2gZKJj4kGrBppyhwRwBCrXLW4 25j9P8k4f/+yMm0CtOfpd0HT/Q6Ze37mtm/T5TPFEMWgd6PIt12Ljct+yFD46uImEdfw L+51x101dUcdGSkTqlkQf+TfJuDy3QIBolVt/Q254lvn5ioW9Q5hA7fqfh40bsq4MDav PFDjfGlFKPbzlXWGcCRKMk9KpKKMAye01lYpUXBAyeWsNxLR8+2EnTaOoB00caLCD+Rx lWHb7l9CW3G8AjuwW8beoLRB+jLYMB7LPbT1zQyrRNgyYSC9L7b8r0yvz3obL3LjVwfK 5dAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=YDBJO83fFMPFHsguCkuLARuLU3nbWbIEfUOqbeuNP6c=; b=hJDLcuivEkDvfQvEgA1zXamr4YZX+pKWFMeA1OexRc/cGH5soClKn+ATrk83z9KFdd cARYRMKN1O3zqMSHcMpOMZRCQZkJjXn5NZQgAgcA6zCORhBXuKL0ZzLQAweOF/MSJEk1 8WlgOw4f6yFmFrByHQsb8pdObuo37xOZoY5Sd5azMyuTcbLxC6gXFdYxD5Y96/0rGmNv YuxwpMv8wkNLMuSVkKq8zshFbu8Q16M2HW35BcVp7grLbZBRXIyJwyiToppyBxgIgo/E WkCyhvU4cjaJKK1sEEYw1NvxLK0EmQPPqTGT83ZhOsha5A9Ihr0ZP+x5LUr83M74VeR4 jLLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=TIGMGrUW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u32si13734705qtb.102.2019.10.07.08.39.01 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 Oct 2019 08:39:01 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=TIGMGrUW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:46306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHV6C-0002Do-1K for patch@linaro.org; Mon, 07 Oct 2019 11:39:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48964) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHUwP-0002g8-0J for qemu-devel@nongnu.org; Mon, 07 Oct 2019 11:28:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHUwN-0005DJ-Lk for qemu-devel@nongnu.org; Mon, 07 Oct 2019 11:28:52 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:50904) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iHUwN-0005Cq-EV for qemu-devel@nongnu.org; Mon, 07 Oct 2019 11:28:51 -0400 Received: by mail-wm1-x331.google.com with SMTP id 5so13176013wmg.0 for ; Mon, 07 Oct 2019 08:28:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YDBJO83fFMPFHsguCkuLARuLU3nbWbIEfUOqbeuNP6c=; b=TIGMGrUW9sr9ncmhU4HLzl6a0/7ts2oEV5UuyE2MWL+4XtI7gv7vJcHCcuGtExwHvg lvmXv5G4Gl4XRg+PbNhu5NN7kBGnsEEbBKVMg1+LNnwPZkLK9kR7DDD0ORiZaAQxq7Me R2ERPOsSCb7A6hoslnhWyxlxa+4Ar3Nq54INfJxMcePPvzUGcDWktSxKELdHBdefCvdX Rj/C72DM+nNnlXH0pIUXzWHoHYHjHbl6d1CRskHiXi+Sbi+6e0f3X/qbVAzMsSXMkkK0 EYDBKnzApZ6zcgTH5yXWIIcvxR5L7xj83A7Rgkslv3sDuFcAoKeBkSEGhNTM8wtwMkju j0eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YDBJO83fFMPFHsguCkuLARuLU3nbWbIEfUOqbeuNP6c=; b=LifjM8YsxkWrEOGczdIBbFfLiXohAmPus8K0kIFbLyWM25mX5rgqAWvBuBnpD5YwaB Scou2J5uIpXFcDQd77CRsUAkaX20MJ7dO79tAObiOceW5St3jBGKHAbq7NuSLWXqvocm 2QGQb+AkjrZc5pt7nCkyOqpoQOQR4fiVf2hpDaPQmygAtJgxEGZYfbcQi3k6NdJwfrjZ GPbZlkWU02gy9JsksWQ0zYKayKeIDiUMvdAxWdbgFIM9aoqPVQ8aH1e0r60Oh/HMIXyh 1rHq/xGWt1qcnalsnGeASX5LqmsbDuwm4QBj1aNqmCiU4KBTYAeAlw3Ma6DxGvPS6vmX Jovg== X-Gm-Message-State: APjAAAWYj+Vg1oon/gd8+4x9mfBCC5v/Cc7fs8zrgA6yWxHRfuzVjYmc vCPe9xCBvCOAq1zLQOW65rcpeQ== X-Received: by 2002:a1c:5fd6:: with SMTP id t205mr20768288wmb.124.1570462130265; Mon, 07 Oct 2019 08:28:50 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id r140sm14661979wme.47.2019.10.07.08.28.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2019 08:28:47 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 9EEC71FF87; Mon, 7 Oct 2019 16:28:40 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v9 12/13] tb-stats: adding TBStatistics info into perf dump Date: Mon, 7 Oct 2019 16:28:38 +0100 Message-Id: <20191007152839.30804-13-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191007152839.30804-1-alex.bennee@linaro.org> References: <20191007152839.30804-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::331 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , cota@braap.org, "Vanderson M. do Rosario" , Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Vanderson M. do Rosario" Adding TBStatistics information to linux perf TB's symbol names. Signed-off-by: Vanderson M. do Rosario Message-Id: <20190830121903.17585-3-vandersonmr2@gmail.com> [AJB: fix authorship, auto-strings] Signed-off-by: Alex Bennée --- AJB: - use g_string and auto free --- accel/tcg/perf/jitdump.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) -- 2.20.1 diff --git a/accel/tcg/perf/jitdump.c b/accel/tcg/perf/jitdump.c index e1d6f2214e..e7b86173e0 100644 --- a/accel/tcg/perf/jitdump.c +++ b/accel/tcg/perf/jitdump.c @@ -146,7 +146,20 @@ void start_jitdump_file(void) void append_load_in_jitdump_file(TranslationBlock *tb) { - gchar *func_name = g_strdup_printf("TB virt:0x"TARGET_FMT_lx, tb->pc); + g_autoptr(GString) func_name = g_string_new("TB virt:"); + + g_string_append_printf(func_name, "0x"TARGET_FMT_lx, tb->pc); + + if (tb->tb_stats) { + TBStatistics *tbs = tb->tb_stats; + unsigned g = stat_per_translation(tbs, code.num_guest_inst); + unsigned ops = stat_per_translation(tbs, code.num_tcg_ops); + unsigned ops_opt = stat_per_translation(tbs, code.num_tcg_ops_opt); + unsigned spills = stat_per_translation(tbs, code.spills); + + g_string_append_printf(func_name, " (g:%u op:%u opt:%u spills:%d)", + g, ops, ops_opt, spills); + } /* Serialise the writing of the dump file */ qemu_mutex_lock(&dumpfile_lock); @@ -167,7 +180,6 @@ void append_load_in_jitdump_file(TranslationBlock *tb) fwrite(func_name->str, func_name->len + 1, 1, dumpfile); fwrite(tb->tc.ptr, tb->tc.size, 1, dumpfile); - g_free(func_name); fflush(dumpfile); qemu_mutex_unlock(&dumpfile_lock);