diff mbox series

[v5,31/55] target/riscv: fetch code with translator_ld

Message ID 20191014104948.4291-32-alex.bennee@linaro.org
State Superseded
Headers show
Series Support for TCG plugins | expand

Commit Message

Alex Bennée Oct. 14, 2019, 10:49 a.m. UTC
From: "Emilio G. Cota" <cota@braap.org>


Signed-off-by: Emilio G. Cota <cota@braap.org>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
 target/riscv/translate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1

Comments

Alistair Francis Oct. 14, 2019, 5:59 p.m. UTC | #1
On Mon, Oct 14, 2019 at 4:20 AM Alex Bennée <alex.bennee@linaro.org> wrote:
>

> From: "Emilio G. Cota" <cota@braap.org>

>

> Signed-off-by: Emilio G. Cota <cota@braap.org>

> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>


Reviewed-by: Alistair Francis <alistair.francis@wdc.com>


Alistair

> ---

>  target/riscv/translate.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/target/riscv/translate.c b/target/riscv/translate.c

> index adeddb85f6..b26533d4fd 100644

> --- a/target/riscv/translate.c

> +++ b/target/riscv/translate.c

> @@ -779,7 +779,7 @@ static void riscv_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)

>      DisasContext *ctx = container_of(dcbase, DisasContext, base);

>      CPURISCVState *env = cpu->env_ptr;

>

> -    ctx->opcode = cpu_ldl_code(env, ctx->base.pc_next);

> +    ctx->opcode = translator_ldl(env, ctx->base.pc_next);

>      decode_opc(ctx);

>      ctx->base.pc_next = ctx->pc_succ_insn;

>

> --

> 2.20.1

>

>
Palmer Dabbelt Oct. 18, 2019, 6:32 p.m. UTC | #2
On Mon, 14 Oct 2019 10:59:07 PDT (-0700), alistair23@gmail.com wrote:
> On Mon, Oct 14, 2019 at 4:20 AM Alex Bennée <alex.bennee@linaro.org> wrote:

>>

>> From: "Emilio G. Cota" <cota@braap.org>

>>

>> Signed-off-by: Emilio G. Cota <cota@braap.org>

>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

>

> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>


and

Acked-by: Palmer Dabbelt <palmer@sifive.com>


as I'm assuming this will go in with the rest of the patch set.

>

> Alistair

>

>> ---

>>  target/riscv/translate.c | 2 +-

>>  1 file changed, 1 insertion(+), 1 deletion(-)

>>

>> diff --git a/target/riscv/translate.c b/target/riscv/translate.c

>> index adeddb85f6..b26533d4fd 100644

>> --- a/target/riscv/translate.c

>> +++ b/target/riscv/translate.c

>> @@ -779,7 +779,7 @@ static void riscv_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)

>>      DisasContext *ctx = container_of(dcbase, DisasContext, base);

>>      CPURISCVState *env = cpu->env_ptr;

>>

>> -    ctx->opcode = cpu_ldl_code(env, ctx->base.pc_next);

>> +    ctx->opcode = translator_ldl(env, ctx->base.pc_next);

>>      decode_opc(ctx);

>>      ctx->base.pc_next = ctx->pc_succ_insn;

>>

>> --

>> 2.20.1

>>

>>
diff mbox series

Patch

diff --git a/target/riscv/translate.c b/target/riscv/translate.c
index adeddb85f6..b26533d4fd 100644
--- a/target/riscv/translate.c
+++ b/target/riscv/translate.c
@@ -779,7 +779,7 @@  static void riscv_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)
     DisasContext *ctx = container_of(dcbase, DisasContext, base);
     CPURISCVState *env = cpu->env_ptr;
 
-    ctx->opcode = cpu_ldl_code(env, ctx->base.pc_next);
+    ctx->opcode = translator_ldl(env, ctx->base.pc_next);
     decode_opc(ctx);
     ctx->base.pc_next = ctx->pc_succ_insn;