From patchwork Fri Oct 18 17:44:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 176930 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp1200493ill; Fri, 18 Oct 2019 11:04:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqxOtX1p3G5c1gE9CBQPbjhNtQfYzNTFtLXgsEbO5jIyEs3D0TzDXGDx4ZVm3OmI+e5Cf1ez X-Received: by 2002:a37:c41:: with SMTP id 62mr9613978qkm.445.1571421896326; Fri, 18 Oct 2019 11:04:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571421896; cv=none; d=google.com; s=arc-20160816; b=P1NyZdfy4x6+mKfRQ1w7u0omSNxB5p94f58b4dHnyNOAa3itszddBHRrEYFInVOhiE UV9pZMw/ezNvK6hFzW7rsT9VkThtn0n8vvX4tf4u4+nCDhsWDe/nQAkiKoswsSJcmPdS iqcB3KvqDB796MtoXCxp8GkuZnStuuwNWt4VcyCNrG7huvF2ZSHYdmmnL7tbFzhWKf1t RyoR6o9mjYBbuPRn7vNM9PLvzQFpCZQR40aZrLO/fxOikrFVCydiND9uBFu00HfGvZ1K 3qKZ/zj43YEbooxoGX5uVMluQtiIGCs7osakW8BmHOpBbFyHkjkpXMFGDHx2YdcQB4nu NKLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:references:in-reply-to :message-id:date:subject:to:from:dkim-signature; bh=4z2zPWedOviyKqg3qmIWn8g3R8jv2yS1u67ka41eHWc=; b=zGOPaNS7hTKVY8fHUJ5+rC38uv8qAht8hHDyC4Egsg0H3XwJmrfJyweVqf/L3oiUFt r0JpL5FT4sXn/Br8p13RFH+A11Z3egajfAIrEroJIBTw0MI+lxQiLL0YbLXVn2R14uN5 l4gC0qpPhynlGM38gjV9JXOp1KLGPsrdrrKMa2X9a3blp2rzAp1ELTsi0d/+3ijepHxE UPiFZD2Xt5nrC2pIkE+1JADQuz2fSYfwzhvNAlPnBj9zNDyT1apjyzRIDNT5v3+taDZB 0wMCfAG94DpfwUfExTr5PAFuWWGB4khoYzpt+vVZ3DuIqUjoEIWl4xI/pomeel0mMgG6 y9rw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=nI0rWgGQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a4si5939258qkn.224.2019.10.18.11.04.56 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 Oct 2019 11:04:56 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=nI0rWgGQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:44564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLWcR-0002DZ-C2 for patch@linaro.org; Fri, 18 Oct 2019 14:04:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59490) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLWJ9-0006rE-3c for qemu-devel@nongnu.org; Fri, 18 Oct 2019 13:44:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLWJ7-0005dw-Vz for qemu-devel@nongnu.org; Fri, 18 Oct 2019 13:44:58 -0400 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]:40071) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iLWJ7-0005dQ-Qz for qemu-devel@nongnu.org; Fri, 18 Oct 2019 13:44:57 -0400 Received: by mail-pg1-x543.google.com with SMTP id e13so3750371pga.7 for ; Fri, 18 Oct 2019 10:44:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4z2zPWedOviyKqg3qmIWn8g3R8jv2yS1u67ka41eHWc=; b=nI0rWgGQzrA9U6zEdQj3b1jl+SAttb9L65Ev0KMFewggAH/JgNkTbBgKH5FUFPaVUk yT77aBDq1capTDD5XBJ0kHvzCdLzW6UtviyBLhNXknkCHDTIdwRE8n4wPP/ipPvq42lN huTPPuL9IbYNLT2RuvJF2FZm+rZf1BQUIvcsqi+l1ne7UiawUsAaimf2vg27SEVhGf2Y +wu4VSTc9ZZovdt++QjjrMcI3FwGjhB9l1KOmwFPGGedB55xqNd0bG3gyY2o/8br/beF RsaaHHn7Symv/XgyQANNCF1A4200J3lPZGuMZYYgVaGIvAb3DJl4GBKNwIs0/ZH65EE3 JFWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4z2zPWedOviyKqg3qmIWn8g3R8jv2yS1u67ka41eHWc=; b=isAgvnkhVpwRsNGRp77zdYWxQG5oaGtr0p0zrWzJ+9jOLtF9EwXC6Xo56SFZFZxUKj 53Q31mTPcqkxA8zkYNDcBhtomBDUiWJs2nggl1zMy977UYKB+KPfIAncrLjZ60kXePbt h9e4WHoubPL/rf3N6xN2RpZYB8tJZovuedxngDUlv6mVUjo8phX8oItCWQtJ/ay25FfM /ozWc7tys9L7FTQ/MYWHFHTm07E43UffD8ztZdnrMycdql56zgT6I5kq3XB0ustK2jCi N77HJ2JrU3aHxaxbLiUqJ0R+qUtn1SnWvqSjVKOVXfujMTB2cFZbgoEqWF34gW7Aq3Ag lydQ== X-Gm-Message-State: APjAAAUq+iqxGajxnijP54MR83oYzIi2uIxxNtR91MAgswy6RiCf/7dw Dsuxrg98gUM0WNyjLGZmhsM8FUYMch4= X-Received: by 2002:a63:ff54:: with SMTP id s20mr9314597pgk.398.1571420696525; Fri, 18 Oct 2019 10:44:56 -0700 (PDT) Received: from localhost.localdomain (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id d20sm7857534pfq.88.2019.10.18.10.44.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 10:44:55 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v8 19/22] target/arm: Rebuild hflags at Xscale SCTLR writes Date: Fri, 18 Oct 2019 10:44:28 -0700 Message-Id: <20191018174431.1784-20-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191018174431.1784-1-richard.henderson@linaro.org> References: <20191018174431.1784-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::543 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Continue setting, but not relying upon, env->hflags. Signed-off-by: Richard Henderson --- target/arm/helper.c | 10 ++++++++++ 1 file changed, 10 insertions(+) -- 2.17.1 diff --git a/target/arm/helper.c b/target/arm/helper.c index aae7b62458..c55783e540 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -4174,6 +4174,16 @@ static void sctlr_write(CPUARMState *env, const ARMCPRegInfo *ri, /* ??? Lots of these bits are not implemented. */ /* This may enable/disable the MMU, so do a TLB flush. */ tlb_flush(CPU(cpu)); + + if (ri->type & ARM_CP_SUPPRESS_TB_END) { + /* + * Normally we would always end the TB on an SCTLR write; see the + * comment in ARMCPRegInfo sctlr initialization below for why Xscale + * is special. Setting ARM_CP_SUPPRESS_TB_END also stops the rebuild + * of hflags from the translator, so do it here. + */ + arm_rebuild_hflags(env); + } } static CPAccessResult fpexc32_access(CPUARMState *env, const ARMCPRegInfo *ri,