From patchwork Fri Nov 15 17:29:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 179515 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp12761647ilf; Fri, 15 Nov 2019 09:37:19 -0800 (PST) X-Google-Smtp-Source: APXvYqyZBsrjSjWD+djQMcpkC36ns4p6BABDVRCTLZKVCXIR1LVRfCy/7YARDMO6Ghd0rPEyI7Mj X-Received: by 2002:ac8:758e:: with SMTP id s14mr15036793qtq.288.1573839439470; Fri, 15 Nov 2019 09:37:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573839439; cv=none; d=google.com; s=arc-20160816; b=PRwRNq8ABeL4aeQ8qkUwsycllcEaS63wRvbizbnKWB4VD1o/c0nrCr4/FYunfST788 fFmm64+v3SRXjh+EV4OqdsueQoj30ydIs2i3xNQby2Bt8PpA2UB3J6G/EJxXpP6hTluV 1zxmUH5fqctoxJWLiMYGGP0Pr73Yvgz3gTwTvc3Rj/R8A53AoACHgFDLSw2MpREigoy2 fojsixINseGkBT4C07gzJASJvt3ZXRGJEwiNlg0+sHKXlrD2jviaIV+o17AknEbVTUaH kytE1+kyjXUQy7RTvjKRjsIcZXd8IVFQrvwMZW1WPSUO7GZvHOpfIS1Fct/r0e14en9u wvtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=oZtAc1yXQIhyrWZiFMsHbDwOJI2w9ArxU1OJA7FmK0k=; b=HsAkoLQm39nOynUbrdq6yoHX/JyQWhxJQES81ZQkbfZQepaXzcPPKiSW151oiBbMGV YJE3EpYMG1CJvKZIj5csybV62YRGBuf+QhI56C79IDHfOogxDV7dNg5S95WmTJyIZ14S e4z43pTexot2hM3w1nJoV5uN4oqMEv8p6ZGiy8RTC5A5RFM3VmU3bKQsr8ABdpAWYUWc kKqVIidfTcuzT+0FEWnoR+XBK6d5kGty4CQtpgZuiUQCk8V/6ZXLlSz0/h7FrqSXGQSJ 1XuarC3sNTG1o60CTyDa1Slgr1aT+CARYG1OkcNBzcPoEE3wdVvhA9FTcKLyuW1xKbPs UvyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=lSb2G55R; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 8si5767085qvb.8.2019.11.15.09.37.19 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Nov 2019 09:37:19 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=lSb2G55R; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:42846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVfX4-0002mG-9n for patch@linaro.org; Fri, 15 Nov 2019 12:37:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34996) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVfQJ-0007O5-El for qemu-devel@nongnu.org; Fri, 15 Nov 2019 12:30:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVfQH-00032d-AW for qemu-devel@nongnu.org; Fri, 15 Nov 2019 12:30:19 -0500 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:36697) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVfQH-0002yO-31 for qemu-devel@nongnu.org; Fri, 15 Nov 2019 12:30:17 -0500 Received: by mail-wr1-x441.google.com with SMTP id r10so11851935wrx.3 for ; Fri, 15 Nov 2019 09:30:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oZtAc1yXQIhyrWZiFMsHbDwOJI2w9ArxU1OJA7FmK0k=; b=lSb2G55RoHFSOG/ZkSGRnl4U0yKX9CvSc+MSbFgc+Z30bZIGzbCcTkj1195tNa7vu9 WuDGzoXxGSFJzpMu9sqB1a/cYsItlb3vU6gQqrk02fZI0G8IPFPLjB9l7hys+3QdMrHq O/aCwHblI8x0MIdDTuKAaw83jEBcU9ybWyQHkmWgOX/JazO9UwShkFSy5pXjz8+UQHiS FQrwXeXdWks1lHK2FM4stZzqNpMuy2EBxy0DSANbKF2loPWqSyMCgaY8wI33kH8ykVyC Sey1Qb8Q+4TFGfWJjX/zS27MYHRHcKNfPp1M87uWeficEHIvVLPNeyY5GvoVp48BtSDy H0GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oZtAc1yXQIhyrWZiFMsHbDwOJI2w9ArxU1OJA7FmK0k=; b=XorlDQkFAvsK5dMK7lwcV6BTPuBLGGOoAVdj/TlBXohfwzw+sDZcpRhbn/Bl3htluk APWRUkfyV+T9VDe7L0yTNGlI/yFM2Sao53SyFYwknP47RUT7Np+LALAideeuWudq8x4U Mn5XwH31isPsnr4mC5sfReokbgBuDfoaKErfZnQDGc7fntz7NviRkxVtOUBylc0SZ0Dd Pjtxg+pOBAeRseBz8kyMvTQ6d7t2kT/KPKVRPBNtLdSsL8fJ/xKkdbBikyDXDVwT6U0j KrwJox9flGf1lu3xoMWiN1XBqpQsHL7DpdKHUZ5+xVLtYBmsTBZJks1Hq3EWzW0csHwX rXpA== X-Gm-Message-State: APjAAAXrcADSifLwMrwKNgT5rInzNjDvin9/bMMOjDuIuKLB7y4C1v3u G1d9edwgY9QPtRaXtPuJgSS+cD3VB0M= X-Received: by 2002:adf:979a:: with SMTP id s26mr17027568wrb.92.1573839014766; Fri, 15 Nov 2019 09:30:14 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id z14sm11839552wrl.60.2019.11.15.09.30.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2019 09:30:09 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id D8ED91FF99; Fri, 15 Nov 2019 17:30:01 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 09/11] target/arm: prepare for multiple dynamic XMLs Date: Fri, 15 Nov 2019 17:29:58 +0000 Message-Id: <20191115173000.21891-10-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191115173000.21891-1-alex.bennee@linaro.org> References: <20191115173000.21891-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: damien.hedde@greensocs.com, Peter Maydell , luis.machado@linaro.org, richard.henderson@linaro.org, "open list:ARM TCG CPUs" , alan.hayward@arm.com, =?utf-8?q?Alex?= =?utf-8?q?_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We will want to generate similar dynamic XML for gdbstub support of SVE registers (the upstream doesn't use XML). To that end lightly rename a few things to make the distinction. Signed-off-by: Alex BennĂ©e --- target/arm/cpu.h | 20 +++++++++++++------- target/arm/gdbstub.c | 30 +++++++++++++++--------------- target/arm/helper.c | 4 ++-- 3 files changed, 30 insertions(+), 24 deletions(-) -- 2.20.1 diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 0f4541af1ee..97744496f2d 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -128,14 +128,20 @@ enum { /** * DynamicGDBXMLInfo: * @desc: Contains the XML descriptions. - * @num_cpregs: Number of the Coprocessor registers seen by GDB. - * @cpregs_keys: Array that contains the corresponding Key of - * a given cpreg with the same order of the cpreg in the XML description. + * @num: Number of the registers in this XML seen by GDB. + * @data: A union with data specific to the set of registers + * @cpregs_keys: Array that contains the corresponding Key of + * a given cpreg with the same order of the cpreg + * in the XML description. */ typedef struct DynamicGDBXMLInfo { char *desc; - int num_cpregs; - uint32_t *cpregs_keys; + int num; + union { + struct { + uint32_t *keys; + } cpregs; + } data; } DynamicGDBXMLInfo; /* CPU state for each instance of a generic timer (in cp15 c14) */ @@ -751,7 +757,7 @@ struct ARMCPU { uint64_t *cpreg_vmstate_values; int32_t cpreg_vmstate_array_len; - DynamicGDBXMLInfo dyn_xml; + DynamicGDBXMLInfo dyn_sysreg_xml; /* Timers used by the generic (architected) timer */ QEMUTimer *gt_timer[NUM_GTIMERS]; @@ -958,7 +964,7 @@ int arm_cpu_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg); /* Dynamically generates for gdb stub an XML description of the sysregs from * the cp_regs hashtable. Returns the registered sysregs number. */ -int arm_gen_dynamic_xml(CPUState *cpu); +int arm_gen_dynamic_sysreg_xml(CPUState *cpu); /* Returns the dynamically generated XML for the gdb stub. * Returns a pointer to the XML contents for the specified XML file or NULL diff --git a/target/arm/gdbstub.c b/target/arm/gdbstub.c index 4557775d245..1f68ab98c3b 100644 --- a/target/arm/gdbstub.c +++ b/target/arm/gdbstub.c @@ -106,15 +106,15 @@ int arm_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n) return 0; } -static void arm_gen_one_xml_reg_tag(GString *s, DynamicGDBXMLInfo *dyn_xml, - ARMCPRegInfo *ri, uint32_t ri_key, - int bitsize) +static void arm_gen_one_xml_sysreg_tag(GString *s, DynamicGDBXMLInfo *dyn_xml, + ARMCPRegInfo *ri, uint32_t ri_key, + int bitsize) { g_string_append_printf(s, "name); g_string_append_printf(s, " bitsize=\"%d\"", bitsize); g_string_append_printf(s, " group=\"cp_regs\"/>"); - dyn_xml->num_cpregs++; - dyn_xml->cpregs_keys[dyn_xml->num_cpregs - 1] = ri_key; + dyn_xml->data.cpregs.keys[dyn_xml->num] = ri_key; + dyn_xml->num++; } static void arm_register_sysreg_for_xml(gpointer key, gpointer value, @@ -126,12 +126,12 @@ static void arm_register_sysreg_for_xml(gpointer key, gpointer value, GString *s = param->s; ARMCPU *cpu = ARM_CPU(param->cs); CPUARMState *env = &cpu->env; - DynamicGDBXMLInfo *dyn_xml = &cpu->dyn_xml; + DynamicGDBXMLInfo *dyn_xml = &cpu->dyn_sysreg_xml; if (!(ri->type & (ARM_CP_NO_RAW | ARM_CP_NO_GDB))) { if (arm_feature(env, ARM_FEATURE_AARCH64)) { if (ri->state == ARM_CP_STATE_AA64) { - arm_gen_one_xml_reg_tag(s , dyn_xml, ri, ri_key, 64); + arm_gen_one_xml_sysreg_tag(s , dyn_xml, ri, ri_key, 64); } } else { if (ri->state == ARM_CP_STATE_AA32) { @@ -140,30 +140,30 @@ static void arm_register_sysreg_for_xml(gpointer key, gpointer value, return; } if (ri->type & ARM_CP_64BIT) { - arm_gen_one_xml_reg_tag(s , dyn_xml, ri, ri_key, 64); + arm_gen_one_xml_sysreg_tag(s , dyn_xml, ri, ri_key, 64); } else { - arm_gen_one_xml_reg_tag(s , dyn_xml, ri, ri_key, 32); + arm_gen_one_xml_sysreg_tag(s , dyn_xml, ri, ri_key, 32); } } } } } -int arm_gen_dynamic_xml(CPUState *cs) +int arm_gen_dynamic_sysreg_xml(CPUState *cs) { ARMCPU *cpu = ARM_CPU(cs); GString *s = g_string_new(NULL); RegisterSysregXmlParam param = {cs, s}; - cpu->dyn_xml.num_cpregs = 0; - cpu->dyn_xml.cpregs_keys = g_new(uint32_t, g_hash_table_size(cpu->cp_regs)); + cpu->dyn_sysreg_xml.num = 0; + cpu->dyn_sysreg_xml.data.cpregs.keys = g_new(uint32_t, g_hash_table_size(cpu->cp_regs)); g_string_printf(s, ""); g_string_append_printf(s, ""); g_string_append_printf(s, ""); g_hash_table_foreach(cpu->cp_regs, arm_register_sysreg_for_xml, ¶m); g_string_append_printf(s, ""); - cpu->dyn_xml.desc = g_string_free(s, false); - return cpu->dyn_xml.num_cpregs; + cpu->dyn_sysreg_xml.desc = g_string_free(s, false); + return cpu->dyn_sysreg_xml.num; } const char *arm_gdb_get_dynamic_xml(CPUState *cs, const char *xmlname) @@ -171,7 +171,7 @@ const char *arm_gdb_get_dynamic_xml(CPUState *cs, const char *xmlname) ARMCPU *cpu = ARM_CPU(cs); if (strcmp(xmlname, "system-registers.xml") == 0) { - return cpu->dyn_xml.desc; + return cpu->dyn_sysreg_xml.desc; } return NULL; } diff --git a/target/arm/helper.c b/target/arm/helper.c index 2a2ac89951c..3234e6d08df 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -207,7 +207,7 @@ static int arm_gdb_get_sysreg(CPUARMState *env, GByteArray *buf, int reg) const ARMCPRegInfo *ri; uint32_t key; - key = cpu->dyn_xml.cpregs_keys[reg]; + key = cpu->dyn_sysreg_xml.data.cpregs.keys[reg]; ri = get_arm_cp_reginfo(cpu->cp_regs, key); if (ri) { if (cpreg_field_is_64bit(ri)) { @@ -6911,7 +6911,7 @@ void arm_cpu_register_gdb_regs_for_features(ARMCPU *cpu) 19, "arm-vfp.xml", 0); } gdb_register_coprocessor(cs, arm_gdb_get_sysreg, arm_gdb_set_sysreg, - arm_gen_dynamic_xml(cs), + arm_gen_dynamic_sysreg_xml(cs), "system-registers.xml", 0); }