diff mbox series

[PULL,11/25] Fix double free issue in qemu_set_log_filename().

Message ID 20191219104934.866-12-alex.bennee@linaro.org
State Accepted
Commit 0f516ca4767042aec8716369d6d62436fa10593a
Headers show
Series testing and logging updates | expand

Commit Message

Alex Bennée Dec. 19, 2019, 10:49 a.m. UTC 
From: Robert Foley <robert.foley@linaro.org>


After freeing the logfilename, we set logfilename to NULL, in case of an
error which returns without setting logfilename.

Signed-off-by: Robert Foley <robert.foley@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20191118211528.3221-2-robert.foley@linaro.org>

-- 
2.20.1
diff mbox series

Patch

diff --git a/util/log.c b/util/log.c
index 1ca13059eef..4316fe74eee 100644
--- a/util/log.c
+++ b/util/log.c
@@ -113,6 +113,7 @@  void qemu_set_log_filename(const char *filename, Error **errp)
 {
     char *pidstr;
     g_free(logfilename);
+    logfilename = NULL;
 
     pidstr = strstr(filename, "%");
     if (pidstr) {