From patchwork Fri Dec 20 12:04:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 182254 Delivered-To: patch@linaro.org Received: by 2002:a92:1f98:0:0:0:0:0 with SMTP id f24csp450635ilf; Fri, 20 Dec 2019 04:18:59 -0800 (PST) X-Google-Smtp-Source: APXvYqyggJIA63bxMrYmEk77CGgoaU6mcU/qFttaFNpEXTjq0zRpa70+shEunV4MJBC6WX6WpNIY X-Received: by 2002:a9d:674f:: with SMTP id w15mr15014580otm.243.1576844339177; Fri, 20 Dec 2019 04:18:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576844339; cv=none; d=google.com; s=arc-20160816; b=kHvKuChWETDDKFVFy6JMLd1Xsh3HeQmi4FuXbG9sazJicIx8kuEW0+G7CFtA7ixYZu M6FFbi//9soFEpC8a4CD+X5g0FynBem8tJ16mqJarlna9n1mdQRcqPwK9Nya9vWYc4kc OcbdNkT/H1D38k9cCDSEuoTNFltyzkTscNFrESXfJACJKnZ2XoNvJ0kuTFhP7tgrmxVh n/6dnpfbifReL5+zw1fB12+QwC+A3174j4BFxi+vEBgNk0ihpCkFuFc9aJY/UogRinoX gbYrdB5mBglaxjlAL0Zxbt4vY/E+u4HeVkWy0R/0EChJYYD/g2p/IA+PQYpd6Ie/q6hv +m+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=yP04C6ThOAXjLefYFBP1Rp4bmt2cBEv6NwVmKqtKkDw=; b=YL1gsGnQGeeOMnwQN+Wi4PpXctddz55JQnPBtXvFyKahlBOd6BPW51zADg1QukBQB2 P5yKP2VrbOCXrt1XY6nE1rgnJ4D0CtUdedmQ4PZBYTWUbFimT2CaGinmcTYQa9pSA4Wo bsqSpmgKDfnATxg1ERM/Pgg64EWjTwbHen6ZQrfaYkJuHR1Cw33+sRUQeVG25h7eF9AQ nDV2jjWfAb4SePZQ77A3tsJuQUmsOZO8rboa0iwTSBWyCfpfJ2IE/xuoRF7ci/n85Rpo e1MtOwQ9W5InNJQjazuJoNezoTB/stwLuV2EIcsuWkz8TTy5nP9lhRsLYiK0L3vAQIUC mExA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=LuPL37ZA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v202si4532925oie.79.2019.12.20.04.18.59 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Dec 2019 04:18:59 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=LuPL37ZA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:54264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iiHFC-0006Io-8M for patch@linaro.org; Fri, 20 Dec 2019 07:18:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52860) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iiH1a-0004k6-G9 for qemu-devel@nongnu.org; Fri, 20 Dec 2019 07:04:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iiH1Z-0007nz-2H for qemu-devel@nongnu.org; Fri, 20 Dec 2019 07:04:54 -0500 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:51606) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iiH1Y-0007k4-Hg for qemu-devel@nongnu.org; Fri, 20 Dec 2019 07:04:52 -0500 Received: by mail-wm1-x342.google.com with SMTP id d73so8695432wmd.1 for ; Fri, 20 Dec 2019 04:04:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yP04C6ThOAXjLefYFBP1Rp4bmt2cBEv6NwVmKqtKkDw=; b=LuPL37ZAkEEmEi+yqJ9WADzmqnLZrz+RJ1ojuwkeqTFWjZWglfHrlUo+yK37mRjyZ0 uHIir3/Jqn78UzcjUndn5Dw4i4rDuovNnUx/XgHE6FGoCZEqX3Arh6JLtcbTr5tmFQG5 SKAj2i6eGnLxfltMBbkJF4Vnboz5XMFC5EyBKkorUm016VRyd2n5d1Z+Kx9HSGZjoJId WolhnPylDDM/imY+lIo2y/AAJKdfo+TwTDgKBEFZy4rEFNEpXDwRjmq+zrnaZSMMvag0 lP14JfWmS/CWyFwt0nZwkPI9vPzT81ub4r78E2S7+TR0TIkqU4gK+JzJlf65b2kZXCE6 Qsrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yP04C6ThOAXjLefYFBP1Rp4bmt2cBEv6NwVmKqtKkDw=; b=hR+iXuwuK/gQQe5lleWcy+Vcfp+NbSNk6fE93K7MJquOOdgVCzPyIWEAayw/zgNqqY DkWAPO2uC78V/+PxEu75IS/XAzx1Q/SbRQsN+2pZ6OKF2Su0b89HIm4Qi1w7VsqVUE2t rYrtydCHDj01LJ0Anlgp38dp59OCvhIAijsTAUqYzhlxX2bMKwsJWBoposZSMkOw221k vsIIalmZuHvOFcBF/DhnbLvqZMnQGfNGiH5TGdMoqatfKIM5yeQ5NjpL7RVxwt2SHMDi 7e+pq3iKdHbRmDSeK9D8CNAeYpFRxraNJ8lvZo21Dk+vIR41y6wCs2zldwF5OIW6RRNh 0LhQ== X-Gm-Message-State: APjAAAXzI6afax/JQvPq0YFmRf5ffBJXrp7wdLJQ6nvj86k34cWb7YHN oT2qpXc3qNpTwW2sBeDGKo3VNpLakjk= X-Received: by 2002:a1c:e108:: with SMTP id y8mr15629231wmg.147.1576843491069; Fri, 20 Dec 2019 04:04:51 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id m7sm9462105wrr.40.2019.12.20.04.04.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Dec 2019 04:04:46 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 6B5541FF93; Fri, 20 Dec 2019 12:04:39 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v4 06/21] target/arm: use gdb_get_reg helpers Date: Fri, 20 Dec 2019 12:04:23 +0000 Message-Id: <20191220120438.16114-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191220120438.16114-1-alex.bennee@linaro.org> References: <20191220120438.16114-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: damien.hedde@greensocs.com, Peter Maydell , luis.machado@linaro.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson , "open list:ARM TCG CPUs" , alan.hayward@arm.com, =?utf-8?q?Alex_Ben?= =?utf-8?q?n=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This is cleaner than poking memory directly and will make later clean-ups easier. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- v2 - make sure we pass hi/lo correctly as quads are stored in LE order --- target/arm/helper.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) -- 2.20.1 diff --git a/target/arm/helper.c b/target/arm/helper.c index 5074b5f69ca..6f3b6ca7d3f 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -105,21 +105,17 @@ static int aarch64_fpu_gdb_get_reg(CPUARMState *env, uint8_t *buf, int reg) { switch (reg) { case 0 ... 31: - /* 128 bit FP register */ - { - uint64_t *q = aa64_vfp_qreg(env, reg); - stq_le_p(buf, q[0]); - stq_le_p(buf + 8, q[1]); - return 16; - } + { + /* 128 bit FP register - quads are in LE order */ + uint64_t *q = aa64_vfp_qreg(env, reg); + return gdb_get_reg128(buf, q[1], q[0]); + } case 32: /* FPSR */ - stl_p(buf, vfp_get_fpsr(env)); - return 4; + return gdb_get_reg32(buf, vfp_get_fpsr(env)); case 33: /* FPCR */ - stl_p(buf, vfp_get_fpcr(env)); - return 4; + return gdb_get_reg32(buf,vfp_get_fpcr(env)); default: return 0; }