From patchwork Tue Feb 11 17:35:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 183283 Delivered-To: patch@linaro.org Received: by 2002:a92:1f12:0:0:0:0:0 with SMTP id i18csp5576396ile; Tue, 11 Feb 2020 09:35:32 -0800 (PST) X-Google-Smtp-Source: APXvYqxxVtkP3Nq0Hsqp52FxpjgcK4aPWDsRJ60vDnJKB1IK9FHd7HxHzsYCJCyEJkKg5ofo23fd X-Received: by 2002:ac8:f02:: with SMTP id e2mr14757654qtk.216.1581442532830; Tue, 11 Feb 2020 09:35:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581442532; cv=none; d=google.com; s=arc-20160816; b=IIpil4kkD6r1dYwS76pIUDrL0xdWVy5cZPZ4niiGtzfgMSfA00Hah7QGQVAbYYUlj2 aAQ5gp3qHAhzcwP6E1MLWb2fXh+6UDDcbgAna9XSASFwV/83qc6UhcE3DiJNqA0ohbND PeiDrYlFkgn5ty/iPlDYqDgfLyHvkZSv00dRasnFAFx+5b1GXwlJwtcq5pYJXjH4mc00 VfIA2dCvQi2zm6TBtTE841GhUAn9kMJBTxsmAgDdd1Ca4B+5fB9n9l3URsyi2PcYMf9Z /+rQPF40BzkZ/clS8lNFBz4noNega9Ay8oeEbBcZdnAmDMRg9OxYodxLVCvSDfvzkqZm d26g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature; bh=dw7N2pZR97SczE3s06dFGgzG7Il+TOoFxfQV5ikQgiw=; b=ZugHDy9x7zbnqzMNY25S1aLTmhJ+V1OIQp3WLJeoDQGT/BHyw1BGiVsMq7xEnoBh+8 YqSwK6TOrYg9GjV1BfMeAlQauSunGeys2maOw5f0fi4/YQIGcWrll01aaQgVRYs2Hbwt jtMnXI6TwzFJRA2cL9Os8eeTeMw7Ubdq1zKBH318MRXcilhNv/lKjmWC8rfSgA1zo3ju NqzoovGl/c4/My1Bx8zXsYatrsV/eC9q9jbLQAnyV3C5Ho4eHfT6CGF/ZbrpSushkaNx Zc19thxoaBibs/ZHkO50c9eaqdTzA8om3AsBfY+CILJujLK/nYTG/pxCd272FK9KSu2U sNTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=XPKoNhK3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c4si2272019qtv.83.2020.02.11.09.35.32 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Feb 2020 09:35:32 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=XPKoNhK3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:54000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1ZRc-0003Yh-CJ for patch@linaro.org; Tue, 11 Feb 2020 12:35:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44115) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1ZRR-0003YY-Re for qemu-devel@nongnu.org; Tue, 11 Feb 2020 12:35:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1ZRQ-0008Vp-IG for qemu-devel@nongnu.org; Tue, 11 Feb 2020 12:35:21 -0500 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:51629) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j1ZRQ-0008UX-9Q for qemu-devel@nongnu.org; Tue, 11 Feb 2020 12:35:20 -0500 Received: by mail-wm1-x344.google.com with SMTP id t23so4686062wmi.1 for ; Tue, 11 Feb 2020 09:35:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dw7N2pZR97SczE3s06dFGgzG7Il+TOoFxfQV5ikQgiw=; b=XPKoNhK3vaN3q237RSjRex30XintZwBkIN2DOGI+CtHRJLredCR3kcaGcrbedCk1vv xkeI6usPBaOi+ZkVDjB3OYZd48VCCwv2cos2sNbT2SfBOGz036t6mSJaHuUr/kZv07hN Ld/P79JPJLyNDvlSf+htEo8iCxPK4cTQuP24CASzki0e4fLwf+h3D5IDtgzYJCS1KlLI 0d/SnvAK/Zqm0DFcm2+olXZt1IYBIefBbxVu4P2dcEHzqU22PswleyB+x2lt3RAroCU3 f9xfi8SC5PAXyGeBj3Wxrd1LXGTomD9nfLNCDK4+x4hCSezApwV8eta/7wQlVk0NeuF9 UlFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dw7N2pZR97SczE3s06dFGgzG7Il+TOoFxfQV5ikQgiw=; b=GPVYPRSs/2+v0tW+3K1EHoHwVh/xOVKZfp+d+jnezjiZdzvVhsgKeWCGggq2TNQHdj ayNGX1zeqHI4Etn981x1uayM41wZNnM7Z5JKlnX91gg4e6uz5hUsM/yzKReGLA4ooJ3i Me+s5RymcBW9/OxBK77pcSlAFQTDmZw+m9CvS/TeY4EUkyGWdrhQO8wH5GtLJIs2nhuv rIGsigD0oUQ1KtJEWCpHKB8cFf8BIzCcD6jwxy9oblm0FdQRxelDFfHHOHz0vhUnp61P oXnzhHsgInAgDIVKte84ufFz+WgYlHDos9DNLlzmf2CnMhYyyM9/t28LFJZemSIhatVg IcbA== X-Gm-Message-State: APjAAAWRVRlAfEuc03XbzJo9ORnEJTMSpgFreJ/tjKev0Z+h7aQl/Gph LIhie542NbxiCeALGRasB7C7Ug== X-Received: by 2002:a7b:c8d7:: with SMTP id f23mr6572014wml.173.1581442518434; Tue, 11 Feb 2020 09:35:18 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id b10sm5914398wrw.61.2020.02.11.09.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2020 09:35:16 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 320941FF87; Tue, 11 Feb 2020 17:35:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH] linux-user: un-register threads from RCU before exit Date: Tue, 11 Feb 2020 17:35:10 +0000 Message-Id: <20200211173510.16347-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Riku Voipio , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Through a mechanism I don't quite yet understand we can find ourselves with a left over RCU thread when we exit group. This is a racy failure that occurs for example with: alpha-linux-user running testthread with libhowvec.so plugin but only when run from make This may not be the correct fix but it seems to alleviate the symptoms. Signed-off-by: Alex Bennée Cc: Paolo Bonzini --- linux-user/exit.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) -- 2.20.1 diff --git a/linux-user/exit.c b/linux-user/exit.c index a362ef67d2c..1c7ce347324 100644 --- a/linux-user/exit.c +++ b/linux-user/exit.c @@ -28,12 +28,13 @@ extern void __gcov_dump(void); void preexit_cleanup(CPUArchState *env, int code) { + rcu_unregister_thread(); #ifdef TARGET_GPROF - _mcleanup(); + _mcleanup(); #endif #ifdef CONFIG_GCOV - __gcov_dump(); + __gcov_dump(); #endif - gdb_exit(env, code); - qemu_plugin_atexit_cb(); + gdb_exit(env, code); + qemu_plugin_atexit_cb(); }