From patchwork Tue Apr 7 15:51:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 185249 Delivered-To: patch@linaro.org Received: by 2002:a92:de47:0:0:0:0:0 with SMTP id e7csp5015359ilr; Tue, 7 Apr 2020 08:55:38 -0700 (PDT) X-Google-Smtp-Source: APiQypKwqtudj/llQ+irsjjqOZIfYZMnn5EPI/vdaCsymBQme4g0JtrmtB9wMoJcc+HP/nCpqCvB X-Received: by 2002:a37:a0d6:: with SMTP id j205mr2995302qke.455.1586274938679; Tue, 07 Apr 2020 08:55:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586274938; cv=none; d=google.com; s=arc-20160816; b=LF7dTwndfllckUg4tPFYWLPBr6rH6Gw5lRDB+OzNXOG1RqNu3aLQHk8HX4KkMM+QEl zSidvE1r88hPQOU5urIhVReGAbTssB/9WhlCG6dHSTCSKmbfIK87e2w4lxyEH30O3LNc VMy+xMrGc6KrhjCYrh81+SOY2VDAgi6xysosWt9tN3tH1JOppi0JJEnni3U8oBb5rh6K yDZv75pPRos5PpKQrGrOMoQkZA74duzex67AjGl0Nq13yI5cgA5qaThzHHQJB5U5Hw8N wTg15VXtgA4qDPLhuOnvf3U6Irp3+iyYBxgKHc5NRO2kHnV7iJiQtPjUuvrY3zWk/Y2t BWMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=rtMP8ceKEL32RxJnzf/04PfZMF0AhqQhuzU8HQYfCC8=; b=LG8XfTnYXLiYQHe3uPCIQc0paTdlI1JpK1q8uz7/njtaKZ8iHzTD+tqwGjewSFwJqe ffULlRpB/eHIKJ7B09e6e1og1FPr2Aop2Aa2PuBpNb6UviG189t7VHLOvIz6XITtpRLh wjIwqZ/9Lu9iCgDG00e+f2EnjGjxtRiwCZ8BogU+iauxTRWrnbJUA5h7CUYDkU/pOeZ5 W2kfil+24jDU59SxOAnG+h0s9chlFn20AEE2b4NXYDfxSCcZrnD1hR4p79EACZ/xOJpI 5XSNSCwKXbQbZ+wxpm48bWYFxPjFFNL9om5rS++0X87hyatm+1Std6kFmUmAIY37cfZO 0HfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=LUi2JkXA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id m10si2072832qvo.141.2020.04.07.08.55.38 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 Apr 2020 08:55:38 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=LUi2JkXA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:49716 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLqZe-0001aE-7T for patch@linaro.org; Tue, 07 Apr 2020 11:55:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43733) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLqVj-0003gS-G8 for qemu-devel@nongnu.org; Tue, 07 Apr 2020 11:51:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLqVi-0004Qc-I9 for qemu-devel@nongnu.org; Tue, 07 Apr 2020 11:51:35 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:35332) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jLqVi-0004Pu-B7 for qemu-devel@nongnu.org; Tue, 07 Apr 2020 11:51:34 -0400 Received: by mail-wm1-x32e.google.com with SMTP id r26so2381427wmh.0 for ; Tue, 07 Apr 2020 08:51:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rtMP8ceKEL32RxJnzf/04PfZMF0AhqQhuzU8HQYfCC8=; b=LUi2JkXAP2knRV0g2mRSbykVlLamWHHX/kbUWBV/mEN7jTEPFQiyYyKpVEeK7YCdf6 grn7xRdEYs6MdplFoMz7H+XWCnEfxEEARuEuEpCj16HUhxQEcX18zgAfk1wxXWFYUMfV 05+icVClCIgaZEljagw9i3iolyowYBEs17ml+8JV4okd4RUMIUWQDb4NMFqzfGw3R9+P hWRLGheQqO+Q5fL+dT2P+bPoCoZGudokuLKzMF2CpmkWAojG5xlUI3Sy9KPd09dawu4y QYVIaAi5LPMWOjifGhXw7tAensV1ic5tzOc965UKIz5QEnsrc8C0niOOG5V3pVCpf8vo yb0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rtMP8ceKEL32RxJnzf/04PfZMF0AhqQhuzU8HQYfCC8=; b=MazbOi4uiYggiHaixLIHWEL5Q2JQacUv7F4ox+mQPM+z/0z2gYm86gStVNsMn+b1+r E7cnIJ7jQqzf91xm0UHUI52bL6qxPb34rGAl0I8AkkjfyKUVqgAV/Y8GP1GH90G2SIgE fVQCPE2RfPR5V9ixyjeDUXIIYpTntq/6utmNd+a+tQUdPgcR2ZY4NTQKqbpROzCuW/Jg 7Kf5cMnu/4r0hHPuJlEbLiuHmRar+VQgRVa5sBTBWCliDCybM+Tv2THNBku3D5x9EkKq j0UYCfcYAitHkb98/WVFR31cJbS5MJhEGaLjHpkXQEqoeUVFmJRrgIGq8YSOVV23n+HH enUA== X-Gm-Message-State: AGi0PuYDLR36Ho3bmQ8+/xOnqSvIvA16AxSed2nzYWKdHZWFDhp0QzFn 0IzkAEA62w90GJpdSMzZHdg2L4mHJl4= X-Received: by 2002:a1c:1fca:: with SMTP id f193mr2935310wmf.5.1586274693285; Tue, 07 Apr 2020 08:51:33 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id w15sm21898416wra.25.2020.04.07.08.51.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2020 08:51:26 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id F1F491FF96; Tue, 7 Apr 2020 16:51:18 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal Date: Tue, 7 Apr 2020 16:51:13 +0100 Message-Id: <20200407155118.20139-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200407155118.20139-1-alex.bennee@linaro.org> References: <20200407155118.20139-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32e X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , Richard Henderson , qemu-devel@nongnu.org, Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson All other calls to normalize*Subnormal detect zero input before the call -- this is the only outlier. This case can happen with +0.0 + +0.0 = +0.0 or -0.0 + -0.0 = -0.0, so return a zero of the correct sign. Reported-by: Coverity (CID 1421991) Signed-off-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20200327232042.10008-1-richard.henderson@linaro.org> Message-Id: <20200403191150.863-8-alex.bennee@linaro.org> -- 2.20.1 diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 301ce3b537b..ae6ba718540 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -5856,6 +5856,9 @@ static floatx80 addFloatx80Sigs(floatx80 a, floatx80 b, flag zSign, zSig1 = 0; zSig0 = aSig + bSig; if ( aExp == 0 ) { + if (zSig0 == 0) { + return packFloatx80(zSign, 0, 0); + } normalizeFloatx80Subnormal( zSig0, &zExp, &zSig0 ); goto roundAndPack; }