From patchwork Tue Apr 14 20:06:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 185438 Delivered-To: patch@linaro.org Received: by 2002:a92:3d9a:0:0:0:0:0 with SMTP id k26csp1831707ilf; Tue, 14 Apr 2020 13:07:34 -0700 (PDT) X-Google-Smtp-Source: APiQypIx6BCKKIWxUncZbGz4dSw5oo0ftWgbUdQmK/HC4u4iSUOYmzmuAEHESwXVCliEpBa0b8DS X-Received: by 2002:ac8:748b:: with SMTP id v11mr5841052qtq.238.1586894854323; Tue, 14 Apr 2020 13:07:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586894854; cv=none; d=google.com; s=arc-20160816; b=p3WzioWkPAQUokk/6IVhYoc5GU7tPESFpk+TAs8aT+WQT3gq27UadylL16ZU2dciWd 2kWoyvQFQoppELdMASn16FGkG6JC5onfeeHzfTr8t0melzssrzMdLoVX5zrNsTv6i/C6 Ahh0NDaSfQIie/wcW5ug1CDPgg9RtDBWy6UmdPZ5RfYxpSy8hG95bhLm3qp7AqOhsdXi 8+mKmiE2WGpD1xsCgW2zbffRiFyVmVNYE2n5SVzRcQ0W0m+vmXl5hmlZBXiSh82mYjw1 lG3CDI05aSKBBRBqwjQgf5y6z7cY7FgBnQ+LjMgbD1uWziu87AdAQ+I64/p9DypdKH5P /GPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=LyYH1vUOROUp+ALOi+AoU+6fL4aHHF4lo5SZlCQc25A=; b=BwDIFeND4doqkop9Q+KQSxARwKoMThC/T8i6wy6EdpxeLkO1LoTym9d9vJripNtzq3 oA32XW84zQrl+zrkbKa7Rsd53NHv8aknfIiw5FWj4TrXPnVd0sMZeDP1iHvQZQTutGvd zll6FkD44P5fhhYrqdYeuoZyl535bhfoelV2gW0zXQvTwauuzAcPDVHaF6ggBGe062Up Uu87G16goSDXjK/HW0czNny/LFpHCKNjoMr0/gdxNkSAgoCHjho/md9A96EHtufuG+c1 O++jAAIPGgva/vM7wphvqHCQgiYOZ7QHZEwQNBJr/2cGzPdO8URYCgI2ozdlOvqrjBWN nFow== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=IvmSZCaf; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id b11si8196452qvt.124.2020.04.14.13.07.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Apr 2020 13:07:34 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=IvmSZCaf; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:38274 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jORqH-0005tN-Q7 for patch@linaro.org; Tue, 14 Apr 2020 16:07:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44422) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jORpN-0005t7-Ft for qemu-devel@nongnu.org; Tue, 14 Apr 2020 16:06:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jORpM-0005tB-5K for qemu-devel@nongnu.org; Tue, 14 Apr 2020 16:06:37 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:53853) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jORpL-0005si-RP for qemu-devel@nongnu.org; Tue, 14 Apr 2020 16:06:36 -0400 Received: by mail-wm1-x341.google.com with SMTP id d77so14502776wmd.3 for ; Tue, 14 Apr 2020 13:06:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LyYH1vUOROUp+ALOi+AoU+6fL4aHHF4lo5SZlCQc25A=; b=IvmSZCaf0yjtZb0gsBQFlbhTvILOEfY9/Da4cG8YJArjhfh8PFu+VvvGPNwWFmXngu nUAqz6JWGDzYetx0BdIs/hktD5qPK7yIJAPWw7Ym83EBvpgOBGH38W8400kKl46oFxud eJYdz5OGnaPSNiRcwtOVhH4VRa60dvbzommM1bJeEDfyfu7IMSTBmNKl+R0NSBesAo1/ VgSjf+giw6lzor5Kl4UcXufBev1A9diGflZkZRMu4ujfcuoofgum6dCM6Cfj3jGXm3vN 8C0fqeuBCWXqJQXnOeu3wRc04LkEY/eA83ae0z/xfFopbE3QuK+Ox6ylyPdcFNPx0zul Zy+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LyYH1vUOROUp+ALOi+AoU+6fL4aHHF4lo5SZlCQc25A=; b=jcL7ZmFofyWNn+OwNkuFmqNW/sIXhSE93CAqrt4VPN/v9lcvjGslQzn8aqOQSehEd6 38CT1N6REJkKJ7aiZqGlw0wqTU1gRmHkTfmWIShe3pt3a+89YUsi9kovpM8rIJ1Mclha inkCepg4DfL1kN8YHkGVT7dHUrHTYZFQeXkZqgcegjwLlJhYYHojxfR3kz8R1aFYIQuw ZvPJXlg3KyP+JyXssFuY0wLiEsG+2K8s3PapZSrAcswgjhqqj1YWwuEH0IdLHNyPSXiF iGld4r52mRTih8WxloO71b0xNjUJhHFyliwl8wmfExq3LJwtsC022QgMGtzbmD3nHr6k W1Vw== X-Gm-Message-State: AGi0PuaFdMTYtkY8D83R83fKqBc2CExRANRW5WbDRcK73cYojPDqFHug 44JBse8hnx+Y3zeKPFEtAEUDFQ== X-Received: by 2002:a1c:7ed7:: with SMTP id z206mr1406655wmc.64.1586894794435; Tue, 14 Apr 2020 13:06:34 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id u30sm22636wru.13.2020.04.14.13.06.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 13:06:32 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id AE2271FF8C; Tue, 14 Apr 2020 21:06:31 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v2 02/17] exec/cpu-all: Use bool for have_guest_base Date: Tue, 14 Apr 2020 21:06:16 +0100 Message-Id: <20200414200631.12799-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200414200631.12799-1-alex.bennee@linaro.org> References: <20200414200631.12799-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Riku Voipio , Richard Henderson , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= , Richard Henderson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- include/exec/cpu-all.h | 2 +- bsd-user/main.c | 4 ++-- linux-user/main.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) -- 2.20.1 diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h index 49384bb66a5..b4fb5832c4a 100644 --- a/include/exec/cpu-all.h +++ b/include/exec/cpu-all.h @@ -159,7 +159,7 @@ static inline void tswap64s(uint64_t *s) * This allows the guest address space to be offset to a convenient location. */ extern unsigned long guest_base; -extern int have_guest_base; +extern bool have_guest_base; extern unsigned long reserved_va; #if HOST_LONG_BITS <= TARGET_VIRT_ADDR_SPACE_BITS diff --git a/bsd-user/main.c b/bsd-user/main.c index 770c2b267ad..aef5531628a 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -42,7 +42,7 @@ int singlestep; unsigned long mmap_min_addr; unsigned long guest_base; -int have_guest_base; +bool have_guest_base; unsigned long reserved_va; static const char *interp_prefix = CONFIG_QEMU_INTERP_PREFIX; @@ -828,7 +828,7 @@ int main(int argc, char **argv) } } else if (!strcmp(r, "B")) { guest_base = strtol(argv[optind++], NULL, 0); - have_guest_base = 1; + have_guest_base = true; } else if (!strcmp(r, "drop-ld-preload")) { (void) envlist_unsetenv(envlist, "LD_PRELOAD"); } else if (!strcmp(r, "bsd")) { diff --git a/linux-user/main.c b/linux-user/main.c index 1d20a83d4e8..90ad365b439 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -59,7 +59,7 @@ static const char *cpu_type; static const char *seed_optarg; unsigned long mmap_min_addr; unsigned long guest_base; -int have_guest_base; +bool have_guest_base; /* * Used to implement backwards-compatibility for the `-strace`, and @@ -334,7 +334,7 @@ static void handle_arg_cpu(const char *arg) static void handle_arg_guest_base(const char *arg) { guest_base = strtol(arg, NULL, 0); - have_guest_base = 1; + have_guest_base = true; } static void handle_arg_reserved_va(const char *arg)