From patchwork Sat Apr 18 15:04:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 185546 Delivered-To: patch@linaro.org Received: by 2002:a92:3d9a:0:0:0:0:0 with SMTP id k26csp1835017ilf; Sat, 18 Apr 2020 08:07:56 -0700 (PDT) X-Google-Smtp-Source: APiQypKQrE3oxjOTnq6HwUxZp45e4GOd7lrB5P71uEuYoV8T8mpUKcS3A/x3MqdDv7QKhRtMaIZB X-Received: by 2002:a05:620a:b10:: with SMTP id t16mr6294896qkg.59.1587222476408; Sat, 18 Apr 2020 08:07:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587222476; cv=none; d=google.com; s=arc-20160816; b=SR2MBRt7HwBOoJjYsj4aLrP/Y9zG55XZM2XBxQuLrMQm422aBlkQ0L8vqvEAJpgyJt aChI0MB2pBh1f3OsGikCRgx2JmuRNBOzwM2cKnMTmeYDC+bz6RqKP0CVIgPxLb5gKMup Klmx94P9+uirKo5+oRn1h5Ua/09JfW6+SflKIcaOlhvqAau9iHdfqVRU/VxfNhOm7gwP Jr3LpEivzfNxZxLFqkYIEFQqH2+BAEZ7Hj0Z9cEKqsWMdvb7TzPkEM1kD7dE7VVXaINj fTLVakurF1ra+f7AqoATffAE/gHGCy3rOIUy5GnfQynnk9oMXjN90V/ZB6isdyuJgpKX TzTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=XzOExfY3LqCZ8KkyShXQQH+aniJsYLCzLWdtJXU+p94=; b=uAMR9hFkCTEVkf/p6i4M7ELmiSyvcvZgNsvBRj6ahnKILJdy1Uc69hJM/2MBEdaZ7T UAfAiv1p+/YQmvo6RwREDX0m8eQZFMpNBb3vdbrnLILuhWjhxIkBgszi5e6zsZm2oLJx wA3NEvMGrvT+2BhUPfzNNtA+fuKKtNWFgK3fcJeRWsOFYP4CbWPdtk+rV11I8X+4dTDO KYrZZFM2e1UITPJXXB0RMEBY4O0QHw8U7m3LXnRpx6GrlwQXZ6FkURKwNz/jnP8+JQJH MME5dl2ebrbyMAGyJtBY370RBqPM+S3O3fK40dzf+gPBrgcN5pkiGoIW5bA4rRFxTUFY NXzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=zGSkfEtY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c2si14224569qtd.150.2020.04.18.08.07.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 18 Apr 2020 08:07:56 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=zGSkfEtY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:58632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPp4W-0003rf-0F for patch@linaro.org; Sat, 18 Apr 2020 11:07:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36828) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPp13-00076W-Jp for qemu-devel@nongnu.org; Sat, 18 Apr 2020 11:04:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jPp12-0003Es-Cg for qemu-devel@nongnu.org; Sat, 18 Apr 2020 11:04:21 -0400 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]:46598) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jPp12-00038w-6N for qemu-devel@nongnu.org; Sat, 18 Apr 2020 11:04:20 -0400 Received: by mail-pg1-x541.google.com with SMTP id 188so2651799pgj.13 for ; Sat, 18 Apr 2020 08:04:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XzOExfY3LqCZ8KkyShXQQH+aniJsYLCzLWdtJXU+p94=; b=zGSkfEtYU7Ugb3/XbquDTf3du/ody1A3ZvJO3ALfMo5QVw7H2kLzZiTbqZ6C7ehoxk F4du6T/hB2lvg2rQrXs7m5ztEL45z9GNd7TuaI+mHZ5tapKr9derb2OSUo+YmwhTe0cM osRPx8To6FJ/Asn5iGqZkhrhjcVY6vSzYKDeumscY9O2+G66+TUWGYDHc3c3Nvo5Z0DW Fft7hmp+FRo0OOxRG3VzPB7fKTelX2iTmp2Eaxttrjf0mySRZESHy89IFOze0fBfjywl 52XT0eFWeQJwGy6H4Uujc0vnzYLoYBOYFlCq2/JiLGcYE0dXy7Nu0qrx7ddGqnSMGYWX oiDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XzOExfY3LqCZ8KkyShXQQH+aniJsYLCzLWdtJXU+p94=; b=ek//N34GZrsDD05Zmljuz/iiZPac011jQ+YegCYeqI7BrhDLbLkD/F5vbKqtUlBDJg 5a6cYAkmUYx9Is91krtBUDc4y7SWX7nLm1Dneqvyvs5SLrmTWDqI56yk/io/4x69SP+z 5UBP5Eu0xG6jJzXGZ0r6T/KCY0w45PCtEVwd+eFYTQ7oTOS8QyC+LFTcfWkwESfhwyRh 4IHNypfnXybJ2r1V6O6wTz/zMUOgFTMl6GWmzrvZZcHF/dMc5ipHqyVhOm2Nnjlp5sb7 G0QX+1hy7WnaSnZSP3LXRbKn+nu7l1qgzk8AER4W3UNQXjd5U55c2SuL1d2vJx6kTZba UqMQ== X-Gm-Message-State: AGi0PuZAA7fG5KTtWDjZNYmQLf357E5JKPA7hOSC6pYKKCdS+dRmpAPF AhDT3LZ6cEKXDCXQG3Bf4SpLzesGauo= X-Received: by 2002:a62:6103:: with SMTP id v3mr8823911pfb.279.1587222258558; Sat, 18 Apr 2020 08:04:18 -0700 (PDT) Received: from localhost.localdomain (174-21-149-226.tukw.qwest.net. [174.21.149.226]) by smtp.gmail.com with ESMTPSA id t103sm8668601pjb.46.2020.04.18.08.04.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Apr 2020 08:04:17 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 3/7] target/ppc: Use tcg_gen_gvec_dup_imm Date: Sat, 18 Apr 2020 08:04:07 -0700 Message-Id: <20200418150411.1831-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200418150411.1831-1-richard.henderson@linaro.org> References: <20200418150411.1831-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::541 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, david@redhat.com, zhiwei_liu@c-sky.com, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We can now unify the implementation of the 3 VSPLTI instructions. Signed-off-by: Richard Henderson --- target/ppc/translate/vmx-impl.inc.c | 32 ++++++++++++++++------------- target/ppc/translate/vsx-impl.inc.c | 2 +- 2 files changed, 19 insertions(+), 15 deletions(-) -- 2.20.1 Acked-by: David Gibson Reviewed-by: Alex Bennée diff --git a/target/ppc/translate/vmx-impl.inc.c b/target/ppc/translate/vmx-impl.inc.c index 81d5a7a341..403ed3a01c 100644 --- a/target/ppc/translate/vmx-impl.inc.c +++ b/target/ppc/translate/vmx-impl.inc.c @@ -1035,21 +1035,25 @@ GEN_VXRFORM_DUAL(vcmpbfp, PPC_ALTIVEC, PPC_NONE, \ GEN_VXRFORM_DUAL(vcmpgtfp, PPC_ALTIVEC, PPC_NONE, \ vcmpgtud, PPC_NONE, PPC2_ALTIVEC_207) -#define GEN_VXFORM_DUPI(name, tcg_op, opc2, opc3) \ -static void glue(gen_, name)(DisasContext *ctx) \ - { \ - int simm; \ - if (unlikely(!ctx->altivec_enabled)) { \ - gen_exception(ctx, POWERPC_EXCP_VPU); \ - return; \ - } \ - simm = SIMM5(ctx->opcode); \ - tcg_op(avr_full_offset(rD(ctx->opcode)), 16, 16, simm); \ +static void gen_vsplti(DisasContext *ctx, int vece) +{ + int simm; + + if (unlikely(!ctx->altivec_enabled)) { + gen_exception(ctx, POWERPC_EXCP_VPU); + return; } -GEN_VXFORM_DUPI(vspltisb, tcg_gen_gvec_dup8i, 6, 12); -GEN_VXFORM_DUPI(vspltish, tcg_gen_gvec_dup16i, 6, 13); -GEN_VXFORM_DUPI(vspltisw, tcg_gen_gvec_dup32i, 6, 14); + simm = SIMM5(ctx->opcode); + tcg_gen_gvec_dup_imm(vece, avr_full_offset(rD(ctx->opcode)), 16, 16, simm); +} + +#define GEN_VXFORM_VSPLTI(name, vece, opc2, opc3) \ +static void glue(gen_, name)(DisasContext *ctx) { gen_vsplti(ctx, vece); } + +GEN_VXFORM_VSPLTI(vspltisb, MO_8, 6, 12); +GEN_VXFORM_VSPLTI(vspltish, MO_16, 6, 13); +GEN_VXFORM_VSPLTI(vspltisw, MO_32, 6, 14); #define GEN_VXFORM_NOA(name, opc2, opc3) \ static void glue(gen_, name)(DisasContext *ctx) \ @@ -1559,7 +1563,7 @@ GEN_VXFORM_DUAL(vsldoi, PPC_ALTIVEC, PPC_NONE, #undef GEN_VXRFORM_DUAL #undef GEN_VXRFORM1 #undef GEN_VXRFORM -#undef GEN_VXFORM_DUPI +#undef GEN_VXFORM_VSPLTI #undef GEN_VXFORM_NOA #undef GEN_VXFORM_UIMM #undef GEN_VAFORM_PAIRED diff --git a/target/ppc/translate/vsx-impl.inc.c b/target/ppc/translate/vsx-impl.inc.c index 8287e272f5..b518de46db 100644 --- a/target/ppc/translate/vsx-impl.inc.c +++ b/target/ppc/translate/vsx-impl.inc.c @@ -1579,7 +1579,7 @@ static void gen_xxspltib(DisasContext *ctx) return; } } - tcg_gen_gvec_dup8i(vsr_full_offset(rt), 16, 16, uim8); + tcg_gen_gvec_dup_imm(MO_8, vsr_full_offset(rt), 16, 16, uim8); } static void gen_xxsldwi(DisasContext *ctx)