diff mbox series

[v1,4/7] accel/tcg: don't disable exec_tb trace events

Message ID 20200501145713.19822-5-alex.bennee@linaro.org
State Superseded
Headers show
Series various tcg and linux-user updates | expand

Commit Message

Alex Bennée May 1, 2020, 2:57 p.m. UTC
I doubt the well predicted trace event check is particularly special in
the grand context of TCG code execution.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
 accel/tcg/trace-events | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
2.20.1

Comments

Philippe Mathieu-Daudé May 11, 2020, 12:16 p.m. UTC | #1
On 5/1/20 4:57 PM, Alex Bennée wrote:
> I doubt the well predicted trace event check is particularly special in

> the grand context of TCG code execution.

> 

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> ---

>   accel/tcg/trace-events | 8 ++++----

>   1 file changed, 4 insertions(+), 4 deletions(-)

> 

> diff --git a/accel/tcg/trace-events b/accel/tcg/trace-events

> index 01852217a6..385b9f749b 100644

> --- a/accel/tcg/trace-events

> +++ b/accel/tcg/trace-events

> @@ -1,10 +1,10 @@

>   # See docs/devel/tracing.txt for syntax documentation.

>   

> -# TCG related tracing (mostly disabled by default)

> +# TCG related tracing

>   # cpu-exec.c

> -disable exec_tb(void *tb, uintptr_t pc) "tb:%p pc=0x%"PRIxPTR

> -disable exec_tb_nocache(void *tb, uintptr_t pc) "tb:%p pc=0x%"PRIxPTR

> -disable exec_tb_exit(void *last_tb, unsigned int flags) "tb:%p flags=0x%x"

> +exec_tb(void *tb, uintptr_t pc) "tb:%p pc=0x%"PRIxPTR

> +exec_tb_nocache(void *tb, uintptr_t pc) "tb:%p pc=0x%"PRIxPTR

> +exec_tb_exit(void *last_tb, unsigned int flags) "tb:%p flags=0x%x"

>   

>   # translate-all.c

>   translate_block(void *tb, uintptr_t pc, uint8_t *tb_code) "tb:%p, pc:0x%"PRIxPTR", tb_code:%p"

> 


Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff mbox series

Patch

diff --git a/accel/tcg/trace-events b/accel/tcg/trace-events
index 01852217a6..385b9f749b 100644
--- a/accel/tcg/trace-events
+++ b/accel/tcg/trace-events
@@ -1,10 +1,10 @@ 
 # See docs/devel/tracing.txt for syntax documentation.
 
-# TCG related tracing (mostly disabled by default)
+# TCG related tracing
 # cpu-exec.c
-disable exec_tb(void *tb, uintptr_t pc) "tb:%p pc=0x%"PRIxPTR
-disable exec_tb_nocache(void *tb, uintptr_t pc) "tb:%p pc=0x%"PRIxPTR
-disable exec_tb_exit(void *last_tb, unsigned int flags) "tb:%p flags=0x%x"
+exec_tb(void *tb, uintptr_t pc) "tb:%p pc=0x%"PRIxPTR
+exec_tb_nocache(void *tb, uintptr_t pc) "tb:%p pc=0x%"PRIxPTR
+exec_tb_exit(void *last_tb, unsigned int flags) "tb:%p flags=0x%x"
 
 # translate-all.c
 translate_block(void *tb, uintptr_t pc, uint8_t *tb_code) "tb:%p, pc:0x%"PRIxPTR", tb_code:%p"