From patchwork Mon Jul 27 12:23:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 247169 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp4755286ilg; Mon, 27 Jul 2020 05:26:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqhYSrmkVmHCP89MKE+6MGZ2UwxxCK0KXODWhKg1IYarSa8Wfetxqq7ofIdQ4OaaQ/Ibvj X-Received: by 2002:a25:6f83:: with SMTP id k125mr6937593ybc.204.1595852804296; Mon, 27 Jul 2020 05:26:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595852804; cv=none; d=google.com; s=arc-20160816; b=OUpWAJ0LdA2vRNFhF6hC/s9F1Eo+WefEKiEQh0rOhyBHKDXB9IooPpPHAiWYPdJJ9F Gbq24tQdIYG0JM9RHa1qS3IpA/4rCZ44DmMIjIuaY6QIT0vBoQGdviWQL1WiMgYWkt/z N7k7LllBXTlGsC9WgEcEwVe7OSWMqbLl7zQ9EXyrceU4Yt9VwXdF9uKMHGUPbOOu7uyp y/uB1JqmV/KSgaEmK1pUiAo3A3+BB2Qtd33miNRDh6CHZ3XyqnbgtcdyeYL8snAwTOrr JZJ1IjuTWrJpmfL1bo16eWvrq2uN68LWDEEEXAyMY5czPU45uURxnmkBTmrjxkXxb0yu PqPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=RdPhdnzXcxoBzSFWnxkcl0n4uuKjKBt4ReAJhvFqFBI=; b=NCjA2An95Ckk7RscJkyY5JCCJTbPDfiBPhOuCHs7Eg8gKVMiKk8ne2uQHDUzHrbOGx FXm0YvkbILN0y7X7WrKQYgGkYt1qYyIDtRGmm6lxXmqC8r8IW1rQIJfIoL+aXjB6k4bN j8UQXaQZbSCJGoyphl3oTH3gcwhP1ITQv88Q27BiZZGAh6S+U/2MR/xIH/DR6ueNVg82 jJsVoFZ0Vk1p1L6PRjSUbE46be/7ayh9i/QPg3Lb/W5pawlFx76tJRQQenGRj24pOvdO QJX2kzhL6dzoXCN14nwtVtQW7+k+ReQ1MogU+DFYNH5s/j9rxm3uA1/yxjBnNRJrGgWd 4mQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=WtLVazLl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id l202si7312866ybf.425.2020.07.27.05.26.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Jul 2020 05:26:44 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=WtLVazLl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:48490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k02DL-0001w7-Pc for patch@linaro.org; Mon, 27 Jul 2020 08:26:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k02Ao-0006sX-5t for qemu-devel@nongnu.org; Mon, 27 Jul 2020 08:24:06 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:40784) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k02Am-0006Q2-Io for qemu-devel@nongnu.org; Mon, 27 Jul 2020 08:24:05 -0400 Received: by mail-wm1-x331.google.com with SMTP id k20so6899922wmi.5 for ; Mon, 27 Jul 2020 05:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RdPhdnzXcxoBzSFWnxkcl0n4uuKjKBt4ReAJhvFqFBI=; b=WtLVazLlyGxLumWMvSSxOsNXsmQ0Lh/G+iOj3NWwWumK0qlSskgMd7Y2wwn13xk4JV lBKkbt2YGwpH7FFBT/Rd0V+hjBJ0SLGZ7GgJUGUvaT+PZCMg53eGMFPxtHXZUPlGN6os fqA7Osuszb7+DF8AnhDqzrZ6iWJ37RMRAWL4YFQxWoWrY6mdqgrhZckRJYxUONsutzGs 564kCea/6yhTubf+CrO7v/TB20fjeJO01NlE5BCcLEaoE2KDWfm5kB5k/oe1m4eSYns0 fGC9eGtbaouRslv/MK8L/xQsWZqLM4wTDLNKp4oe5ldUMkgF9GG/n/rHq2BJDDpvufp4 n6yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RdPhdnzXcxoBzSFWnxkcl0n4uuKjKBt4ReAJhvFqFBI=; b=adW/5NZ4/7L+yuSzbS7ET34BpxZ187vu/iJ6Tkhu+TZjpS3TWV04vBVqquk8uAyan/ uXT7OZuns0usRX5bVs93ld1EKOzRWos0uVx7adzWUEXxT0hG+yYtv75ZSvifc6llA3EY KLxqO6yYnV2zhjLEGZEUAAy2bL6bD2S7O4V+n3PsdDE6++u1vP67I+wXLisKMeLEJfB6 U2E2/MFJFuFc0KR41IdqxhZDhlLYZejnYl9iiLZ07/nnMJcnSFSaDwywOYzATJw8GGNR Jvefai2Se/rqfgLvTHFuoVcXb/IdBymXN9n0fHvBJTGyLFWFFzgk+9fMHl/nqppPEiue IXcQ== X-Gm-Message-State: AOAM5330jX35PmI1xudCPL9AbYGeFDFSi7DObSgj4JcJCo8OAEd+kcOp ChWZXj+6ETGN+0w1RRJyNVOptQ== X-Received: by 2002:a1c:19c4:: with SMTP id 187mr21077590wmz.100.1595852642942; Mon, 27 Jul 2020 05:24:02 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id c10sm12649159wro.84.2020.07.27.05.23.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 05:24:00 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id A2E0F1FF8F; Mon, 27 Jul 2020 13:23:57 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 03/16] semihosting: don't send the trailing '\0' Date: Mon, 27 Jul 2020 13:23:44 +0100 Message-Id: <20200727122357.31263-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200727122357.31263-1-alex.bennee@linaro.org> References: <20200727122357.31263-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x331.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , KONRAD Frederic , Richard Henderson , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: KONRAD Frederic Don't send the trailing 0 from the string. Signed-off-by: KONRAD Frederic Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <1592215252-26742-2-git-send-email-frederic.konrad@adacore.com> Message-Id: <20200724064509.331-4-alex.bennee@linaro.org> -- 2.20.1 diff --git a/hw/semihosting/console.c b/hw/semihosting/console.c index 22e7827824a..9b4fee92602 100644 --- a/hw/semihosting/console.c +++ b/hw/semihosting/console.c @@ -52,7 +52,9 @@ static GString *copy_user_string(CPUArchState *env, target_ulong addr) do { if (cpu_memory_rw_debug(cpu, addr++, &c, 1, 0) == 0) { - s = g_string_append_c(s, c); + if (c) { + s = g_string_append_c(s, c); + } } else { qemu_log_mask(LOG_GUEST_ERROR, "%s: passed inaccessible address " TARGET_FMT_lx,