diff mbox series

[v2,4/4] configure: Test if $make actually exists

Message ID 20200825202755.50626-5-r.bolshakov@yadro.com
State Accepted
Commit 8e2c76bd3ff2e81738195bdcc6bfdb8b2ddc7649
Headers show
Series [v2,1/4] configure: Use discovered make for in-source build | expand

Commit Message

Roman Bolshakov Aug. 25, 2020, 8:27 p.m. UTC
configure doesn't detect if $make is installed on the build host.
This is also helpful for hosts where an alias for make is used, i.e.
configure would fail if gmake is not present on macOS.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
---
 configure | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Thomas Huth Oct. 12, 2020, 9:49 a.m. UTC | #1
On 25/08/2020 22.27, Roman Bolshakov wrote:
> configure doesn't detect if $make is installed on the build host.

> This is also helpful for hosts where an alias for make is used, i.e.

> configure would fail if gmake is not present on macOS.

> 

> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

> Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>

> ---

>  configure | 4 ++++

>  1 file changed, 4 insertions(+)

> 

> diff --git a/configure b/configure

> index 664084992b..9230832da2 100755

> --- a/configure

> +++ b/configure

> @@ -2029,6 +2029,10 @@ if test -z "$python"

>  then

>      error_exit "Python not found. Use --python=/path/to/python"

>  fi

> +if ! has "$make"

> +then

> +    error_exit "GNU make ($make) not found"

> +fi

>  

>  # Note that if the Python conditional here evaluates True we will exit

>  # with status 1 which is a shell 'false' value.

> 


Reviewed-by: Thomas Huth <thuth@redhat.com>
Laurent Vivier Dec. 13, 2020, 5:22 p.m. UTC | #2
Le 12/10/2020 à 11:49, Thomas Huth a écrit :
> On 25/08/2020 22.27, Roman Bolshakov wrote:

>> configure doesn't detect if $make is installed on the build host.

>> This is also helpful for hosts where an alias for make is used, i.e.

>> configure would fail if gmake is not present on macOS.

>>

>> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

>> Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>

>> ---

>>  configure | 4 ++++

>>  1 file changed, 4 insertions(+)

>>

>> diff --git a/configure b/configure

>> index 664084992b..9230832da2 100755

>> --- a/configure

>> +++ b/configure

>> @@ -2029,6 +2029,10 @@ if test -z "$python"

>>  then

>>      error_exit "Python not found. Use --python=/path/to/python"

>>  fi

>> +if ! has "$make"

>> +then

>> +    error_exit "GNU make ($make) not found"

>> +fi

>>  

>>  # Note that if the Python conditional here evaluates True we will exit

>>  # with status 1 which is a shell 'false' value.

>>

> 

> Reviewed-by: Thomas Huth <thuth@redhat.com>

> 

> 


Applied to my trivial-patches branch.

Thanks,
Laurent
diff mbox series

Patch

diff --git a/configure b/configure
index 664084992b..9230832da2 100755
--- a/configure
+++ b/configure
@@ -2029,6 +2029,10 @@  if test -z "$python"
 then
     error_exit "Python not found. Use --python=/path/to/python"
 fi
+if ! has "$make"
+then
+    error_exit "GNU make ($make) not found"
+fi
 
 # Note that if the Python conditional here evaluates True we will exit
 # with status 1 which is a shell 'false' value.