diff mbox series

[2/2] meson: remove duplicate qxl sources

Message ID 20200907071903.8065-3-kraxel@redhat.com
State Superseded
Headers show
Series meson: fix device module builds | expand

Commit Message

Gerd Hoffmann Sept. 7, 2020, 7:19 a.m. UTC 
We should add sources to the softmmu_ss or module_ss but not both.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/display/meson.build | 2 --
 1 file changed, 2 deletions(-)

Comments

Philippe Mathieu-Daudé Sept. 7, 2020, 8:08 a.m. UTC | #1 
On 9/7/20 9:19 AM, Gerd Hoffmann wrote:
> We should add sources to the softmmu_ss or module_ss but not both.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/display/meson.build | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/hw/display/meson.build b/hw/display/meson.build
> index 78adaf9db463..ef8eb093acbb 100644
> --- a/hw/display/meson.build
> +++ b/hw/display/meson.build
> @@ -45,8 +45,6 @@ if config_all_devices.has_key('CONFIG_QXL')
>    hw_display_modules += {'qxl': qxl_ss}
>  endif
>  
> -softmmu_ss.add(when: 'CONFIG_QXL', if_true: files('qxl.c', 'qxl-logger.c', 'qxl-render.c'))
> -
>  softmmu_ss.add(when: 'CONFIG_DPCD', if_true: files('dpcd.c'))
>  softmmu_ss.add(when: 'CONFIG_XLNX_ZYNQMP_ARM', if_true: files('xlnx_dp.c'))
>  

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff mbox series

Patch

diff --git a/hw/display/meson.build b/hw/display/meson.build
index 78adaf9db463..ef8eb093acbb 100644
--- a/hw/display/meson.build
+++ b/hw/display/meson.build
@@ -45,8 +45,6 @@  if config_all_devices.has_key('CONFIG_QXL')
   hw_display_modules += {'qxl': qxl_ss}
 endif
 
-softmmu_ss.add(when: 'CONFIG_QXL', if_true: files('qxl.c', 'qxl-logger.c', 'qxl-render.c'))
-
 softmmu_ss.add(when: 'CONFIG_DPCD', if_true: files('dpcd.c'))
 softmmu_ss.add(when: 'CONFIG_XLNX_ZYNQMP_ARM', if_true: files('xlnx_dp.c'))