From patchwork Wed Sep 9 11:27:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 249452 Delivered-To: patch@linaro.org Received: by 2002:a92:5b9c:0:0:0:0:0 with SMTP id c28csp308873ilg; Wed, 9 Sep 2020 04:30:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxN3zVdwsA4pxBYC8iJ8TLLxHPOuYD/+iap9V846fymL31q4ebTsYX9ldeZ0peL7F/gaJzB X-Received: by 2002:a25:6b4e:: with SMTP id o14mr5143117ybm.23.1599651038431; Wed, 09 Sep 2020 04:30:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599651038; cv=none; d=google.com; s=arc-20160816; b=EUoX6l4yMQVOrdgScruE7MLmavzJ3P6ZXqfpriDdqoXxI8tLCTa6gNaatpBIEGfqoC XF5nnyJooR14Dp3xBWHoXwCAqBKh7DUwOzMHjz240gtXcnVj4tvjzPvMjc4vAYFV1daQ 95QqzEb4jBEGX6eW+CM/J5Cxr50q2rT2SJHojuwDsOYBH/Mpjt0mBryOfGsRnrDTNj+e d9MdR+XGtpmjjs5FVOxHSPdV50EcmVI7fsV6zJJYaga53jAa0X9TaNcdMwOVnnsYWD/x uZZQBsUL1XcXXB/VgEu6V5paJ6eWCApoUTNpeRwy1ulQdFrfm4F2yB56uFbK/i8PqDjK TWcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=x50AKbw2C1EpufEPXDHUDVL3npAkap6GTDHFJFmIt0E=; b=scIQmYYArUtJh1s9pHpwKU06SiMPSIFxGxomcwrERg1iaSjKdcCtbuCS6vXB4l/9Ue PvKGSGLssm96WSygMotZ38PhVztbSRApYz+kmc7DLaIi9ZzoHGa06xn0P+WO4bplS3rz osJHOmXKYtqarFSiXgSkCtNBedxduHECPqOPG+KiR0lRIiNfp1kO1jDlCULMA0ebZaPS HgDcoMjiweYPbQpldhm6btre30Xxk/tTMCP+zytS3wdcI8weS3D0pOdCqqcXMf/Q7Unw Fu6nWn+E+WQjZ79etLtwrNQFsDjYn7ZwV99CY8LITXlWeZ+38T6SZJxgns7ERyBIkUI4 +pZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=NesUVPWh; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s88si2759654ybi.379.2020.09.09.04.30.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 Sep 2020 04:30:38 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=NesUVPWh; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:55342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFyJB-0003cO-PY for patch@linaro.org; Wed, 09 Sep 2020 07:30:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFyGb-0000CI-Fk for qemu-devel@nongnu.org; Wed, 09 Sep 2020 07:27:57 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:35079) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFyGZ-0006Xe-MZ for qemu-devel@nongnu.org; Wed, 09 Sep 2020 07:27:57 -0400 Received: by mail-wr1-x443.google.com with SMTP id e16so2562999wrm.2 for ; Wed, 09 Sep 2020 04:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=x50AKbw2C1EpufEPXDHUDVL3npAkap6GTDHFJFmIt0E=; b=NesUVPWhBcQDal87ZYPspetZ9Kf56iy+WtLFgil7FzV0+Dqohpz4/7J4gCX0QxWW4i RJ+lqNGJIycrgyUSpwm5h49XaVwyRkK28YXkTl0hIiTBQ3aCQNJq2QCPmNopbtP7BEfD OqLQ0E35a1VBooxIa0hc8uJlUzDjyODg745gufMl1m5dE5vMjAvuryXQUh7PqBhkzUSX h8l4gSnHiR5hNQAsxwd8mmt4Ih+drvPej4fvSUDvLeVnw8yV6EmgUiDTE1PDl/KoLhqQ eEQ93JjpoxWcwBHLGswmkDOKQpqzO3A10xBGDcxf7BZf1lhm6X7OHHSjcIukjQjVblog jurQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=x50AKbw2C1EpufEPXDHUDVL3npAkap6GTDHFJFmIt0E=; b=PhYZ0vt3RtItRDgtw9miR1INXZLjIunHqri69xUlm6/hL9F1zNubJ8y9iegXyUszlu kol/t0NiOWoZz5bKKzMQwgZ60JO0ON/d1j18/FsMc04YLfoe9UU8q/yOX1IMRySNmpXE NY3EhsXlMgbCxk2UO8qQEtEsHOTlVbD2VT2AlTrNEynH0Trn5PsQmhMDrwclGEJRbken nrdvyEisUL14tenIirX+eo1nRUixfrtWFZPVxos84Y+tmC6VDQ+mcceqccKVnRw4ZvoD Ct+5x6F7tfkJ0dVLPOWEz6QP/DP4K+jaPz63KET9L4YzJcPyIOkf6WHNW+/uMc74pIZP ehig== X-Gm-Message-State: AOAM530f48ssbi0sjJp3rE4XcEjVxF4fB8+5+MJkWvCNwlGzxUcKmx3T 2+hBf0uTenySRQuNi77HrPSgLg== X-Received: by 2002:adf:efc9:: with SMTP id i9mr3546046wrp.187.1599650874411; Wed, 09 Sep 2020 04:27:54 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id t22sm4029931wmt.1.2020.09.09.04.27.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 04:27:47 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id AD7B71FF93; Wed, 9 Sep 2020 12:27:42 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v2 07/10] hw/i386: make explicit clearing of pch_rev_id Date: Wed, 9 Sep 2020 12:27:38 +0100 Message-Id: <20200909112742.25730-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200909112742.25730-1-alex.bennee@linaro.org> References: <20200909112742.25730-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::443; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x443.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, Eduardo Habkost , "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , richard.henderson@linaro.org, f4bug@amsat.org, cota@braap.org, Paolo Bonzini , aurelien@aurel32.net, Richard Henderson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Some compilers (notably the Xenial gcc in Travis) fail to spot that this will always be set if pch_dev_id != 0xffff. Given this is setup code and using _Pragma to override is equally as ugly lets just remove the doubt from the compilers mind. Signed-off-by: Alex Bennée --- hw/i386/pc_piix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 Reviewed-by: Philippe Mathieu-Daudé diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 32b1453e6a8..33fa035fb7f 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -930,7 +930,7 @@ void igd_passthrough_isa_bridge_create(PCIBus *bus, uint16_t gpu_dev_id) struct PCIDevice *bridge_dev; int i, num; uint16_t pch_dev_id = 0xffff; - uint8_t pch_rev_id; + uint8_t pch_rev_id = 0; num = ARRAY_SIZE(igd_combo_id_infos); for (i = 0; i < num; i++) {