diff mbox series

[2/7] make: run shell with pipefail

Message ID 20201014135416.1290679-3-pbonzini@redhat.com
State Superseded
Headers show
Series build: replace ninjatool with ninja | expand

Commit Message

Paolo Bonzini Oct. 14, 2020, 1:54 p.m. UTC
Without pipefail, it is possible to miss failures if the recipes
include pipes.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 Makefile | 2 ++
 1 file changed, 2 insertions(+)

Comments

Daniel P. Berrangé Oct. 14, 2020, 4:27 p.m. UTC | #1
On Wed, Oct 14, 2020 at 09:54:11AM -0400, Paolo Bonzini wrote:
> Without pipefail, it is possible to miss failures if the recipes

> include pipes.

> 

> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

> ---

>  Makefile | 2 ++

>  1 file changed, 2 insertions(+)


Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index c37e513431..5e51e61c3b 100644
--- a/Makefile
+++ b/Makefile
@@ -14,6 +14,8 @@  SRC_PATH=.
 # we have explicit rules for everything
 MAKEFLAGS += -rR
 
+SHELL = /usr/bin/env bash -o pipefail
+
 # Usage: $(call quiet-command,command and args,"NAME","args to print")
 # This will run "command and args", and either:
 #  if V=1 just print the whole command and args