| Message ID | 20201209170059.20742-7-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | testing/next (without-features, gitlab, python) | expand |
On 09/12/2020 18.00, Alex Bennée wrote: > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > .gitlab-ci.yml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index 878d114d40..f87584ca8f 100644 > --- a/.gitlab-ci.yml > +++ b/.gitlab-ci.yml > @@ -441,6 +441,13 @@ build-without-default-devices: > IMAGE: debian-amd64 > CONFIGURE_ARGS: --without-default-devices --disable-user > > +build-without-default-features: > + <<: *native_build_job_definition > + variables: > + IMAGE: centos8 > + CONFIGURE_ARGS: --without-default-devices --without-default-features --disable-user > + MAKE_CHECK_ARGS: check-unit I wonder whether we'd rather want to check without "--without-default-devices" here to see whether all code compiles fine with "--without-default-features" ... ? Thomas
Thomas Huth <thuth@redhat.com> writes: > On 09/12/2020 18.00, Alex Bennée wrote: >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >> --- >> .gitlab-ci.yml | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml >> index 878d114d40..f87584ca8f 100644 >> --- a/.gitlab-ci.yml >> +++ b/.gitlab-ci.yml >> @@ -441,6 +441,13 @@ build-without-default-devices: >> IMAGE: debian-amd64 >> CONFIGURE_ARGS: --without-default-devices --disable-user >> >> +build-without-default-features: >> + <<: *native_build_job_definition >> + variables: >> + IMAGE: centos8 >> + CONFIGURE_ARGS: --without-default-devices --without-default-features --disable-user >> + MAKE_CHECK_ARGS: check-unit > > I wonder whether we'd rather want to check without > "--without-default-devices" here to see whether all code compiles fine with > "--without-default-features" ... ? Yeah at the moment the full-fat without everything doesn't achieve much. So how about I swap the IMAGE around with the previous build and drop the --without-default-devices? > > Thomas -- Alex Bennée
On 09/12/2020 19.32, Alex Bennée wrote: > > Thomas Huth <thuth@redhat.com> writes: > >> On 09/12/2020 18.00, Alex Bennée wrote: >>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >>> --- >>> .gitlab-ci.yml | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml >>> index 878d114d40..f87584ca8f 100644 >>> --- a/.gitlab-ci.yml >>> +++ b/.gitlab-ci.yml >>> @@ -441,6 +441,13 @@ build-without-default-devices: >>> IMAGE: debian-amd64 >>> CONFIGURE_ARGS: --without-default-devices --disable-user >>> >>> +build-without-default-features: >>> + <<: *native_build_job_definition >>> + variables: >>> + IMAGE: centos8 >>> + CONFIGURE_ARGS: --without-default-devices --without-default-features --disable-user >>> + MAKE_CHECK_ARGS: check-unit >> >> I wonder whether we'd rather want to check without >> "--without-default-devices" here to see whether all code compiles fine with >> "--without-default-features" ... ? > > Yeah at the moment the full-fat without everything doesn't achieve much. > So how about I swap the IMAGE around with the previous build and drop > the --without-default-devices? Sounds like a plan, thanks! Thomas
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 878d114d40..f87584ca8f 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -441,6 +441,13 @@ build-without-default-devices: IMAGE: debian-amd64 CONFIGURE_ARGS: --without-default-devices --disable-user +build-without-default-features: + <<: *native_build_job_definition + variables: + IMAGE: centos8 + CONFIGURE_ARGS: --without-default-devices --without-default-features --disable-user + MAKE_CHECK_ARGS: check-unit + check-patch: stage: build image: $CI_REGISTRY_IMAGE/qemu/centos8:latest
Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- .gitlab-ci.yml | 7 +++++++ 1 file changed, 7 insertions(+) -- 2.20.1