From patchwork Mon Dec 14 15:30:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 343559 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp3098921jai; Mon, 14 Dec 2020 07:36:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJzhkv3e8/mWJcpIM6moV59NBya1zC6jG3kbmXyRfx5Cmz20YafC3XVvDO6Dpv24v4jf5IEo X-Received: by 2002:a25:d452:: with SMTP id m79mr23089952ybf.417.1607960195345; Mon, 14 Dec 2020 07:36:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607960195; cv=none; d=google.com; s=arc-20160816; b=LmXl1LWQU5HcQkAFMnCXOIW3fAMrYkliO3KWTHcnvkay6i7vSy9CFVf1+P9qyNelzT FkILpSKo3Ms2wSSnGtmbZs6Q5SPQCXt/ZKwKxkmD3xOur0H0TzEBFY2I7HpwTumG5VwL Hupw0aEcl39FlyqcCHowUFZzzbXaJNCOGOd/2vsRxsyGFgX89sT9XnAykkez1n4E3WY1 mnBR+20mND8PFdWoNARtGyzS4iTf86qYhgIsc1k4GPEpFhehOeSYQWJC4MYpiSdxvAyA gedkF6M1+X2i5OnKNhQ9rTbLkC9jsFc2A7SKB3cOo4XFOHfubD29yKFaD+tloJ1lZJd/ lG0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=mswVJ8W6L1K/A6VuFf51dF/y+gVp/RoCPsfkvo9QLzE=; b=zRNWOh9W072zUi6Z3iRttO7QIg2PHE6GqFRyx6Brk8/Ac5XcqL3lIQGFrf6Irob1VC czH0tTgdgWU6z14RZcSbv802r7TJkejYtAAhNq7y1j8Nh7IsQqq994tlCSyoUoW37nGz 1uO6FRz0/CbYhhO8TT69tkKrfrmwZ2VOTfOb84UYzIJATAIqk2cGQ4dXsPhDJz9xU1h0 0pdXTXs6B75PX2Z3wna/PbtefBngiTsDPCjdXaB2HG1IwbvYNWFaumLcDem6AjAdn8an VMePSZWapAStltPk3sS06UWf2sr8tDN3+p9jAsk1MY+hmzKaCPRGDbcWC/XbbxNky0PU cV3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="QVkwCJ/j"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id f94si18899376ybi.385.2020.12.14.07.36.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Dec 2020 07:36:35 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="QVkwCJ/j"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:51096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koptq-0004xL-S6 for patch@linaro.org; Mon, 14 Dec 2020 10:36:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kopny-0007o2-Iu for qemu-devel@nongnu.org; Mon, 14 Dec 2020 10:30:30 -0500 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:52520) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kopnu-00068a-2I for qemu-devel@nongnu.org; Mon, 14 Dec 2020 10:30:30 -0500 Received: by mail-wm1-x343.google.com with SMTP id a6so14110861wmc.2 for ; Mon, 14 Dec 2020 07:30:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mswVJ8W6L1K/A6VuFf51dF/y+gVp/RoCPsfkvo9QLzE=; b=QVkwCJ/j3zPIV4YA1tBPzveprpEbQjG+cxzTzsAUbIdpiDQPZfCdu27TyzapPAHyK6 x8VglSx26Z+Qh1nF8zqljmNUOYv5gSGDgIbjQ56qOZIRCvS3oSHHFj/a5naNNeoDaw3T nXVj7Q2xp4wtpts9rqBOxK+zvS0GyCDq0nNewRodU+1k2fPx0K4Yk/L1RchsyzF8kBxD aqtJFG+UdvWUvJRU7wKpyICezroRgzPUN5ie56b+84xxOc4+R9tByTx7+EtZcO+sF+2c Rig2ZmvKtHji14K2+x25p5e0+bo0rkjtWC+kfiGm5/7AXWqqsusEMoLPtFZDLbAcKvmg gk1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mswVJ8W6L1K/A6VuFf51dF/y+gVp/RoCPsfkvo9QLzE=; b=MmPUBWrr+T+m+9/aFuJr/7aWl9Hv/Wh+D+GiPAIZ79yYz42J20Lq14OQGdD5sNbA79 O7lSNTGhWukevbgQHEiXBVtMsPcHVXHvflZjc2n9iwU9+fwKj/KAcnK53N1cMvGeDpa8 3JhN3lz8hakrqHHUoV02eKopvC/Es1AemL3qdQeme9qU3UeYbqi5qD5kn+wj8O6pxop6 XX+skAyF74WLNUtNGwlU0Hby6sQerDNC7hIaihcpB87fQAToBAaTRkTupfIwpoBnNovB rDMEgSiI9oJKVZ7KwcrWUJc7xeEAh1iB0/jIcBUCCrqMJYEefKA9Mp7YCAsDsoDjSUHX zIUw== X-Gm-Message-State: AOAM530sNQsMvyToiZj6+qM1X09nC/XQo6Aevn3M+ryzN88ok3u8NUTr sdrtQ0O7A0jF1BIwhaAKzYDXfg== X-Received: by 2002:a1c:a785:: with SMTP id q127mr23794528wme.25.1607959824657; Mon, 14 Dec 2020 07:30:24 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id a144sm31463691wmd.47.2020.12.14.07.30.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Dec 2020 07:30:18 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 494341FF92; Mon, 14 Dec 2020 15:30:13 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 6/6] gdbstub: ensure we clean-up when terminated Date: Mon, 14 Dec 2020 15:30:12 +0000 Message-Id: <20201214153012.12723-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201214153012.12723-1-alex.bennee@linaro.org> References: <20201214153012.12723-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::343; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x343.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" If you kill the inferior from GDB we end up leaving our socket lying around. Fix this by calling gdb_exit() first. Signed-off-by: Alex Bennée --- gdbstub.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.20.1 Reviewed-by: Richard Henderson diff --git a/gdbstub.c b/gdbstub.c index 7172f063a1..61fe2360e3 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1978,6 +1978,7 @@ static void handle_v_kill(GdbCmdContext *gdb_ctx, void *user_ctx) /* Kill the target */ put_packet("OK"); error_report("QEMU: Terminated via GDBstub"); + gdb_exit(0); exit(0); } @@ -2539,6 +2540,7 @@ static int gdb_handle_packet(const char *line_buf) case 'k': /* Kill the target */ error_report("QEMU: Terminated via GDBstub"); + gdb_exit(0); exit(0); case 'D': {