From patchwork Fri Jan 8 22:42:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 359069 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp942631jai; Fri, 8 Jan 2021 14:43:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJx9tFhbFlfZQYBWrIsNI4FLBfen17TLjGOwH2JgZztii2S8sNcTg93Jru1tIQYpizXtR2pH X-Received: by 2002:a25:25c7:: with SMTP id l190mr8682424ybl.177.1610145826666; Fri, 08 Jan 2021 14:43:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610145826; cv=none; d=google.com; s=arc-20160816; b=wtXQa05ybE8FBxnQsnlLbU6xFO4uCAU2+Da0D4Sxs1Me0riDQDeaaVJl7A6Ej2QrDc rei/yk0SQo+EVmozycrqdxSWumvaZnVQ0d5Vs9zNds6zXJ5Q1+1QWP8E9G+r0AU/k8Ef qPDSdMWNPLr+yMAR/jJNVba+OFtCzvCcTFgeapbFActjOe66l2HOJpylj5tNawL9K3oK cx6n1suEeicimNb9EDzJwQ19k2TvBJPiviBFiEf6VWbG7zTb5aVUYkkMtBKlux4lxTQe +J8vwEVNbOLY5Sf5cKedzaDBwG156eN2PRm/Uv1Bj9Nhh9ddnY+A3Ag7BtxeWJwjwEG4 bjpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=wV5YT0kkIRUM85lgbMG4TlRtNuUCjbVc4zflwSIgjEQ=; b=FJgdCDKf8EmiSzntNKdfvBTIHRqRm61lXNrBfjHnKWe8ngxDKOzlf72W9NSdvk+csT hRAXknEXJH78sjDYzuA00nQT2fkRvVFLP9o+D2mHffXTTfqOOC8EKB1cdFUuF8AgGoT/ ClizksUp+rJKB0PJqimq7XpNZK79u78kLkF4M+SZXeiZOdtSMA86eeHfG168vxMaEnUK eCSogA/sKBQx5wtmWIQKRX/6j7203/c19nMcKz5yv2nXpeOYQpMADIMpZAPgzLoa8Hdm cp8sChrI98/ChtO+7AF+i3VOHSgXdyV1uXuhRowt2ZJCY2hlFkPHZnTMTPYdfErBWuyM WmIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=SjEfd5RL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 23si12760077ybc.243.2021.01.08.14.43.46 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Jan 2021 14:43:46 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=SjEfd5RL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:54714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ky0Ty-0005vS-4t for patch@linaro.org; Fri, 08 Jan 2021 17:43:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ky0TS-0005pT-4b for qemu-devel@nongnu.org; Fri, 08 Jan 2021 17:43:14 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:35450) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ky0TQ-0003IA-DM for qemu-devel@nongnu.org; Fri, 08 Jan 2021 17:43:13 -0500 Received: by mail-wr1-x42f.google.com with SMTP id r3so10425800wrt.2 for ; Fri, 08 Jan 2021 14:43:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wV5YT0kkIRUM85lgbMG4TlRtNuUCjbVc4zflwSIgjEQ=; b=SjEfd5RLvdAiQFgoFigah/fmjYuSwBpWdERYc3frFRD73aYbJzpkMPWpR8yJy66YYG mJfl6b4ji6pfjsVFnxKRzLPznYzHmOko+3IuLRlaA4VW/EGCD+NPiGsdHbA6UTkrdWvD a/qImH7x02kdwHSpwbQISW+ujKcU/bzq7oMx3mDm0vCIRgXaVMPKDPa9wF2t7Rda0Xv/ JOXBzjRnW95BMnJF3cSGXQVaPsrx70q4Pav6IKRVN120zi6/vC8QdNOZlySUESLDhnD+ wTaaO2cfAgW4DFB/7Yr6dymq2aXvTPe+vJCBNurBtV1BfBE8Sbf+LgdMHni/xd/SBb8H IOCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wV5YT0kkIRUM85lgbMG4TlRtNuUCjbVc4zflwSIgjEQ=; b=JToRZMaTW31R+MNoFDoJPXJsbGQbepxXPhEcERpwKjfM8NsJrJj4Ea8CkU6dkO3FCW 9Bp/m89Osi3LfjXJ8qSM8RRtFK60DCdncKvJOVFMBW583WivuJbTaX9UEwUHt3Ol2nzB mY94xLsTeoOAvThgQjLDkTgIpbw5nK4/pOs1280Ss1a+fRxriW0fprH4EWL2TNVoondj voFJ6my5QclWbPjPzVWhfPDeiepq71biDL4lG5SPOomwJoJ6xQfAGu9Vs71FUTgrYWNQ i0J6hWROuGdi89ZTuRl+uBJ2KyQoTWgYyPBWZdZwBz/d6tgx088pS7X2iUhd5PNzZsVg yPxw== X-Gm-Message-State: AOAM532Hs/RUmxGhiHc1If05rB/sBXgArfpdZAL9RV1Xo4oEvjuQpGuo d9LuOhVeN71kWdDAw0oGGeE/OA== X-Received: by 2002:a5d:58fb:: with SMTP id f27mr5485360wrd.22.1610145791186; Fri, 08 Jan 2021 14:43:11 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id q1sm14849983wrj.8.2021.01.08.14.43.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 14:43:03 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id B9F6E1FF96; Fri, 8 Jan 2021 22:42:57 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 08/20] gdbstub: drop gdbserver_cleanup in favour of gdb_exit Date: Fri, 8 Jan 2021 22:42:44 +0000 Message-Id: <20210108224256.2321-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210108224256.2321-1-alex.bennee@linaro.org> References: <20210108224256.2321-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?utf-8?q?Alex_Benn?= =?utf-8?b?w6ll?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Despite it's name it didn't actually clean-up so let us document gdb_exit() better and use that. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201214153012.12723-6-alex.bennee@linaro.org> Message-Id: <20201218112707.28348-8-alex.bennee@linaro.org> Signed-off-by: Alex Bennée --- include/exec/gdbstub.h | 14 +++++++++++--- gdbstub.c | 7 ------- softmmu/runstate.c | 2 +- 3 files changed, 12 insertions(+), 11 deletions(-) -- 2.20.1 diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h index 492db0f512..ff0b7bc45e 100644 --- a/include/exec/gdbstub.h +++ b/include/exec/gdbstub.h @@ -46,7 +46,17 @@ void gdb_do_syscall(gdb_syscall_complete_cb cb, const char *fmt, ...); void gdb_do_syscallv(gdb_syscall_complete_cb cb, const char *fmt, va_list va); int use_gdb_syscalls(void); void gdb_set_stop_cpu(CPUState *cpu); -void gdb_exit(int); + +/** + * gdb_exit: exit gdb session, reporting inferior status + * @code: exit code reported + * + * This closes the session and sends a final packet to GDB reporting + * the exit status of the program. It also cleans up any connections + * detritus before returning. + */ +void gdb_exit(int code); + #ifdef CONFIG_USER_ONLY /** * gdb_handlesig: yield control to gdb @@ -187,8 +197,6 @@ static inline uint8_t * gdb_get_reg_ptr(GByteArray *buf, int len) */ int gdbserver_start(const char *port_or_device); -void gdbserver_cleanup(void); - /** * gdb_has_xml: * This is an ugly hack to cope with both new and old gdb. diff --git a/gdbstub.c b/gdbstub.c index afa553e8fc..bab8476357 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -3547,13 +3547,6 @@ int gdbserver_start(const char *device) return 0; } -void gdbserver_cleanup(void) -{ - if (gdbserver_state.init) { - put_packet("W00"); - } -} - static void register_types(void) { type_register_static(&char_gdb_type_info); diff --git a/softmmu/runstate.c b/softmmu/runstate.c index 636aab0add..6177693a30 100644 --- a/softmmu/runstate.c +++ b/softmmu/runstate.c @@ -775,7 +775,7 @@ void qemu_init_subsystems(void) void qemu_cleanup(void) { - gdbserver_cleanup(); + gdb_exit(0); /* * cleaning up the migration object cancels any existing migration