From patchwork Sat Jan 23 18:50:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 369448 Delivered-To: patch@linaro.org Received: by 2002:a02:a60d:0:0:0:0:0 with SMTP id c13csp2590411jam; Sat, 23 Jan 2021 10:50:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJydf4QQfZeI0Cj8GEqw7lxFPGS0tbbg3UYzmAk/OH2eB8omaPo596pPZpA9c+dvsa45pPYL X-Received: by 2002:a25:6dc5:: with SMTP id i188mr13933756ybc.396.1611427859247; Sat, 23 Jan 2021 10:50:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611427859; cv=none; d=google.com; s=arc-20160816; b=p/ZqnHQvBoavwPP3fxt5zHcbjrGAXTJz6iHijJAvuEIGsCyGUxV48HeCqOTUrraZbN fxec7+FLOndabyQRIXbtQGprQZ441/xnG3HKWDO27D9Q6G/0D1tx4YBm1nVzDP5hsRrp znKOR91iv+3wqnGsm4MTX6vjOnTgABE2F6LZsydg1a0GFgmd6xcc1izIFGid/uSolqhD 4nXALMdOZvzPpwXee3F+N57KjL7xZ8gpubq8IT17J5e8lTA0zyrfeYbAF2xnMH/hDPIw uZhlfuVTJjxvubf8Z5FYY2HLx06znqKnd4MGZoppBc9kDN6cwEQSg30h2BImoc8ntyx/ SH/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=AwbeW203h18CH5C6eZxAsKhYtBKVyHAGifKiBt07tZk=; b=fugq5pH9dbc+I8tlKBrADqgUzTv51M81tsFs/NEnnvAoLIBBm7X4NN0LzqmPXLtU0X LGkdChRQsOL1KHOkGcrXeTajr7GKPDPnYviWVh3vYbLlNY+Us/qk2IG4u+gwZqYZGMNn yBDNc0pjIC/1BHuHJ5rthANSAab/fZNV9FIO61cvyA4C5F2oB8hcDnLdDnanKfECJJOq uvPQxV6VDo7tFuVb/aRU/fneGcklidlxs5Go8Tf1SI27MEaRDsvAHzf+qC32/JDqFRqK z8U3wnKvBE+ukgg+gVJzFhnDkVP3dJPncH3yB4Pf/IZoyHaUepDIZgvbE7J0gmTGCnfi GUKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=j+Mfltym; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x63si12074732ybh.326.2021.01.23.10.50.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 23 Jan 2021 10:50:59 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=j+Mfltym; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:52582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3Nzu-0005Er-Nh for patch@linaro.org; Sat, 23 Jan 2021 13:50:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49784) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3NzW-0005Cv-Rx for qemu-devel@nongnu.org; Sat, 23 Jan 2021 13:50:34 -0500 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:53662) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l3NzS-0008Es-JN for qemu-devel@nongnu.org; Sat, 23 Jan 2021 13:50:34 -0500 Received: by mail-pj1-x102f.google.com with SMTP id p15so5850431pjv.3 for ; Sat, 23 Jan 2021 10:50:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AwbeW203h18CH5C6eZxAsKhYtBKVyHAGifKiBt07tZk=; b=j+MfltymXxIYJDGwPCOntg78SHZw+sPd48mplNPzEBRExGB6tj9y6Vk0kg5v8bjCyP ItsikzL7Wd9P9hyu1pt41eblF/lqybkYgvWGENMwMBSt9CAGYU9auHB0wesXFkbiyPSg Ag47PlP598g/SvcVrvmxQDbWzmS565WG9zC2BwS81NpItOKMbP8zmmq+CItpDZCBwL0x /JiAXb7dWD5qOj4RwNIVcKVsjfbveaWcc7+TiCpZO/oErf5/Ey2E4DkD9W2NE8tkBjfT yowWusLAl4LIFEMg55vEtcBDAZ0fhVIrtCPFzpfXyKzsyf9G8EbJbfTBr0rghvITHloF /URQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AwbeW203h18CH5C6eZxAsKhYtBKVyHAGifKiBt07tZk=; b=Nf3epzmrvMa7yrnTAEa0zDfjJRhR9JbcF5vF1QcxT3MvZ1q1VY35P9gsiQID8if4OT XZusxbJNgOhUtvFxg6SRGNov2S/fcwsjC0KSWfM/3OVhH5OhZq2ARu27gemZ7v/vPZfi 7vtrLWbPHP5uCzVMkTP5/UBVCr5roxBipYGoippZhFoeiCO2YKthplFltfYEsLx9zexJ fH9aabDV9cdhM1T3/QZibBkdEV/Ji9uNkiIcpbBLmV/ndwNCeekoDWQQrYldFNVR6+bl FkwG7RkXb/GoeOSHHxhEjWeTBsdgfMIBvrSK8LPE+jCSh0kBGwSomlM1VDBQJHBQ9pJB NJbA== X-Gm-Message-State: AOAM53013wSjbI73B7m7ULqFIZnUgcZnDvBJzDc0eZr6xyPBVRsJFRvl xqEv5uJ1tRRnp3LAofrLZjjIL4mwd77dHQ== X-Received: by 2002:a17:90a:f2cf:: with SMTP id gt15mr12328096pjb.166.1611427828754; Sat, 23 Jan 2021 10:50:28 -0800 (PST) Received: from localhost.localdomain (cpe-66-75-72-126.hawaii.res.rr.com. [66.75.72.126]) by smtp.gmail.com with ESMTPSA id j19sm5018614pfn.14.2021.01.23.10.50.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Jan 2021 10:50:28 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 03/10] tcg: Optimize inline dup_const for MO_64 Date: Sat, 23 Jan 2021 08:50:13 -1000 Message-Id: <20210123185020.1766324-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210123185020.1766324-1-richard.henderson@linaro.org> References: <20210123185020.1766324-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, David Hildenbrand Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Avoid the out-of-line function call for immediate MO_64. In addition, diagnose all invalid constants at compile-time. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/include/tcg/tcg.h b/include/tcg/tcg.h index 504c5e9bb0..c5a9d65d5f 100644 --- a/include/tcg/tcg.h +++ b/include/tcg/tcg.h @@ -1325,7 +1325,8 @@ uint64_t dup_const(unsigned vece, uint64_t c); ? ( (VECE) == MO_8 ? 0x0101010101010101ull * (uint8_t)(C) \ : (VECE) == MO_16 ? 0x0001000100010001ull * (uint16_t)(C) \ : (VECE) == MO_32 ? 0x0000000100000001ull * (uint32_t)(C) \ - : dup_const(VECE, C)) \ + : (VECE) == MO_64 ? (uint64_t)(C) \ + : (qemu_build_not_reached_always(), 0)) \ : dup_const(VECE, C))