From patchwork Thu Jan 28 08:23:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 372540 Delivered-To: patch@linaro.org Received: by 2002:a17:906:24d5:0:0:0:0 with SMTP id f21csp652892ejb; Thu, 28 Jan 2021 00:37:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJwdD7pDveIvf/e5ZsXp3n0EdyURlE2Xhu9h9Y2FA7hv7qbiFxw9blHekWDbJ1KUkTSHhwnX X-Received: by 2002:a25:4fd6:: with SMTP id d205mr8314104ybb.145.1611823032114; Thu, 28 Jan 2021 00:37:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611823032; cv=none; d=google.com; s=arc-20160816; b=paiqzcUb7HmGLyXtakVoqtlB4sf7Oy4dDUy3y4Zwrw8y0bcergHtGSRjX8h+rYOvco yZoAm+T61QHzYzdh8RmBp9uyWeOdJz2w7m9rzK6tfV2EGDE5m7yuuvRZk+T82MWYg1Dx MFAQJXHRS+o5X0lGXBaFo6IOGsxj3lw8HuqtHpwrG75/em+hndreJmT19dZhCaEHyWe8 lzTnDLbB2LNmoKI3QxQZhL1OpQPIa6FE0kdZHRs8MO9TyBw87b3kt7ZuSjUUWct57dEU gblaPYRBFQjRcu15ohsFJm2U2iqGlEmdYq2Bu3PUqxH2voGmk69KO0Rxjz+LBOIx8F2E MhHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=hRd34LGil31wVPd8eDU4MGOPOaZrbwDGq6Woxhcr11M=; b=Kf6rQZ1Tl3aZRVMkNA5WYNX6sudxWJ7U7MBV9r9EY3T+qweUWvrgjU7KqueOHQWuFi DQ+Wc77SCSgu4/N2WW+pA1Vp3UL41bkZhJp6bOe6UzIYlSIJHbAM250A3Df/Maqt0oVF ypzqezq9agRa//lc60zBbcHP8Mu18d9ANkalVFnIjZcU0MJ8sozUuLdb3aa5SM53q1h1 jqat8CgiEQGbQaRkhxO1P7coh1KaQTwBlQt0uIwJCiCW3WP5RJd2ZvxfevtM0XWbXqmB oOHLwvw7oDaCkE0CPDabXUrEQGs5vv3a6RXw0gO0f3991y1GlOKRLcYPkzqSbqsVVrNG PB2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W0WQfTed; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id z92si5193148ybh.63.2021.01.28.00.37.11 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Jan 2021 00:37:12 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W0WQfTed; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:34892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l52nf-000316-IB for patch@linaro.org; Thu, 28 Jan 2021 03:37:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54456) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l52as-0005zE-Tt for qemu-devel@nongnu.org; Thu, 28 Jan 2021 03:23:58 -0500 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]:44116) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l52ar-0005is-CF for qemu-devel@nongnu.org; Thu, 28 Jan 2021 03:23:58 -0500 Received: by mail-pg1-x530.google.com with SMTP id s23so2527598pgh.11 for ; Thu, 28 Jan 2021 00:23:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hRd34LGil31wVPd8eDU4MGOPOaZrbwDGq6Woxhcr11M=; b=W0WQfTedontnwR/hqHUVDWqXb3UJTt03lxP8AVnBAQOlqBfiZSRvsG5ImpETyrZeVC 7+E3NOsljg6Wg78OuiK0IMLVdIkXuF6egPYZePNcH/mLjtPMnB3KTn6shOvAsCLxjcvU FXjK/L+N79I5PVawSOfYYAEdEeAq5nYVNteBLvn99C6qU8xyZawhmym/OIuXKqKcHk5x dnQsCw8Qd7xNTETJEPENyQwOheHlYq1cfjvGsH4d2A7MMp7jGRM9vWw2gyLx91SFIRws u6V/Y1fxTYBqoE2por6HSetJf/WNj8SENMlJ1huWKbZ4eoo917HB+89M7u35zx+nrnmy dtwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hRd34LGil31wVPd8eDU4MGOPOaZrbwDGq6Woxhcr11M=; b=rHTz24wEd15kuIclZ3tXvoXib7KZkeuvg2an1m7achHEjULRZKKmZUiD/yL0kqmsuG I0Tgi4Aua5Q72k/SvBTPy+ZJpnketpJXwMuuMml9SdbV3hk5qqGPTGyodlN4qz3PtGFO M5ljxxTIB6jfEEBA8ShhpqG6nXLRgyhNlDo1GAsqozP5emDPmimhA0JdOinPvCQV6wzA CJGwAd08kptU6/bxEH+ddOOTVXdo24Hjy0QTjc2NoAMXP8zwyqV8i3mBPTTy1hvv2cuN eYGjZTTeprZnwRJUd5RcmFLZlfbMjw983Wq6Vm+Ut9qz3jHhjIbb2iNsQEtIEItqXsBO d+zA== X-Gm-Message-State: AOAM530nK/Rl9m67o0U/vA63CpCJBF8pOelgZZ0atWxbwc43T0Dbp+kd z9kgO8KHArIVg6Mhm5pshZGbsxwaj3W7lRAj X-Received: by 2002:aa7:8ed2:0:b029:1b9:7c87:8f44 with SMTP id b18-20020aa78ed20000b02901b97c878f44mr14942375pfr.49.1611822236134; Thu, 28 Jan 2021 00:23:56 -0800 (PST) Received: from localhost.localdomain (cpe-66-27-222-29.hawaii.res.rr.com. [66.27.222.29]) by smtp.gmail.com with ESMTPSA id s24sm4658292pfd.118.2021.01.28.00.23.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 00:23:55 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 13/23] tcg/tci: Merge INDEX_op_ld16u_{i32,i64} Date: Wed, 27 Jan 2021 22:23:21 -1000 Message-Id: <20210128082331.196801-14-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210128082331.196801-1-richard.henderson@linaro.org> References: <20210128082331.196801-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::530; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sw@weilnetz.de Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Eliminating a TODO for ld16u_i32. Signed-off-by: Richard Henderson --- tcg/tci.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) -- 2.25.1 Reviewed-by: Alex Bennée diff --git a/tcg/tci.c b/tcg/tci.c index 7d11982eb2..d197803dca 100644 --- a/tcg/tci.c +++ b/tcg/tci.c @@ -585,7 +585,11 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState *env, tci_write_reg(regs, t0, *(int8_t *)(t1 + t2)); break; case INDEX_op_ld16u_i32: - TODO(); + case INDEX_op_ld16u_i64: + t0 = *tb_ptr++; + t1 = tci_read_r(regs, &tb_ptr); + t2 = tci_read_s32(&tb_ptr); + tci_write_reg(regs, t0, *(uint16_t *)(t1 + t2)); break; case INDEX_op_ld16s_i32: t0 = *tb_ptr++; @@ -849,12 +853,6 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState *env, /* Load/store operations (64 bit). */ - case INDEX_op_ld16u_i64: - t0 = *tb_ptr++; - t1 = tci_read_r(regs, &tb_ptr); - t2 = tci_read_s32(&tb_ptr); - tci_write_reg(regs, t0, *(uint16_t *)(t1 + t2)); - break; case INDEX_op_ld16s_i64: TODO(); break;