diff mbox series

[07/72] softfloat: Inline float_raise

Message ID 20210508014802.892561-8-richard.henderson@linaro.org
State Superseded
Headers show
Series Convert floatx80 and float128 to FloatParts | expand

Commit Message

Richard Henderson May 8, 2021, 1:46 a.m. UTC
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 include/fpu/softfloat.h        |  5 ++++-
 fpu/softfloat-specialize.c.inc | 12 ------------
 2 files changed, 4 insertions(+), 13 deletions(-)

-- 
2.25.1

Comments

Philippe Mathieu-Daudé May 9, 2021, 8:32 a.m. UTC | #1
On 5/8/21 3:46 AM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> ---

>  include/fpu/softfloat.h        |  5 ++++-

>  fpu/softfloat-specialize.c.inc | 12 ------------

>  2 files changed, 4 insertions(+), 13 deletions(-)


Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
David Hildenbrand May 11, 2021, 10:04 a.m. UTC | #2
On 08.05.21 03:46, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> ---

>   include/fpu/softfloat.h        |  5 ++++-

>   fpu/softfloat-specialize.c.inc | 12 ------------

>   2 files changed, 4 insertions(+), 13 deletions(-)

> 

> diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h

> index 78ad5ca738..019c2ec66d 100644

> --- a/include/fpu/softfloat.h

> +++ b/include/fpu/softfloat.h

> @@ -100,7 +100,10 @@ typedef enum {

>   | Routine to raise any or all of the software IEC/IEEE floating-point

>   | exception flags.

>   *----------------------------------------------------------------------------*/

> -void float_raise(uint8_t flags, float_status *status);

> +static inline void float_raise(uint8_t flags, float_status *status)

> +{

> +    status->float_exception_flags |= flags;

> +}

>   

>   /*----------------------------------------------------------------------------

>   | If `a' is denormal and we are in flush-to-zero mode then set the

> diff --git a/fpu/softfloat-specialize.c.inc b/fpu/softfloat-specialize.c.inc

> index 9ea318f3e2..487b29155c 100644

> --- a/fpu/softfloat-specialize.c.inc

> +++ b/fpu/softfloat-specialize.c.inc

> @@ -228,18 +228,6 @@ floatx80 floatx80_default_nan(float_status *status)

>   const floatx80 floatx80_infinity

>       = make_floatx80_init(floatx80_infinity_high, floatx80_infinity_low);

>   

> -/*----------------------------------------------------------------------------

> -| Raises the exceptions specified by `flags'.  Floating-point traps can be

> -| defined here if desired.  It is currently not possible for such a trap

> -| to substitute a result value.  If traps are not implemented, this routine

> -| should be simply `float_exception_flags |= flags;'.

> -*----------------------------------------------------------------------------*/

> -

> -void float_raise(uint8_t flags, float_status *status)

> -{

> -    status->float_exception_flags |= flags;

> -}

> -

>   /*----------------------------------------------------------------------------

>   | Internal canonical NaN format.

>   *----------------------------------------------------------------------------*/

> 


Reviewed-by: David Hildenbrand <david@redhat.com>


-- 
Thanks,

David / dhildenb
diff mbox series

Patch

diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h
index 78ad5ca738..019c2ec66d 100644
--- a/include/fpu/softfloat.h
+++ b/include/fpu/softfloat.h
@@ -100,7 +100,10 @@  typedef enum {
 | Routine to raise any or all of the software IEC/IEEE floating-point
 | exception flags.
 *----------------------------------------------------------------------------*/
-void float_raise(uint8_t flags, float_status *status);
+static inline void float_raise(uint8_t flags, float_status *status)
+{
+    status->float_exception_flags |= flags;
+}
 
 /*----------------------------------------------------------------------------
 | If `a' is denormal and we are in flush-to-zero mode then set the
diff --git a/fpu/softfloat-specialize.c.inc b/fpu/softfloat-specialize.c.inc
index 9ea318f3e2..487b29155c 100644
--- a/fpu/softfloat-specialize.c.inc
+++ b/fpu/softfloat-specialize.c.inc
@@ -228,18 +228,6 @@  floatx80 floatx80_default_nan(float_status *status)
 const floatx80 floatx80_infinity
     = make_floatx80_init(floatx80_infinity_high, floatx80_infinity_low);
 
-/*----------------------------------------------------------------------------
-| Raises the exceptions specified by `flags'.  Floating-point traps can be
-| defined here if desired.  It is currently not possible for such a trap
-| to substitute a result value.  If traps are not implemented, this routine
-| should be simply `float_exception_flags |= flags;'.
-*----------------------------------------------------------------------------*/
-
-void float_raise(uint8_t flags, float_status *status)
-{
-    status->float_exception_flags |= flags;
-}
-
 /*----------------------------------------------------------------------------
 | Internal canonical NaN format.
 *----------------------------------------------------------------------------*/