From patchwork Tue May 18 05:31:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 441133 Delivered-To: patch@linaro.org Received: by 2002:a02:7a1b:0:0:0:0:0 with SMTP id a27csp1786693jac; Mon, 17 May 2021 22:55:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrhYkDDCYXveC7rCSWDFVdG8hH5m7g2sTdG+CoHP6iJ+5y8WgwHvr4pyL114aGKGYBEJT/ X-Received: by 2002:ad4:56a8:: with SMTP id bd8mr4242937qvb.9.1621317308251; Mon, 17 May 2021 22:55:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621317308; cv=none; d=google.com; s=arc-20160816; b=oKxP20eBBydpu8QF4f3K6vLOONHee2vL9euqJR2eJZCaFXjKMCQq1o2aIxvwE1cyIf 6K/XD7eaE7IsBzROw2cLmxk3316XmCKSVpsO+NT8GDb1Bz8zrPAJpzdCoLrkgPUMwNrl jIinMPagEYbnKGYR8Yv5y/jxcfyBKt4JLe+ahI6FXQ8gQxQo6tilQ0YAuC54ECJHgZX+ TnS5H3qHD48ep7iJA6n1LXkCPiKaW5NOhioTwXk0X5sdGGQw7ey5fPCFTy92+DhlXmIc WiVzZJJoFN2jsPNHA9oBQNAcylRI3Sc+885s8F2OcICVwNr+OVS8z2NbcewfZJFbKehY Tr2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from; bh=GGt3s9PH54kVNpLEGyCmqOOnWNqSPdUuVvGJzLZhWRc=; b=EWEXUF4PwvM+u3n2v597UON4HWuvRWCUxCoEpWq4CEDJnQb2AVv2O2fWcDvhZ2ek9I RS4+nUBVnI/FeGgF9Yf22qM75EAhp2AajoNMCf6DdXXf5L/kI7e6m5XZD7K3Cnly2GX/ TRBlWY9Exx11JyyUdahEvWJ76PlXGn/KvkQnkqpSuZ5F7iXgbPBYUkIGXKfm4lizBMbj GbSDkcM09G8OvoFd28+d2Ugq+LPMhSrI5cQ4XOH4LYqcO6Yl/crDE24Ij5BN+yrRdZrs 1folNhHA8bOo2FLKDmcDume40XKqWZCk4jMjNT2kZavGzb3SJnY12cA/kBhCYerMVjTs mtew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k1si11952095qvp.193.2021.05.17.22.55.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 May 2021 22:55:08 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:45580 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lish9-00070J-Mr for patch@linaro.org; Tue, 18 May 2021 01:55:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lisKt-0007te-41 for qemu-devel@nongnu.org; Tue, 18 May 2021 01:32:07 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:46027) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lisKn-0007A5-2K for qemu-devel@nongnu.org; Tue, 18 May 2021 01:32:06 -0400 Received: from quad ([82.142.31.78]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M8k65-1lmywC3MeX-004hR9; Tue, 18 May 2021 07:31:54 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 40/59] linux-user/s390x: Tidy save_sigregs Date: Tue, 18 May 2021 07:31:12 +0200 Message-Id: <20210518053131.87212-41-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210518053131.87212-1-laurent@vivier.eu> References: <20210518053131.87212-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:mtO72gX66+0XimLplwT1W5/HE7jjUbsxrl2E8lKI+YqVTh9Iw2L 0zeaLDkqt/YPI3tGPveWtpr3gLQWVv++u5B83ONdmvqmcma7tRIjGdu5NCnMulppFhIvyqC HDiiLkKFfksJeVCim+EI3AkKuznIsGgv5kwfrfHtZIA2PLywquZqZyGXmtr1qW+Mhke/MTw tAza5L72ZVruRFFXBgfCw== X-UI-Out-Filterresults: notjunk:1; V03:K0:tLfhggQq0AA=:2DNGyYFhsgwjzU4J+4LPDN ICT3ugzzQGxMXk9ClDLH664trttQo42kUzlhjuVuRqkBqvxcJRJbnvVVKFJiKRH0ENw5cr4Sa AZBWzYe5WRH93Iqz+HKS70orC3h7VMdc8ZQgdFopm60AkxQIzcavfzMg7cMoF9f5euz9Y2m9p CseafcVscyOZD/hwb6c0Zo7i3TNBWeX8vwRfOn91qBTNoPnAVuzKur1llbP+FJcGgfZJbMYT+ 5FFOZ+utMJA5zuOz8Ku2ILkiUZuW/R1MeQ4WWjcCX56CxqnT4d21CpTcijfF5J7uziymPmbm3 HH+NnrekXOww4NEq63q1ciKJsqLcCkKdj22V7mHikECwWUgBfAep0S0tGOoCvKcN1XBKyNxsR gwkFSGWvyojz3UzWjOuNP3Ko5bWsnCl2NMVnVmvb21ZJbivQbmZgbgfjXbYxNmrddoYj0e8nD l+AzSQtzyxKyWLpXRILUsQustsUTi5fBU7SBZyr0sm96aXdvq5WmjmVAuzAeNpgpMpw6pODTw mA39RDIq8uCkyPfwv7k8Ac= Received-SPF: none client-ip=212.227.126.133; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , Laurent Vivier , David Hildenbrand Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson The "save" routines copied from the kernel, which are currently commented out, are unnecessary in qemu. We can copy from env where the kernel needs special instructions. Fix comment style. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20210428193408.233706-9-richard.henderson@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/s390x/signal.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) -- 2.31.1 diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index 4dde55d4d518..eabfe4293f9f 100644 --- a/linux-user/s390x/signal.c +++ b/linux-user/s390x/signal.c @@ -104,23 +104,25 @@ get_sigframe(struct target_sigaction *ka, CPUS390XState *env, size_t frame_size) static void save_sigregs(CPUS390XState *env, target_sigregs *sregs) { int i; - //save_access_regs(current->thread.acrs); FIXME - /* Copy a 'clean' PSW mask to the user to avoid leaking - information about whether PER is currently on. */ + /* + * Copy a 'clean' PSW mask to the user to avoid leaking + * information about whether PER is currently on. + */ __put_user(env->psw.mask, &sregs->regs.psw.mask); __put_user(env->psw.addr, &sregs->regs.psw.addr); + for (i = 0; i < 16; i++) { __put_user(env->regs[i], &sregs->regs.gprs[i]); } for (i = 0; i < 16; i++) { __put_user(env->aregs[i], &sregs->regs.acrs[i]); } + /* * We have to store the fp registers to current->thread.fp_regs * to merge them with the emulated registers. */ - //save_fp_regs(¤t->thread.fp_regs); FIXME for (i = 0; i < 16; i++) { __put_user(*get_freg(env, i), &sregs->fpregs.fprs[i]); }