From patchwork Fri Jun 25 11:27:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 466838 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp1361479jao; Fri, 25 Jun 2021 04:28:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXuxMsQo9pkKmHiXNtOO7u/xfpYvfF4tTdSgH8DSoWlZmlQoN76AJxBLmjDh9isoa/gYz2 X-Received: by 2002:ad4:5042:: with SMTP id m2mr10443183qvq.29.1624620502410; Fri, 25 Jun 2021 04:28:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624620502; cv=none; d=google.com; s=arc-20160816; b=IEFuNoLn97CNENFjdCmRc9/gXFsJ2KBeCRZug+9fuWUHPx8i949rY6yxbwGXkahyAd xo2+jtvIkOma993Nt+9vlLU6Oest4/+ZcDQhiWzS8xNyAGUvIB2k6AMGEruwH2Yq3VLd DFCmjMcL+0TwUimD/cspcOmcKbuw69stBUeLSVD1eQHRO4LfTTDv2NeChtthnGfFXY9s 5G9idpdX31Kp0VrIY03Dn9fgeYREQrqbl0EEXnTsHTB3gPVBelsEvRA1a35y10UNFDKc EbOiR14IjBoZT0uOQMFTBaa7tyE0bopPh/QMWKwyDynYV0fHVnwoG3BxmHDy8gVJYEoj 8XaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature; bh=/wc5U/Rd4PWWgnOQl8CE5xd7amsgWGTP8QNI5fFbgvw=; b=E+TBAAQLpTQIuSdgqa2Mvxrvom3tEzHJSE/h3wl1NVjzp3yx3aZ0rckqmEJkGQwPE0 Ng25SSxV2GWURsgIkbw6PwE/YyLQmqYx++wtDSV1/1sfddTlEmfNOMDR3fInwpNAWhr8 JBVUpCBUwYg9CT1qxZwuPfTPkSNZJd+93H4JPHMGIL4zKNX5bO/m1ddHSEt2CRUlWTJa tn3hn6z4nBFEf1nuYdcJfl8rt1YrZLSWN2t8lds+AuoYkRPColpHXDlN1LiCa4APpDWJ VpslbSpEt1b/IcteCoqqqR+OE0xbjdfBSTJRzPk26NLbXUSMMCeUkxBSwnpWC2R6drLo qkBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=z6n9QES2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id m2si4343023qtq.173.2021.06.25.04.28.22 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Jun 2021 04:28:22 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=z6n9QES2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:38604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwk0T-0006kB-Tx for patch@linaro.org; Fri, 25 Jun 2021 07:28:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwk0I-0006hl-By for qemu-devel@nongnu.org; Fri, 25 Jun 2021 07:28:10 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:42792) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lwk02-0000tU-JC for qemu-devel@nongnu.org; Fri, 25 Jun 2021 07:28:09 -0400 Received: by mail-wr1-x432.google.com with SMTP id j1so10184895wrn.9 for ; Fri, 25 Jun 2021 04:27:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/wc5U/Rd4PWWgnOQl8CE5xd7amsgWGTP8QNI5fFbgvw=; b=z6n9QES2rDHjJ4BWNg5LIeMdhFRiPCqw+eWKGdXJFHNgJtpaqVXiHs8egYvWOBtwMf w8SSmapEZ8jzzBEW41HNWXUuaehnAZrlLzsmRQOs5KQqsir5quZRd5MfYx6RJNeQQdJF 88H2aCp+zLXokb2R4N5i2vK8TNTLV0+d+LtdaFtqLcra7QuUby1m5yUEo+N4/gSCIUTR 4xUERMZjzNYQ5ZqnxJJPBKA0T2xt586FkPRFSqP2z6vWrniuznJKrosKfOYob19RH5HM arIZHFjlWIyAEBFh27P3DM4ewt4vuczNabyBc3KIbIywRBTQRiRHvx/GkIs6ymfpFUbK TuAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/wc5U/Rd4PWWgnOQl8CE5xd7amsgWGTP8QNI5fFbgvw=; b=Ej5XDLNwEWfAOgkvK1j6IWIyhH0CBBVMpgnethliVbJwwZ7OT8V9B5MV+1SjdPG57N SvsT/z4oJTuzzSfUDAODuatNKEp7efrl4/0qm4dBfMkUqP0vbwjxJo9/FQf4PjdpEtaZ CbaKIMI73reYvkPJMEGz7iA2e+SvQWo+1H6COUvMqq4Wp2wcwZcA1+gFatWbUuG3k/pb 5HQOl+1BRl/aLtXKg8Yp70TD7yCdAtTDU09AeXHsGBDr/nb338EbvfSx9/+52DoatYlX g3FoP/S0R/cVgm5lmqYsm7sroJVfJ8n47LyO8W4USEf+kzDDcCRgPjDsPeRd2d2QzVsw dVvA== X-Gm-Message-State: AOAM533+F/2J6AfZkLCZ8lLVoTci35wmsoaX54HcUnhd3XDYpgVbewxh RQca3K0mfljWaUji3R4r8at2Xw== X-Received: by 2002:a5d:6d83:: with SMTP id l3mr3049044wrs.91.1624620472698; Fri, 25 Jun 2021 04:27:52 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id r12sm6124596wrn.2.2021.06.25.04.27.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jun 2021 04:27:51 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 109CE1FF7E; Fri, 25 Jun 2021 12:27:51 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [RFC PATCH] tcg/plugins: enable by default for TCG builds Date: Fri, 25 Jun 2021 12:27:41 +0100 Message-Id: <20210625112741.12566-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , minyihh@uci.edu, robhenry@microsoft.com, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Willian Rampazzo , mahmoudabdalghany@outlook.com, aaron@os.amperecomputing.com, cota@braap.org, Wainer dos Santos Moschetta , Paolo Bonzini , kuhn.chenqun@huawei.com, ma.mandourr@gmail.com, =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Aside from a minor bloat to file size the ability to have TCG plugins has no real impact on performance unless a plugin is actively loaded. Even then the libempty.so plugin shows only a minor degradation in performance caused by the extra book keeping the TCG has to do to keep track of instructions. As it's a useful feature lets just enable it by default and reduce our testing matrix a little. Cc: Paolo Bonzini Signed-off-by: Alex Bennée --- docs/devel/tcg-plugins.rst | 3 ++- configure | 2 +- .gitlab-ci.d/buildtest.yml | 23 ----------------------- 3 files changed, 3 insertions(+), 25 deletions(-) -- 2.20.1 Reviewed-by: WIllian Rampazzo Reviewed-by: Thomas Huth diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst index 18c6581d85..0cd77c77d2 100644 --- a/docs/devel/tcg-plugins.rst +++ b/docs/devel/tcg-plugins.rst @@ -71,7 +71,8 @@ API Usage ===== -The QEMU binary needs to be compiled for plugin support:: +Any QEMU binary with TCG support has plugins enabled by default. +Earlier releases needed to be explicitly enabled with:: configure --enable-plugins diff --git a/configure b/configure index 38704b4e11..9f7161e26c 100755 --- a/configure +++ b/configure @@ -432,7 +432,7 @@ libxml2="$default_feature" debug_mutex="no" libpmem="$default_feature" default_devices="true" -plugins="no" +plugins="$default_feature" fuzzing="no" rng_none="no" secret_keyring="$default_feature" diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index d9b834c848..89df51517c 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -354,29 +354,6 @@ build-some-softmmu: TARGETS: xtensa-softmmu arm-softmmu aarch64-softmmu alpha-softmmu MAKE_CHECK_ARGS: check-tcg -# Run check-tcg against linux-user (with plugins) -# we skip sparc64-linux-user until it has been fixed somewhat -# we skip cris-linux-user as it doesn't use the common run loop -build-user-plugins: - extends: .native_build_job_template - needs: - job: amd64-debian-user-cross-container - variables: - IMAGE: debian-all-test-cross - CONFIGURE_ARGS: --disable-tools --disable-system --enable-plugins --enable-debug-tcg --target-list-exclude=sparc64-linux-user,cris-linux-user - MAKE_CHECK_ARGS: check-tcg - timeout: 1h 30m - -build-some-softmmu-plugins: - extends: .native_build_job_template - needs: - job: amd64-debian-user-cross-container - variables: - IMAGE: debian-all-test-cross - CONFIGURE_ARGS: --disable-tools --disable-user --enable-plugins --enable-debug-tcg - TARGETS: xtensa-softmmu arm-softmmu aarch64-softmmu alpha-softmmu - MAKE_CHECK_ARGS: check-tcg - clang-system: extends: .native_build_job_template needs: