From patchwork Thu Jul 8 19:09:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 471316 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp591380jao; Thu, 8 Jul 2021 12:37:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyyAFgYBeGHDdEa0+4vypETZNPc5RgxwlNiV65s/GtF231h0dBHMQrO+1y9/walXRaUhnbF X-Received: by 2002:ab0:482c:: with SMTP id b41mr21748527uad.97.1625773035452; Thu, 08 Jul 2021 12:37:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625773035; cv=none; d=google.com; s=arc-20160816; b=bKtJTITl44XVOAhsThiMnSYS9TlnIS2JPTEwUnM48tVE5kmCvYCSh+B8IUiNMz2f0U NhgKIDa11c9oF1iGyG39V21gyyHyDGV976wsdtCOhI6JT+DyavMsFht/r5DC8fL4OCd0 OVZqX7TRIXDrNA56R2WFA/3IyxMPjZAXwP75WKm9xopGRo0LczciZmxc1WLNqAWxTM1x oQqm8dr7ewbhIlyCUymV/D67TM/vWb/Dt30nfNvPa+a9XokfKRl86sSvX8MUJ/giGoCd whpUa2N5KB1jF7uyuJDVPsvLKnBcZR71tu+vOmLYGcxdklg0r27m3EeRoB/LY7nSEdN5 xSRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=1tFxEjWS8ph3QIQaLzB5s7JcBmanfU2D2gi2t0MWK88=; b=ZPliGwcQhj4q6fknVdtAqB4PvW6jBGTtRLJ1tG+M1Tk1bF571dP3A00vXFVPC04UA5 CYdmBy9FAeCEBu0g9nPY9XIe3ZncAOjDlcfsJ75wlds8StcUOrmjjK7iHbPNf5JSgGCq gdZxG1XEJdtpA+YZ731NU4MV0KZWy0PpK+iNen8KxujeVH7fgF7xUDzveU7Qy8/eXQ/h C1ZUt/lbiAJQQXsIXesqio/ogFyPNY1MOmj8+I5ljlDLqQPO1RsnYASQjbOUz8oqsFnZ DxPd6XFVtY4jr5v+7woelPaabMNanDNfZkERlnTDzyeoohG8EX/XPMw+msfAEe9IanFP u9QQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ADKU35rs; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id e18si3553506uaf.139.2021.07.08.12.37.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Jul 2021 12:37:15 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ADKU35rs; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1Zpi-0007Ux-QD for patch@linaro.org; Thu, 08 Jul 2021 15:37:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51624) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1ZWR-0002Dq-Bk for qemu-devel@nongnu.org; Thu, 08 Jul 2021 15:17:19 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:42936) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1ZWP-0007UA-38 for qemu-devel@nongnu.org; Thu, 08 Jul 2021 15:17:19 -0400 Received: by mail-wm1-x333.google.com with SMTP id j16-20020a05600c1c10b0290204b096b0caso4723078wms.1 for ; Thu, 08 Jul 2021 12:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1tFxEjWS8ph3QIQaLzB5s7JcBmanfU2D2gi2t0MWK88=; b=ADKU35rsfvrjNghrFP9PT6FD3RydEny2MgPTdG/I5tPhCw5xkJq4iKUpFC9Vbvl+RU 5W6kAtBSi1i6sjS4/jugdFEUzq5FXx6YEadKsZKryW/HXb3G2i1OXUYTyXLScmB3g9nM /O5mG3boY4p4H6yl10SrJdadE6ugQZUwRLaLyOA4RcPrxaP4mrv4kB48zU3OnlPwHJTD rmbqjDUUyoAkkUMONvli6QerVMHLJ0XdRKSufbyns4VjB6xgVQFNY23/ZYInlkADnVj3 520X5BfchpM0oUZKPt5Ld5ESS8Aq2Na/TYAVoHvqnxd/C0AyfVs+q+SDDkk4jAsa3QRu J+PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1tFxEjWS8ph3QIQaLzB5s7JcBmanfU2D2gi2t0MWK88=; b=j3aTPNtZrG7NOm1tW9kMhfRbsQKNMFhL1VWntbfu4vnPpb1DyGHAsBpk5BJ4eb3W8x OaODT6YBpv+BM415HVVEfyXBbYZiJnvcE/rI8YIo1eQ1TNKt/byLtdO/dX15+FwlTXXy XVbjCViclm4w5OHRxIeqHDckIN1bkDST4N+w8arn0Mm+fhjs6B4JWrtAxjPQe1VayZfP 1xZhAeusKoSYGm2V0FgoH+aj1EHitUXVCZSNLpDqMPVJ1fLBpXbLbZAwgw2+rdhPjp1c +DLr8BoWFq4tJuV9LykRRBPQYuioT9Fkkp9TUwImyZAQpL1GarlJn607fhZu6hupe0rQ wnQw== X-Gm-Message-State: AOAM530sduHWG31BMXy3Wft+3C0gYh4UVvxsf1p/KJqiyQgGFzLOE/5U JOo/kIanUE/W2vTlr4UsDJ7TyA== X-Received: by 2002:a7b:ca45:: with SMTP id m5mr4512671wml.46.1625771835319; Thu, 08 Jul 2021 12:17:15 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id p15sm2641544wmq.43.2021.07.08.12.17.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jul 2021 12:17:11 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 36FC91FFB5; Thu, 8 Jul 2021 20:09:45 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v2 30/39] configure: stop user enabling plugins on Windows for now Date: Thu, 8 Jul 2021 20:09:32 +0100 Message-Id: <20210708190941.16980-31-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210708190941.16980-1-alex.bennee@linaro.org> References: <20210708190941.16980-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, minyihh@uci.edu, berrange@redhat.com, kuhn.chenqun@huawei.com, f4bug@amsat.org, robhenry@microsoft.com, mahmoudabdalghany@outlook.com, aaron@os.amperecomputing.com, cota@braap.org, stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, ma.mandourr@gmail.com, =?utf-8?q?Alex_Benn=C3=A9e?= , aurelien@aurel32.net, Yonggang Luo Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" There are some patches on the list that enable plugins on Windows but they still need some changes to be ready: https://patchew.org/QEMU/20201013002806.1447-1-luoyonggang@gmail.com/ In the meantime lets stop the user from being able to configure the support so they don't get confused by the weird linker error messages later. Signed-off-by: Alex Bennée Cc: Yonggang Luo --- v2 - move targetos check to if we try to --enable-plugins, default no otherwise --- configure | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) -- 2.20.1 Reviewed-by: Richard Henderson diff --git a/configure b/configure index 7f906be68d..43f4d3220a 100755 --- a/configure +++ b/configure @@ -708,6 +708,7 @@ MINGW32*) audio_drv_list="" fi supported_os="yes" + plugins="no" pie="no" ;; GNU/kFreeBSD) @@ -1510,7 +1511,11 @@ for opt do ;; --disable-xkbcommon) xkbcommon="disabled" ;; - --enable-plugins) plugins="yes" + --enable-plugins) if "$targetos" = "MINGW32"; then + error_exit "TCG plugins not currently supported on Windows platforms" + else + plugins="yes" + fi ;; --disable-plugins) plugins="no" ;;