From patchwork Tue Jul 20 23:26:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 481618 Delivered-To: patch@linaro.org Received: by 2002:a17:907:d92:0:0:0:0 with SMTP id go18csp6016635ejc; Tue, 20 Jul 2021 16:48:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzwC1anvMm2A++SmWc3dJuGCriVxQyjGOCLJWGu606dgaXILRCIn7YOMkeJ3vwxZG/0X+Y X-Received: by 2002:a25:afcd:: with SMTP id d13mr40330085ybj.504.1626824919787; Tue, 20 Jul 2021 16:48:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626824919; cv=none; d=google.com; s=arc-20160816; b=IToOVxTDRGdy1jMqzeEITeLjVLDiffBl5o4kLrrOfMkZfHymwbKwD8TYR77Pje1J1z Sfle34KjhW9doK392iv3kU9KT7moFu5LCRKs2mPa4jFB7P6ozihz7jeHhtLghUzW+yfu 41djdG11/vgKpUced74zrdBVJ1bW3Wqgehcn1GyZ6edsB6Dx5+WQr1GM3j70oUnalCFm RusjOhjYx1dRrzLcyUdjr4wDbg8gfnB7ncDMdUWVwdqJq8zx7KaZE5PUQeO6tXz1giZi g/kgxztcPX4tqcn53uXBow2733DhtGMcf/T5PyUCDOCrhztM2ni/vvq97xjhU5avvsN7 GIiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=wGyzsMcwyPdU32aTj0BzS3yJV+u0+Pq22bBiQhu0jRI=; b=EtlTGuH6SEMb3q1kRYc6MFowuKTc55twI2g7Fe+N9bdHNTiCZN+K5dJcunzZRBsDtH cwriluBeElu8X81+fPLItgyhED8ZNV2LICVvl0ZSglBawFOXxTjnaPocM+iaAWVhGkYD dp1w8IRadTCeIP9f3EjzqQCC/cSYn9sM+BGvioAMbBOjYrnWFvXPW9WmdU3xczCp4biy WWGQY9Wwc9Evk4lAHJEAWCmdAUW36ejRtM4b89AaJ9/9/MythtwZC68u7HfLdQQXjnM5 fh7hNyoXGBGEqJd7NaAr8e3UkF3aXAH+tGc+WDOLiKNAFcsMFABVlB2KmBUHrgSGPgTb DeCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=dFuRuljk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x124si21835862ybc.463.2021.07.20.16.48.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Jul 2021 16:48:39 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=dFuRuljk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:56096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5zTb-0002WF-5E for patch@linaro.org; Tue, 20 Jul 2021 19:48:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5zFx-0004HQ-Vu for qemu-devel@nongnu.org; Tue, 20 Jul 2021 19:34:34 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:38820) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m5zFw-0001hv-Cs for qemu-devel@nongnu.org; Tue, 20 Jul 2021 19:34:33 -0400 Received: by mail-wm1-x332.google.com with SMTP id b14-20020a1c1b0e0000b02901fc3a62af78so2405777wmb.3 for ; Tue, 20 Jul 2021 16:34:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wGyzsMcwyPdU32aTj0BzS3yJV+u0+Pq22bBiQhu0jRI=; b=dFuRuljkEPQpaWZK9pz+WuGQfxnI+kDOy5VwWvOc5bP+03MBXqVr7ryjWqLmX1xdmu P7gM6sFHlMNi8Oy2lQB3lTTC/koSgbBIYwkU//k8SjsOr/aOIUVyGPpEEhgl9dbQF130 CQcnacaD8blhvUUpHfcxQZPgi3/+znIVLfO8n/GGOWZvW7DbKKlwJAx8TsjaHJyiRz/R 6Td7ZpweUPsn40Asz3E1S3eP0P2QAru7WVQwFnGCSg1Zk47YO9pW69lUmaqKQYSS4AGv Kq25xH3xFmUunY6juLcanVwQg4bSTiT8C43fFneruEldH7A+qAiojqMLLUG8V6IVP5aN eLVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wGyzsMcwyPdU32aTj0BzS3yJV+u0+Pq22bBiQhu0jRI=; b=VeQ8lNc8v3+LuFVYXHQ0Q4hjnMG9lK0Wup6qLnTOFc4iBoNEjeR4eT5gf6yVXoJ/s1 AzosCBDtsOkRr4fIOoNTtOXFzEiCO332lNkVmHVTJSfeNicG7bb4ayEIgItI8kxI8On6 NMmArPcnP2YlpXE/cBK6tq7eRpqlanZdT25QT6/KJ6xQrajYafO/0V6pmYZ87rGbF2Ek X8uio7ixi6mp470bOjcrVn84XCnnwEfrWyOjumPJMur3c6YRjvuZRk1kBQuJT0jbhGQ5 h4r0DGKHI0tt/TSKaQ92c3iwsOPWNiVMPa0Bh9YyJgKzbBWnmLUVeonrE0iBPSsexIo0 YQ6Q== X-Gm-Message-State: AOAM533x0lqt0TQf1cv0nIaJAwrX2yEyL4LAoCf3Q6JrMC0VnEc2Xs+M e6/relzMUwjV7OAn6eyXKhROKw== X-Received: by 2002:a1c:f003:: with SMTP id a3mr987664wmb.82.1626824071075; Tue, 20 Jul 2021 16:34:31 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id e8sm3354295wrc.6.2021.07.20.16.34.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 16:34:26 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id DDC841FFAB; Wed, 21 Jul 2021 00:27:05 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 22/29] plugins/cache: limited the scope of a mutex lock Date: Wed, 21 Jul 2021 00:26:56 +0100 Message-Id: <20210720232703.10650-23-alex.bennee@linaro.org> X-Mailer: git-send-email 2.32.0.264.g75ae10bc75 In-Reply-To: <20210720232703.10650-1-alex.bennee@linaro.org> References: <20210720232703.10650-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org, stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, Mahmoud Mandour , Alexandre Iooss , =?utf-8?q?Alex_Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Mahmoud Mandour It's not necessary to lock the address translation portion of the vcpu_mem_access callback. Signed-off-by: Mahmoud Mandour Reviewed-by: Alex Bennée Message-Id: <20210714172151.8494-3-ma.mandourr@gmail.com> Signed-off-by: Alex Bennée --- contrib/plugins/cache.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.32.0.264.g75ae10bc75 diff --git a/contrib/plugins/cache.c b/contrib/plugins/cache.c index 4a71602639..695fb969dc 100644 --- a/contrib/plugins/cache.c +++ b/contrib/plugins/cache.c @@ -355,15 +355,14 @@ static void vcpu_mem_access(unsigned int vcpu_index, qemu_plugin_meminfo_t info, struct qemu_plugin_hwaddr *hwaddr; InsnData *insn; - g_mutex_lock(&mtx); hwaddr = qemu_plugin_get_hwaddr(info, vaddr); if (hwaddr && qemu_plugin_hwaddr_is_io(hwaddr)) { - g_mutex_unlock(&mtx); return; } effective_addr = hwaddr ? qemu_plugin_hwaddr_phys_addr(hwaddr) : vaddr; + g_mutex_lock(&mtx); if (!access_cache(dcache, effective_addr)) { insn = (InsnData *) userdata; insn->dmisses++;