From patchwork Fri Jul 23 17:03:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 484653 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp1526418jao; Fri, 23 Jul 2021 10:17:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywvhZOA5r3RfSlj/oWDVfb8sWnUw8v67FSH+pbcHvq0ESR+6iPV860QF3LzR1oWg4BILqI X-Received: by 2002:a25:c805:: with SMTP id y5mr1303763ybf.203.1627060660301; Fri, 23 Jul 2021 10:17:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627060660; cv=none; d=google.com; s=arc-20160816; b=TBVzVM4YMDhz6I0wgTHe+e7+E2lngVxjRAnIqCFKzaJ6APjbRKXaioHJ8fY7V4V0c7 kTu6wSuagnbuI9x7zknWdKBTZA7RpEZHhLl/vTSJBahjl7xdh0YO3fVojC46KHguex57 vg7pSr7McJ6w37lfOuVMIXPAmQDIR3Q1/nqG4VscpYICAXh3mxNvvwbme1j0fHwhaTXC rZ5foMAzUPuMCdM5zqc4q5fJjiPbyDyUV1mvHIbBtAA+QoMR2eInhu+zmMMl9LuN4fF3 FJDryGx3aiAgizSI5jQJ+6QaHJ5LtONycNYSgzWfWwd34aBfmJWIR0/5q8c07/ONC5xt uQNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=IIFkc3IDhl2xdt4qYGTuRykEBsdkIzrzr3YT1MsJ7FM=; b=D5b6a6g0eCzsLqN45ToR1PmNlRHd7IB7ju7bhYbxDL7NspMgsIjfdXmk1weADcyo4t vFD9E+xqbhnrb3LDboPkTzigC67nvktcyTvyqZLe8XMtik8yFpyLhWSKR2a7F2f2srFw brinM9H7+GNPf73zvthjemx3uqTq8dec1MsNhHvB9kSjMa2dMF91F3Pz9TyMc151P6oX j5NIdNg1oAiKLlSNTrQPDQHn6GCSV8Vnp9ijJhExL5GZvRra+4OlpWi4k+G+KQHys9N1 T+2Kg+IyZacr9vkG00ld+/HTEN7fZ8RzpVH4GxY8fOlzhqQK9X2vfWGYCeay4gzS3ygO TZrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=xODsi07u; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q14si27102392ybd.117.2021.07.23.10.17.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Jul 2021 10:17:40 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=xODsi07u; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:52890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6ynr-00063h-P3 for patch@linaro.org; Fri, 23 Jul 2021 13:17:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59692) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6yg5-0005W7-Lw for qemu-devel@nongnu.org; Fri, 23 Jul 2021 13:09:37 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:36603) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6yg4-0008CW-4u for qemu-devel@nongnu.org; Fri, 23 Jul 2021 13:09:37 -0400 Received: by mail-wm1-x331.google.com with SMTP id l11-20020a7bc34b0000b029021f84fcaf75so3931287wmj.1 for ; Fri, 23 Jul 2021 10:09:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IIFkc3IDhl2xdt4qYGTuRykEBsdkIzrzr3YT1MsJ7FM=; b=xODsi07utCA3nU9rc11KjW4A9r4QUjmG251IEThlQugBQmMl/iycCULVyOJgRCEj9F NBBZSLgoFr91LH11z3f4YiqbMxQkkiW5rV97wDZyHwJ3WJ73qc0zfD9CkqF13QNu7hrj MjC9nvcMBwzlaLMghAz5ZT9eEReYAJ6kq5xSqXyOOMrN0rHtPlcCoYqX+mIH4RXUgIOa JXnnkPQOTKZR6YSS1D6cMWzlNIE/VQ/d7yMM9pr4Hv9M8WQXLS99JKuDGtPQaY1GSCIn p1XL5l23/r/MacoNkpvOQtPHjhLOtrZwHR/8iygsFwwI9L4v6OzvsiSc0rJrUdx1f6DG 8eSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IIFkc3IDhl2xdt4qYGTuRykEBsdkIzrzr3YT1MsJ7FM=; b=jY4AQpP3A0LSfRb02YAV3S39ji869B7JARBlId08xgAc2vuTaqrmxdgNqMcP/p4N8B 1H3WrO/lOtdwd5ZSJskaFTKBjZExxUXM2QLb7YnteYGnio1nHU+bv1HqCMGOPaTHwS7W cfb+HyFpTap1APm6oTZp8S/pYRHPZEY0VQEITDoNg9WqHOcUPaztEzbrc4rl+4gEEC3D lqyykvEurIWYMsXCGAaLzFXOuEpw7K4qXx1XdSXHJqlwrJhPY3+viCxaeTBmtkVj8C6a tO4RTzr5I8yb3RJkuHSbYzetJucGo1fef0q/wFOK5+ltBLyJHE8mCoEWXrk66CaLF2pm v8eQ== X-Gm-Message-State: AOAM531yWUq8RP0naZAYfQEfMbB5WU0LlHDR8wdweIUTuBUEogcVfOOa L8t54NlkZaHxELVKo54g+QCAqQ== X-Received: by 2002:a7b:c4d9:: with SMTP id g25mr14596698wmk.108.1627060174817; Fri, 23 Jul 2021 10:09:34 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id u12sm34277432wrt.50.2021.07.23.10.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jul 2021 10:09:30 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 3F4F71FFAC; Fri, 23 Jul 2021 18:03:56 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 22/28] plugins/cache: limited the scope of a mutex lock Date: Fri, 23 Jul 2021 18:03:48 +0100 Message-Id: <20210723170354.18975-23-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210723170354.18975-1-alex.bennee@linaro.org> References: <20210723170354.18975-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Iooss , Mahmoud Mandour , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Mahmoud Mandour It's not necessary to lock the address translation portion of the vcpu_mem_access callback. Signed-off-by: Mahmoud Mandour Signed-off-by: Alex Bennée Reviewed-by: Alex Bennée Message-Id: <20210714172151.8494-3-ma.mandourr@gmail.com> Message-Id: <20210720232703.10650-23-alex.bennee@linaro.org> -- 2.20.1 diff --git a/contrib/plugins/cache.c b/contrib/plugins/cache.c index 4a71602639..695fb969dc 100644 --- a/contrib/plugins/cache.c +++ b/contrib/plugins/cache.c @@ -355,15 +355,14 @@ static void vcpu_mem_access(unsigned int vcpu_index, qemu_plugin_meminfo_t info, struct qemu_plugin_hwaddr *hwaddr; InsnData *insn; - g_mutex_lock(&mtx); hwaddr = qemu_plugin_get_hwaddr(info, vaddr); if (hwaddr && qemu_plugin_hwaddr_is_io(hwaddr)) { - g_mutex_unlock(&mtx); return; } effective_addr = hwaddr ? qemu_plugin_hwaddr_phys_addr(hwaddr) : vaddr; + g_mutex_lock(&mtx); if (!access_cache(dcache, effective_addr)) { insn = (InsnData *) userdata; insn->dmisses++;