From patchwork Sat Jan 22 18:24:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 534113 Delivered-To: patch@linaro.org Received: by 2002:ac0:f7d2:0:0:0:0:0 with SMTP id i18csp1679294imr; Sat, 22 Jan 2022 10:43:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJxcQwMTIbzCFy+nVg/xXsDL96Ga1dLwn1jtD65/0w5sldruBCEpq/RTZ3njqYzk/XuYUcY5 X-Received: by 2002:a25:3105:: with SMTP id x5mr15720971ybx.611.1642876997779; Sat, 22 Jan 2022 10:43:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642876997; cv=none; d=google.com; s=arc-20160816; b=qYicROOrd9Ye1jBs2YrjiCs6t59U9lZkRHA+PEXehj4Q56HqUmvMWNDcu7IWfDBupS vutHjz4u6RKU75JpvxLpfSEKteEpM/DerxUIaX+7itUJfmYRHnZjZ55QHtSHga1UoqyI XGb9LTNcrcEBalugbFPcNO77QgGPtAutw2vw0glSFSfMKoXLYR29ZQqbunP3D6Fidv1t ewEihtQfIJ7PX9+JuwBTeGePpyZ87oyQtT2EzBBwwuSNP755lRC7+ENoo7/K8C3vHek7 nxZOp9y7GzhqtnRu48UHnajwQP+G9TSDYcqei0kZCoihjB1OzGvmq2ZqslGIAI6hDaiT rgCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=TWOwtfSkXv+Z1HhHrk1F8pisir4TdF801Jm4JXQ/boc=; b=Gj7b2rr3ofDcsmd4gR5LYd/JzMomdZZns9cH6IrGm5k2O8bUEGspHub5Toi++aYvqP jW8vIazRbJZSjetNwVlvVsONvhXYTeKj9otAUsiNgf1pqHvB52u7R1WGC525kfYTPSR+ Z2mtp1Qkk2plrUwN2MwsnLWOoXpkcZ8a6Rz3sZAKWjSiZxwynItymRWri/jUktId3UpD EylXxm0SbJcWbP+jI5w7CCQPTgt5NWb1F5+PXUQ0S/i/z9P+Zsx+jiqqIDb/pe1gLd+E K4mb0AwMxYCxn2DztC1pGviFhGGa156qByUXQ9KL4PSvpFq1esL/D4IsF+ZybZiVCVM4 UYHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cRHKJGXD; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id o2si4712231ybu.785.2022.01.22.10.43.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Jan 2022 10:43:17 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cRHKJGXD; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:40006 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nBLM5-0002z5-AK for patch@linaro.org; Sat, 22 Jan 2022 13:43:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBL4V-0005hv-Mb for qemu-devel@nongnu.org; Sat, 22 Jan 2022 13:25:14 -0500 Received: from [2a00:1450:4864:20::329] (port=54152 helo=mail-wm1-x329.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nBL4N-0007gX-I0 for qemu-devel@nongnu.org; Sat, 22 Jan 2022 13:25:02 -0500 Received: by mail-wm1-x329.google.com with SMTP id n8so20194417wmk.3 for ; Sat, 22 Jan 2022 10:24:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TWOwtfSkXv+Z1HhHrk1F8pisir4TdF801Jm4JXQ/boc=; b=cRHKJGXD4fHJzlCpIfCtSr96Me07yuTweLrRuVelmSCXVT8bHgR5tkGHmjUPyXV2Eu uFFfUC8T7z21/56+NKW/MSno1/Qq/IXpw+Q/QKdhuhN6zs0Hs+a3sA3NsRMPo7Cpt8qN LnyNPjWOKG0xLW524dRfFimLOms1FzHJjWfYqdqk9BadRgTw8pFNmG+iTrbw9k6n6jbV FmW4h5Us6l5tCr2zlkduLrZSrytGdhN7loh7+VDwcO1i5Kp/PO5M0udoDbnqpXa17ilc PHb8JYOHDP54tGB96p5uosrk1fMbdQL8MrfWLSaZxnpYr/IRqiq6UsDANzTOXMyt9lMk FACw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TWOwtfSkXv+Z1HhHrk1F8pisir4TdF801Jm4JXQ/boc=; b=T2RXvUsLq6lvYeYiRRJSmZyzMu5CLsEf3JXXdDWBWDnXibUa3e1M45NKbDM+gBj8ud 85LMEUkwO3j83rDWEY4F2wdaIuClAPVdvyG5wsnBShqYBvANpAJDiILGYbSK8Kj9i9Fa /bdta95F2G1lVNXwnGedQbNTbhbWGOPx8KcV2Y2JdSCjqBL8yGnkIXHvTxHduQUwogJc 506FsRpawk1A4Y4gMUgu9AivEIEpaKAdNnQ7icd/NAzEsE3F0oSYmzIZm0jxo4kf0KbR HQrLnL/2bv6TzchETp/pSaFTKOfZm6BIJjGYZHFFXXKHEyp9vwQUYAukzP7dY/rjT9UZ GBEg== X-Gm-Message-State: AOAM532ls7EQoF+dhHSm/w38HVqbfa4GPPC+xOZGZ5ElgGnzW8c6nSjW D/UdQ8UMaOpBYSgAVbY/JtKXJA== X-Received: by 2002:a05:600c:1e2a:: with SMTP id ay42mr2469743wmb.131.1642875889860; Sat, 22 Jan 2022 10:24:49 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id 21sm8870774wmk.45.2022.01.22.10.24.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Jan 2022 10:24:49 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 05/14] hw/intc/arm_gicv3_its: Don't clear GITS_CWRITER on writes to GITS_CBASER Date: Sat, 22 Jan 2022 18:24:35 +0000 Message-Id: <20220122182444.724087-6-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220122182444.724087-1-peter.maydell@linaro.org> References: <20220122182444.724087-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::329 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shashi Mallela , =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The ITS specification says that when the guest writes to GITS_CBASER this causes GITS_CREADR to be cleared. However it does not have an equivalent clause for GITS_CWRITER. (This is because GITS_CREADR is read-only, but GITS_CWRITER is writable and the guest can initialize it.) Remove the code that clears GITS_CWRITER on GITS_CBASER writes. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- hw/intc/arm_gicv3_its.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c index 1763ba4a671..d9ff7b88492 100644 --- a/hw/intc/arm_gicv3_its.c +++ b/hw/intc/arm_gicv3_its.c @@ -866,7 +866,6 @@ static bool its_writel(GICv3ITSState *s, hwaddr offset, if (!(s->ctlr & R_GITS_CTLR_ENABLED_MASK)) { s->cbaser = deposit64(s->cbaser, 0, 32, value); s->creadr = 0; - s->cwriter = s->creadr; } break; case GITS_CBASER + 4: @@ -877,7 +876,6 @@ static bool its_writel(GICv3ITSState *s, hwaddr offset, if (!(s->ctlr & R_GITS_CTLR_ENABLED_MASK)) { s->cbaser = deposit64(s->cbaser, 32, 32, value); s->creadr = 0; - s->cwriter = s->creadr; } break; case GITS_CWRITER: @@ -1027,7 +1025,6 @@ static bool its_writell(GICv3ITSState *s, hwaddr offset, if (!(s->ctlr & R_GITS_CTLR_ENABLED_MASK)) { s->cbaser = value; s->creadr = 0; - s->cwriter = s->creadr; } break; case GITS_CWRITER: