From patchwork Thu Mar 3 03:11:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 547786 Delivered-To: patch@linaro.org Received: by 2002:ac0:f585:0:0:0:0:0 with SMTP id s5csp255353imq; Wed, 2 Mar 2022 19:14:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJxtNbPxqGFktfeZiY1Np0KYSSr9lBW0okr7Lj5sI9M9+vWJ+Jo/T4SVlAlsxagzUKarXxY2 X-Received: by 2002:a25:d9c7:0:b0:628:be42:b671 with SMTP id q190-20020a25d9c7000000b00628be42b671mr1857083ybg.387.1646277250651; Wed, 02 Mar 2022 19:14:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646277250; cv=none; d=google.com; s=arc-20160816; b=opQzjblFaoDr0QxDlP4S6znbpwPoozILknlboBbLHqKoR+7om456TfEwrUlAAowUVc Q2/fxcUqf5bxMjc9Q/KtmZdDBT17ACE8QeS7WFZU4mO7p8fRnhgOdSHqAu8seEZYesJK b9tWsfVyLdnVyDY76F6B+RnaO9VbLtxXZPbtptbYaPW3GG2+A4FBk3QXPKInqo/GVFA3 uQhBI86Tk6/JBHfrkEg5oFejrA+7yFzicdPvina2kCz70FJ4VqrrRbr/mQJUdoFKPrzG FYXBdaa0QDJVsRnoI44Fp86CqLy03+86wP7oJVJLgdfpLDPRpIPa8pMmCb/UY1BHJY5E +9rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=z0nTGi36Q6kY2XhTWFaFoUNK+G34o+/T62xUlFxQppc=; b=u2v3WbcDEs7qKNLNL5a2WoQSySSuD4Uko/rCztZTO6HpOL2nYAWIRT3YCh1JVcHkAK 65ATHIfB/m2k7Febs/94dNKSLaRGddm6cR8uvLjyLy1oV6MyAcaRfdBKBX8Dw0WCtP9l lsNw7SMYzFBDnLfu4Ej90/ykLI9XAHR9kNzSvBsL91DrMU7iJIcu0iRCPDGirkjUfsdV q9klDkfbgRxzNxwXzrqi3KJgW4KzR0h6KsAxU6bUcwLq6oUdJfyTAx16EMvePJlJngeM FGH39lmJSuVm9EmVGz0IuwzRjhi+6DRSQdMnWyT1MQoySLaLQoG4wgFGhadvgPTZleVc KVIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zcgdZr3C; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c9-20020a25a289000000b00628918b9163si686198ybi.46.2022.03.02.19.14.10 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 02 Mar 2022 19:14:10 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zcgdZr3C; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:34102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nPbus-0006xu-5o for patch@linaro.org; Wed, 02 Mar 2022 22:14:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPbsV-0006wp-OG for qemu-devel@nongnu.org; Wed, 02 Mar 2022 22:11:43 -0500 Received: from [2607:f8b0:4864:20::102f] (port=46771 helo=mail-pj1-x102f.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nPbsU-0003Wg-67 for qemu-devel@nongnu.org; Wed, 02 Mar 2022 22:11:43 -0500 Received: by mail-pj1-x102f.google.com with SMTP id 15-20020a17090a098f00b001bef0376d5cso3623332pjo.5 for ; Wed, 02 Mar 2022 19:11:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z0nTGi36Q6kY2XhTWFaFoUNK+G34o+/T62xUlFxQppc=; b=zcgdZr3CaBtvHQgE1kM8OA3KdTpe5q2TFD04PX1L40Rr5C7qbBY+dPbMTNJ1S8pyPn U3AjOcFEh2iuSftOIJZ2iQP32tr5fJjoaU9FIp+fhlkXd6Ca6/upDlIbIU+g5wMAYZpB oqMfYMRjeEkdTJ2kg3CN/JuV3xm6l4qSqY8TWr4ZZUbOzctWQlhSGAfU3agNzvG96K+n BOTtdX3c55Lfj8xy3BAVQa3TJZt/a6IOfuDbnYWGPn+EWObnOKoINtHocYa+MdlqJnam LDoJsyPMqZF9ZYx2AYV6LkBAIlum2Yog/0ckqIB1ji2ib3EnCVGR2IpwueIZxaSeglQp rJFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z0nTGi36Q6kY2XhTWFaFoUNK+G34o+/T62xUlFxQppc=; b=48lf21jg+qNeyFHbGxE9BQkfxo5YrYqVMpvHVzQVn06OuEJtjQYqtyTn/7vYr1a7u+ QOBwueX38UM1xY+FWx5oGzBYhiaoaTzEF7QTwShX5IMZxZoEp77K+57enrRnHDXc1fd1 KUrqolhrakgGZWkvMIPd2P2du5UH20OUpwOwmEejgSdzU1eu0FXTJB1/VUmymBasmDhL bhe30ELeGimg/JZbVngkp1WqR+/ReHU2UBcfGtyX6+37vfp8K8MSy74QmTEy169m8h7k CrMgGBySQar4F/7W3T3ABNlhBfoK39gOg+tPRSJUL1oFfx1y0d3xZR//l22JffRfxz9w iCWQ== X-Gm-Message-State: AOAM531K1F2ZuLFguOISATJ88VOZtkzGJUcH4ZsDpVXLGBK0RwzCYlhT skeT//FbHDZ/XQQu1vf9EZ6afEQ0JJq4YA== X-Received: by 2002:a17:902:8c86:b0:151:8226:e93b with SMTP id t6-20020a1709028c8600b001518226e93bmr11379437plo.128.1646277096293; Wed, 02 Mar 2022 19:11:36 -0800 (PST) Received: from localhost.localdomain (2603-800c-1201-c600-e819-4400-f268-c391.res6.spectrum.com. [2603:800c:1201:c600:e819:4400:f268:c391]) by smtp.gmail.com with ESMTPSA id h7-20020a056a00170700b004e01663f59bsm605789pfc.117.2022.03.02.19.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 19:11:35 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 1/3] tcg/s390x: Fix tcg_out_dupi_vec vs VGM Date: Wed, 2 Mar 2022 17:11:30 -1000 Message-Id: <20220303031132.444233-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220303031132.444233-1-richard.henderson@linaro.org> References: <20220303031132.444233-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::102f (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102f.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The immediate operands to VGM were in the wrong order, producing an inverse mask. Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index 6e65828c09..508f1bccc7 100644 --- a/tcg/s390x/tcg-target.c.inc +++ b/tcg/s390x/tcg-target.c.inc @@ -2715,7 +2715,7 @@ static void tcg_out_dupi_vec(TCGContext *s, TCGType type, unsigned vece, msb = clz32(val); lsb = 31 - ctz32(val); } - tcg_out_insn(s, VRIb, VGM, dst, lsb, msb, MO_32); + tcg_out_insn(s, VRIb, VGM, dst, msb, lsb, MO_32); return; } } else { @@ -2729,7 +2729,7 @@ static void tcg_out_dupi_vec(TCGContext *s, TCGType type, unsigned vece, msb = clz64(val); lsb = 63 - ctz64(val); } - tcg_out_insn(s, VRIb, VGM, dst, lsb, msb, MO_64); + tcg_out_insn(s, VRIb, VGM, dst, msb, lsb, MO_64); return; } }