From patchwork Thu Mar 3 03:11:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 547788 Delivered-To: patch@linaro.org Received: by 2002:ac0:f585:0:0:0:0:0 with SMTP id s5csp255402imq; Wed, 2 Mar 2022 19:14:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJxFlVDupWPsxBCqNP1DgowC02VvIw0UCP3mkfECPsqFGTyw1MHwt2t00X2TKRaVqRS8b0o/ X-Received: by 2002:a25:cc8b:0:b0:628:9263:38ba with SMTP id l133-20020a25cc8b000000b00628926338bamr6292700ybf.291.1646277254688; Wed, 02 Mar 2022 19:14:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646277254; cv=none; d=google.com; s=arc-20160816; b=nGBTKI+yoeYFgqSvUU7E8WvBl9+NcueIWbVDUmYKeGT76+gorXijbaeAPnHmObN+DL PXdw+RuxZ7VUemsvuEzbteSoOGd1gd4gZos+5qFxNDx3iyR0wKstQnxTMJp4B94iabLs ZVFfPlAQQ2sQ48BLu2fv74+WdV2JWeiw1jbYxdxasfO6J9UKAsGPGkkA24FyW6rWQ2oV Ottosj6AsaE9KztTynmI37a8fLlIf/NQoeFRpt8M8bU1rdK0qqSZ2wPV6YUJAz4u/PFo X5ZfQbX9HHwK/JJXId5TU3da3ALczvVMLXJ1mLq0MHfgzYR+XIg3QIfovI+4wUdh5uQy 51uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=DPs3qyT+uZfNbgHJhAl1/at2oy1K0HPub76v6Xk9tE4=; b=P6pGKdLR3RBlfs2+kd1C66L2vcP3R23NmtCfzdr+a8vA7TbTmOtGoOvlhnAronb61Y w7R/sks26EG3RyKvAXH8F9qHwDKqvyBEe08fZ6VevICbby/9qujZUUXni2zKSvc7epjL 4libsh4mleS8iu6tOhYQA7ikNJL+QJO6JaCOS1Dfeu0quK82W6kXgFszf/F5GI8tpU0X LQ0/yQPxRzdMJlI4RDRkTeZc8ns/MW71jjer2grZSK2RYIqdBiIO90ECREZOouCqqMQj HMs2lYhwZxNC6Uz38Oc6+btBJFHd1SymU+kH/ifH6QpK6poOmMzK5Ie2zYSircZ/iwmb 5OFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OfS4Ns3M; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d204-20020a25e6d5000000b0062457e308f5si655743ybh.482.2022.03.02.19.14.14 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 02 Mar 2022 19:14:14 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OfS4Ns3M; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:34368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nPbuw-0007BN-4x for patch@linaro.org; Wed, 02 Mar 2022 22:14:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPbsW-0006x8-Vm for qemu-devel@nongnu.org; Wed, 02 Mar 2022 22:11:45 -0500 Received: from [2607:f8b0:4864:20::1032] (port=41655 helo=mail-pj1-x1032.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nPbsU-0003X4-7U for qemu-devel@nongnu.org; Wed, 02 Mar 2022 22:11:44 -0500 Received: by mail-pj1-x1032.google.com with SMTP id ev16-20020a17090aead000b001bc3835fea8so3677347pjb.0 for ; Wed, 02 Mar 2022 19:11:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DPs3qyT+uZfNbgHJhAl1/at2oy1K0HPub76v6Xk9tE4=; b=OfS4Ns3Mg0VEHvFW7Pm7KFSx9SCEqPhSAoL/AEMZB6yLObtcQoXwAmOwn8seYE8GoC 5w8trA/rrLS1Hba2l7UwfINbGpsp6qQ359G0gnuDWK2CpRtdizyq5i9GKhiHAw+Obp3k vxPr7Klwl1kv+FulCwFekMVPJ6jGI21ACVGnkU2gNPqAfuR9F+gvW/SW8FCFiy5kIjWy t/cP6GpQMAkTv67JjwiFfbIKT+5cYQ96KL473k5JaGtbuzBkYyDueL74/FolWzcsK0YV +uhq+mAPv4MWsU3RZHZI4kDhchnHxwjX7i5O5RO4CsSBjdSqHK+R1fUhSaBH62fwVvc0 NCjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DPs3qyT+uZfNbgHJhAl1/at2oy1K0HPub76v6Xk9tE4=; b=ida7WF4WfOhOzGp4lHpGwZQyGzwLM+MrOX5sPzBJY6jx8HhIRCS3+VTtjJ5KuuTHc4 f2KdbYd1rPHDanwJJYR+NEtSAIFOq6eOLy+yG2mfUP7jmfPublmvORbDxBZHPHDoYjil 2cbUqdz6K0JnKR0rJ5KUPRuYEqNRadFxi1Q9A/na9YYyMl/qJ6bwm3MevvHzfM8H++Zr AYT6l69z6DTpzMFM48SyTKcyttcRSXbvoM8gKpxSnIF803Q3uY8NitQF13RkVxh+miA3 GUo+jhBgLMQko7wXyoWx3Tl8UW9nusWdVHof9s3AMLWwNZB9wRwWXeAOyjSY+P2PfFns P64w== X-Gm-Message-State: AOAM533m62h6gDAKvuEtbBpSFYJcZtyDTvfj+YhKz6SNp71vrj1FDZKj T3rTI1Mw8YUdRf5JTfG5yoTH3zbDq+aCGw== X-Received: by 2002:a17:903:230f:b0:150:a2f:e070 with SMTP id d15-20020a170903230f00b001500a2fe070mr33897186plh.139.1646277098726; Wed, 02 Mar 2022 19:11:38 -0800 (PST) Received: from localhost.localdomain (2603-800c-1201-c600-e819-4400-f268-c391.res6.spectrum.com. [2603:800c:1201:c600:e819:4400:f268:c391]) by smtp.gmail.com with ESMTPSA id h7-20020a056a00170700b004e01663f59bsm605789pfc.117.2022.03.02.19.11.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 19:11:38 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 3/3] tcg/s390x: Fix tcg_out_dup_vec vs general registers Date: Wed, 2 Mar 2022 17:11:32 -1000 Message-Id: <20220303031132.444233-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220303031132.444233-1-richard.henderson@linaro.org> References: <20220303031132.444233-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::1032 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We copied the data from the general register input to the vector register output, but have not yet replicated it. We intended to fall through into the vector-vector case, but failed to redirect the input register. This is caught by an assertion failure in tcg_out_insn_VRIc, which diagnosed the incorrect register class. Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index 3b185b3c96..33becd7694 100644 --- a/tcg/s390x/tcg-target.c.inc +++ b/tcg/s390x/tcg-target.c.inc @@ -2675,6 +2675,7 @@ static bool tcg_out_dup_vec(TCGContext *s, TCGType type, unsigned vece, if (vece == MO_64) { return true; } + src = dst; } /*