From patchwork Thu Mar 10 11:27:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 550131 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6713:0:0:0:0 with SMTP id u19csp943591mag; Thu, 10 Mar 2022 04:26:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJwqVPSHgGzWhHfCeFmIaSUuikTImQ7QjB8LLFC3OEvKyhq2mVAQqUJ07IJ4yxqS6Toqlhry X-Received: by 2002:a81:4c57:0:b0:2dc:c7e:605c with SMTP id z84-20020a814c57000000b002dc0c7e605cmr3891384ywa.342.1646915209923; Thu, 10 Mar 2022 04:26:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646915209; cv=none; d=google.com; s=arc-20160816; b=eWrBIhvKjoJFA6TSzEcNuvaPNh+ulHWTApLxZutB4qb9ykryoDovnX4tIyISEa5Uxq LB/DikA86Ml8Y6VeZZgRvKt8P34mkryWuQ+TyWHX38q6npFAFJvAikxDoelnpiQXEm2q SqG6eEZSQ2JJ6ZAq4zYhyoXCdlNCstnnRLxZGYqDPFiYyJFjp7j3ylx/MssAXB44HvAb KdbpcNzuidZbpoH+CXfN2d92relOA9tveKMp+fzs5h34btdWeqwIU5aSmqlSXztMzmzk +jeirrPez3T4udYe9lWlypmfVtKkO03mLB0hPkLNn5BzzPixzjv/i4qE9AJ6zM7P1BhW BbzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=PHMXz9q73HVjYaAorTgnEhJkrDs42cYUdRyVosZEm/k=; b=MNjLwZ0Bi/rJM2EenZu4IstLS3nLy4SNMd9G1+o8e2vqfMdYJ1HOxR5vuq7wSzegYs MU+WR1LfIJfEPhaGXDae/QHBYgpsuVSoYp0X2LjYxXsXnIBgO68znfv4FhSTDt1NSdyK RASQJsLdz/voJVfxUScAIMfJJcVKOVutNz0V8fX5XE/J2s1RyxvZjcrwW/cLaF7NETy0 SAgBR38XWc3GpUWylk6luaD8Z+BLPye6H6EedPXZNxKgxh4s7PnzDAVkIU6x5/T/96m7 MxQT1R9pz84ekhLcnYs2W2h1HPWLzOIE2OQ4Wc659M+y2a6Zb0IopiR6J4k2eLTACsnH mywg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=UO36UmZn; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 130-20020a810888000000b002d68040a00asi2606463ywi.404.2022.03.10.04.26.49 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Mar 2022 04:26:49 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=UO36UmZn; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:42312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nSHsX-0000QD-Ex for patch@linaro.org; Thu, 10 Mar 2022 07:26:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSGxo-0006K4-Ih for qemu-devel@nongnu.org; Thu, 10 Mar 2022 06:28:14 -0500 Received: from [2607:f8b0:4864:20::532] (port=41819 helo=mail-pg1-x532.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nSGxl-00082B-CO for qemu-devel@nongnu.org; Thu, 10 Mar 2022 06:28:11 -0500 Received: by mail-pg1-x532.google.com with SMTP id o26so4484785pgb.8 for ; Thu, 10 Mar 2022 03:28:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PHMXz9q73HVjYaAorTgnEhJkrDs42cYUdRyVosZEm/k=; b=UO36UmZntZvgjIPv5B0+rQ27YUeBJ/Iwa7/nvsUwT9IeiWn6KzBiy45kZl5URtgXjT JXKE60W8g3Ug8Tp0ec9wcUFp/s1cfrLQk6cm9pA0DRTFIkHGi28UWMI6sttspZR55nUw J4PeriBNbi5prGQaBGec8oSyAd3SD7Np5lWhwHFL9lgxEGs43IVnLND85mPjfVoMPcrH Khsl/s05OF+X+ldvqz9PkCsCkSpWaFb236PQECBc/72vS/e9dIQkMRb1cO1sVgGMUXal zTp9ltfQuJyIxt8RFnMjFQEPsyoYyVOG9mMIzZ1UTs0Ea8s+RRt17io5KjFjCZdW/70Z GDcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PHMXz9q73HVjYaAorTgnEhJkrDs42cYUdRyVosZEm/k=; b=Omf1Rxb1Sv3npqywiKF8q6Q/ZrdQr9/jWDXvoKk97fwXLbOVhLEH94Ghhs3Z2KCmdV ONeS+7fHIj45xjdZnGd1IlhwspBt4MC9ssJFVvdEMlO2AKdStASm42HR7DMo2GLUt3xT 7JNRqqrF1uzlLJT04cWgUKDqawYj/qTFF99XfAqlxPYgXdPZHLhRy+oux+SqIfra8q9O EArXkD9+khCHfc4QudlPPHv8lL/51zYAM8kKgaz4m2HxgvNfBu98IFctMP3uz1AwjMWl bh9nx5/QSRHlLBSZQVIYi/hC5ZNjvqVfnKe889uaaKkrAvKgE9upxTJEdoulKhRT1Uiv VKpA== X-Gm-Message-State: AOAM531Y/eWppf8BqAkwQ1oA1aIQVs+nu56Fb+wrqOsru8R4jSa4St1T JzMtZsjqp7Gk1xKSxSwOA2/Bhc9MR/jsCw== X-Received: by 2002:a05:6a00:a8f:b0:4e1:2619:11a2 with SMTP id b15-20020a056a000a8f00b004e1261911a2mr4483830pfl.53.1646911688184; Thu, 10 Mar 2022 03:28:08 -0800 (PST) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id js15-20020a17090b148f00b001bfc8614b93sm3114977pjb.1.2022.03.10.03.28.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 03:28:07 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v5 36/48] target/nios2: Hoist set of is_jmp into gen_goto_tb Date: Thu, 10 Mar 2022 03:27:13 -0800 Message-Id: <20220310112725.570053-37-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220310112725.570053-1-richard.henderson@linaro.org> References: <20220310112725.570053-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::532 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::532; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x532.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marex@denx.de, peter.maydell@linaro.org, amir.gonnen@neuroblade.ai Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Rather than force all callers to set this, do it within the subroutine. Signed-off-by: Richard Henderson --- target/nios2/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index f61ba92052..51907586ab 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -165,6 +165,7 @@ static void gen_goto_tb(DisasContext *dc, int n, uint32_t dest) tcg_gen_movi_tl(cpu_pc, dest); tcg_gen_exit_tb(NULL, 0); } + dc->base.is_jmp = DISAS_NORETURN; } static void gen_jumpr(DisasContext *dc, int regno, bool is_call) @@ -208,7 +209,6 @@ static void jmpi(DisasContext *dc, uint32_t code, uint32_t flags) { J_TYPE(instr, code); gen_goto_tb(dc, 0, (dc->pc & 0xF0000000) | (instr.imm26 << 2)); - dc->base.is_jmp = DISAS_NORETURN; } static void call(DisasContext *dc, uint32_t code, uint32_t flags) @@ -251,7 +251,6 @@ static void br(DisasContext *dc, uint32_t code, uint32_t flags) I_TYPE(instr, code); gen_goto_tb(dc, 0, dc->base.pc_next + (instr.imm16.s & -4)); - dc->base.is_jmp = DISAS_NORETURN; } static void gen_bxx(DisasContext *dc, uint32_t code, uint32_t flags) @@ -263,7 +262,6 @@ static void gen_bxx(DisasContext *dc, uint32_t code, uint32_t flags) gen_goto_tb(dc, 0, dc->base.pc_next); gen_set_label(l1); gen_goto_tb(dc, 1, dc->base.pc_next + (instr.imm16.s & -4)); - dc->base.is_jmp = DISAS_NORETURN; } /* Comparison instructions */