From patchwork Wed Mar 16 05:58:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 551834 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6713:0:0:0:0 with SMTP id u19csp6171mag; Tue, 15 Mar 2022 23:09:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyduB5aEBOFP/f7VKLlH3h4SDDcOmjpbqG5GtMvzQQX2xX0iuy8fk6m0nLr9pb8jFwdOd/C X-Received: by 2002:a81:1a4e:0:b0:2dc:aac0:36c9 with SMTP id a75-20020a811a4e000000b002dcaac036c9mr28613460ywa.252.1647410964203; Tue, 15 Mar 2022 23:09:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647410964; cv=none; d=google.com; s=arc-20160816; b=g7humjz4eHWSvZLMRCLxDfPdYGJ2sDgsP5GgxNhq5TSrGIB6a9W4tk3U2cy5W8/qSm Iv36/zux3+1ZCtpKrSllf+SyJYUZNSMX5PP7Dxv56y9lOyXe2ODXGxxgf3AEfqbih3xj oGDqJVW7uD/uUBPs19lvo8KnKX68C7jocIRr2Yzsrf82pY8cxoZKilxmYLLI2tGGCKvV x9zLJWunA7yt3ZC1ugXU3i1GuUdN/zKDDeqwM8S3rfNSFUEJSJJuxmrG8cloCfYh6oy9 QcMnCzINjOTM9+rFFqtm/6Fmxt2M2fc9uT+C11xrsxZ97wPvn62L2ld3GkQtA9NYcOs0 erWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=LMgZ+9vBXxkL3ObSKn51zXKkedsdNPSwBIC1O+HtQSg=; b=d+fj9mtJ0C071VH7YpTqiDt+nrB1DFgApBsUoi0PlCHrNarAiTq1rW1zzTRZP3zCRB vp1oswRBBVXjQiDm9Sxk7uGha//YTUiVxWxq36BEiPbWgFOI6o5Xt1KzwuEy4wioujfu OcUjJKPOo1GU8x29rdgQV6Z7nfPSbc4QPE8AX236O/Q0IAv6mfCk8k/jfvi23WKAFxGR d82U/J7PbPYWe5y+C6RTcNEr23hfb1nc0DCAk8tez6Tal139iw3NHdmzHPOt7sJv7Xji zZEqGO5FxPvu15Mg/vHxFlemAZO4JFExLLbzIb0/Ct7K9GJe9JlVwlDsEXSevP7BJwSh kZsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=y3VL7dxb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s14-20020a25830e000000b0063391c4496asi253223ybk.298.2022.03.15.23.09.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Mar 2022 23:09:24 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=y3VL7dxb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:46126 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nUMqZ-0003Gq-HF for patch@linaro.org; Wed, 16 Mar 2022 02:09:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUMgV-0002mo-7o for qemu-devel@nongnu.org; Wed, 16 Mar 2022 01:58:59 -0400 Received: from [2607:f8b0:4864:20::430] (port=37786 helo=mail-pf1-x430.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nUMgT-0006UH-Ln for qemu-devel@nongnu.org; Wed, 16 Mar 2022 01:58:58 -0400 Received: by mail-pf1-x430.google.com with SMTP id t5so2555715pfg.4 for ; Tue, 15 Mar 2022 22:58:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LMgZ+9vBXxkL3ObSKn51zXKkedsdNPSwBIC1O+HtQSg=; b=y3VL7dxbawsuNElVlAzqQiOuvcWEl44aiEPZ+5+mbX56dByS/YXXF7QudSbKs5055a jc4Jutqt5jyRMykrQkk8pxE/hZXxXrysXHAjlFkXtSCfUvP52BKhU1wifrFh81DUlYHu 9v7eSWPjt3YeZhb9NZu+BHFCkCZlyQIh0J7W5M90RdpYrw7RjRk8ignBYT9MFZOzsENQ igALtrnFP2Y/8eGOZIcRHrxkYxJt4rIjzZCFhMXWPpTgvluVs+PWIxm3gJ92O0n08z3Q yi1kqOQElvkVnbtqzzFYbkRrdv1QPCBzyLRoDHXa0Dak7NtB9yoP3QVWlHGerrm9Rixc LdqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LMgZ+9vBXxkL3ObSKn51zXKkedsdNPSwBIC1O+HtQSg=; b=NXFko/Vm8EJWBT1UhJ7VPQo27/zGc7NR1EtzsxX9eYmoHG62XgxmmaBddH7nY9duyT KVmayfpmbPafmr3Mc2x1ywarj6hsC3nGsW/66WzvXssuggIbppzj4GumkwO650SBnDJh HIL3tGKGlJHW1zVwh7twD6AqaNRoiyFdoMZSgIBHwjfVNwVkYNY5fbCJPj2J6ifcRBVY 7M/zvrMVfehsRd97qGZRvejydapUuv5503N+Ritxf9d2mxRqsvkHNEbMhHMBN1Bzt13F rNB5kMZBS3obdhoxVnWoLOrLjBmLikb4mKkQuYz0QZfA3V6BUUbLb/eK5gUfX39nNF+M LsTw== X-Gm-Message-State: AOAM5334KSIJDLxtNaL4/4owClCh6S6w+Us3r5UEIxc4WkHSJ+lmSNiV 0VBgZEgHsAiOdZQ+QV3+ljwO20hhP7qqMg== X-Received: by 2002:a63:4e:0:b0:37f:f3f0:2d24 with SMTP id 75-20020a63004e000000b0037ff3f02d24mr26897821pga.526.1647410336437; Tue, 15 Mar 2022 22:58:56 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id i24-20020a056a00225800b004f6edabc9f4sm1236290pfu.72.2022.03.15.22.58.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 22:58:56 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 15/17] linux-user/strace: Fix print_syscall_err Date: Tue, 15 Mar 2022 22:58:38 -0700 Message-Id: <20220316055840.727571-16-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220316055840.727571-1-richard.henderson@linaro.org> References: <20220316055840.727571-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::430 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x430.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: laurent@vivier.eu, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Errors are not all negative numbers, but only the top 4k. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/strace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 2cdbf030ba..f235118fb6 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -684,12 +684,12 @@ print_ipc(void *cpu_env, const struct syscallname *name, */ static bool -print_syscall_err(abi_long ret) +print_syscall_err(abi_ulong ret) { const char *errstr; qemu_log(" = "); - if (ret < 0) { + if (ret > -4096) { errstr = target_strerror(-ret); if (errstr) { qemu_log("-1 errno=%d (%s)", (int)-ret, errstr);