From patchwork Sun Mar 20 16:00:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 553172 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:1248:0:0:0:0 with SMTP id z8csp838750mag; Sun, 20 Mar 2022 09:07:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxImUG4XkWrG1ZB8F6oBjqsG70N5WjqvJ/bzqLVP/i8zkGElq5Fy6Hw0FlTOKQv9fnXbRbI X-Received: by 2002:a05:620a:1539:b0:67d:45f2:f5bd with SMTP id n25-20020a05620a153900b0067d45f2f5bdmr10603811qkk.313.1647792473119; Sun, 20 Mar 2022 09:07:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647792473; cv=none; d=google.com; s=arc-20160816; b=MOamRfO5lUOisDaQ1BuuA9IDEP1x1lJmlqbCzrHCYGFlAHF3YTGYPZjHz4rPpPG1ul Vsa0CcHXFJS7pIIroBoTy1Ua75kKtuAe7rNeD2ICXIJuBdczarft5BvcNdVNOa5MnPdi IQqmB/TqBxo9SNDgx3T6yPPGy+9VlOlDJaBuNA8nfQewz3mqwUkkQVz+ZyuWNcMqdKCi uoM27paXh2FbNgX5rSoPy2nc5DRT+kxcAVQ/H5wTtbWRRzEywJ7+qyUsp1m1KeVbsqYL JtYYpy/7KoyEXP+9+XCi8Fg71SIKD3rucmLYWCW9Eu4cdREvUFGiuGsr3urIAi4aJSMb dsFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=1T8UqtoVKD4QHw3Ob4yOhcSZMQMSY9kekR+Tew5Lo84=; b=yJZkKk9wHxYiVkrLKv+p0hoGj2+hluvsgSg2bRWrGphL58Im47pAU3LmuzEHZze6bu Lf/AT6qCDkuyboISXrkKF9MSTL2OScSr10G6xtnVH5m67Wnbe09KTIAuBj2MEZv4105I J9o9LQbIpze7cH0UyJEG6J/jKbPFXbPfRrXNi9DWOfuIKhd/ftsTiywCtvoaYy7BdsAE TEm78+X5c+IXmVKokflS5OOQoFWIGnz56wQHNBghJoHLnFDALd3ykpPWKhDis1NAvxUR Lneqiq6tHaX+/Q/3lLAMS1cIXn+uOeM020OFMiPW4Tcp6x23mufjLdvgyU8g/J+EFTEH D7sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=q9iBdsM4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n13-20020a05622a040d00b002e1fbf3becdsi1469495qtx.190.2022.03.20.09.07.53 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 20 Mar 2022 09:07:53 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=q9iBdsM4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:52942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVy5w-0002zR-L5 for patch@linaro.org; Sun, 20 Mar 2022 12:07:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVxyi-0005Ku-1E for qemu-devel@nongnu.org; Sun, 20 Mar 2022 12:00:27 -0400 Received: from [2607:f8b0:4864:20::636] (port=41781 helo=mail-pl1-x636.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVxye-000664-Cy for qemu-devel@nongnu.org; Sun, 20 Mar 2022 12:00:23 -0400 Received: by mail-pl1-x636.google.com with SMTP id j13so901464plj.8 for ; Sun, 20 Mar 2022 09:00:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1T8UqtoVKD4QHw3Ob4yOhcSZMQMSY9kekR+Tew5Lo84=; b=q9iBdsM4EkbRro7Ic5JxuoOFhU41ia3MxslqdAMcbe6uJVTW2P1nMtP8Lb8aOIHfZV xHh/sj6qm/EqqigIp8kfFUQuKN4IBN1qbU2lFyXnXi4YgddSPGKrWzY95Tlc+xkqZNgm I1GckOyZ2VwJ48uPa1uglBYV8YYn6wCSDhwR4JCkkG9g3MebXaf3tK6jUmSjwun346dh mZ0Z7a8rLPWz8yvh9tQReKcSYdRo0w/0C5rL43LVoH73O45g5jPE7u5iFgTXdS918HzF s1EBusfaR60U+dv0+Xq+q/4Bg6bIzjO2Ivl3tytiREquz39Ho5iJeh8WqKKGzTGiRA9l Dxsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1T8UqtoVKD4QHw3Ob4yOhcSZMQMSY9kekR+Tew5Lo84=; b=jQR0OszJorXxrHEcP+kDRK/SYC9rLUNQMHeDBKH1SVHPaz4Bwbs+PVgKCLUlXPiVkI PJf4C/RX4VHnQtnzZ58TH29FD9+6ZPrGHWhwv9CfibKTp9JA4MtJ2eIMD+eRtOmd4HUt x/Fz+7aYyWGdZu1pHgZYscvyuJoF7fwuhIHauptnIqyqNLaeN+/2UB/eI8kqcVZiEAIA l7ur3vjb5/rNI1S4OO3KaKr3fm+9HwPdTuwv0O2QnHD1q/w0J28ULbJdcFUhirPgELcd kdFzxcOMNCV+wKphKd9i78ozIEUAj/OpXfYZrKjLAQ6s7Ck4tpKrf3v9bUTuaR2tlcd5 qfWg== X-Gm-Message-State: AOAM530SSQp/B2CANLk2J6heO2IyTkcDovfjIweoPnKRQrcCZcx/z3c+ JT2/17FTWLAwBNa9JokuJLxJFDfVe2K8gQ== X-Received: by 2002:a17:90a:1197:b0:1bf:65ff:f542 with SMTP id e23-20020a17090a119700b001bf65fff542mr31718143pja.5.1647792015024; Sun, 20 Mar 2022 09:00:15 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j23-20020a17090ae61700b001c6bb352763sm6590099pjy.52.2022.03.20.09.00.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 09:00:14 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 2/7] linux-user/nios2: Drop syscall 0 "workaround" Date: Sun, 20 Mar 2022 09:00:04 -0700 Message-Id: <20220320160009.2665152-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320160009.2665152-1-richard.henderson@linaro.org> References: <20220320160009.2665152-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::636 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x636.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org, laurent@vivier.eu Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" There's no documentation for what the problem was. Fixes: a0a839b65b6 ("nios2: Add usermode binaries emulation") Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- linux-user/nios2/cpu_loop.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c index a3acaa92ca..ac71f4ee47 100644 --- a/linux-user/nios2/cpu_loop.c +++ b/linux-user/nios2/cpu_loop.c @@ -48,10 +48,6 @@ void cpu_loop(CPUNios2State *env) env->regs[7], env->regs[8], env->regs[9], 0, 0); - if (env->regs[2] == 0) { /* FIXME: syscall 0 workaround */ - ret = 0; - } - env->regs[2] = abs(ret); /* Return value is 0..4096 */ env->regs[7] = ret > 0xfffff000u;