From patchwork Wed Apr 20 18:05:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 563968 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6886:0:0:0:0 with SMTP id m6csp4400164map; Wed, 20 Apr 2022 11:09:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy1+VKhH6rf4/2g8KPXQ9tpIIiTDN6vnmknR1G0zU2XDFW1bM/5R+G9X9PnFMQu5NwOpPkC X-Received: by 2002:a05:6902:114b:b0:644:cf4a:d6bd with SMTP id p11-20020a056902114b00b00644cf4ad6bdmr19773431ybu.646.1650478181460; Wed, 20 Apr 2022 11:09:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650478181; cv=none; d=google.com; s=arc-20160816; b=mBQV05uoiVeHId23c5sLnYBU2seNUkAwXtJmK2nC1IXKcCDoPR9VUOoP8KEYu/3JnN ArGo19+ZInJsZX8hbGWTj14Iu+rc8aewK/o5XGUgwKLXaN7wTvvp2PmsUfvw4SON689E rv58R1d3sE1DRfcjjbIrSHen6i3J8EMM9iYI7cSiQP/jq0JgFYStsesYfE/3amENSFJ8 4WTK+pNnxGySRV5ZXp6x4tUF0Wo1Eis/e3B7/8tPWDCsE03B+HFiPLKd2LcRmD63U5Z6 DBUd2Q4vesgodPXzn4HQ4KSIsudHpzidOqUa0TTSBb6M2WAyFnH4k/usRzvZKhVAPJc8 lV9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=kPstaIQPIw+2x97scwvcI65CdFqpKkQGr7FCT5ZeuMo=; b=zK2Tfz7qBle7XPWGakpF5mhaAQIBVlRGNnMUoo1In7Y9XTC4XfnfWewnRYittCPMnG mfszJUP+3d/1soWEhr7P+zrFcsdLXVHfGpZQO8gMbSxUuVocvjrJGBbNh5RkixHYx919 OTrY7ch1CRstOLzlQMWZr8yAutWPKX9oEQS0Y0NfVbVzALAxyHkfZBfpRh8z0onFPmvp MG6qtqEgP6GtJ3CdHm3CjeOFBOsjVxIzDFzBd4blV7qlcINHcl607H/iEkUXBjvX4jBv 75oAirTzgUX7Ml9wtb/mJrkzXW5UKV+y7K1WuuF1BW1U5ADi5qGvF6U6qOpEtPzD+03p uq9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dtI+af1+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id p123-20020a254281000000b00641e29c0464si551869yba.667.2022.04.20.11.09.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Apr 2022 11:09:41 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dtI+af1+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:58660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhElo-0001CU-SX for patch@linaro.org; Wed, 20 Apr 2022 14:09:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhEif-0005Gz-EO for qemu-devel@nongnu.org; Wed, 20 Apr 2022 14:06:25 -0400 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]:34700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nhEid-0001AX-6k for qemu-devel@nongnu.org; Wed, 20 Apr 2022 14:06:25 -0400 Received: by mail-pj1-x102a.google.com with SMTP id d23-20020a17090a115700b001d2bde6c234so3926251pje.1 for ; Wed, 20 Apr 2022 11:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kPstaIQPIw+2x97scwvcI65CdFqpKkQGr7FCT5ZeuMo=; b=dtI+af1+EmvVO0e+WwYYHbwI+83G4fGMsmGIX87mxC95wHf+XbclDd9hVujM/XMQVN Nm+MOanDjwovJJkXmMkvAAbSCi28sH89uJyRYtxNA7zWtL1E1eJUh8L4SJ14MdL+sEAs KNEdp5rN8+67UPwfJe8bK7vooiWXqeyfYYnha9hYjUd43jjYgzIwE8cbVw5LUlB+dwRF pRJZU4f26CztXFT/BSIUoOvu0sWjq1mMJ+KQAcs6s1hQLFvlESPBq7A8W+5rsqYt4H7O dtb5xXvh2nW7YAl3zEXoLiHwmcTEXsw0OU1bcpbXWsZ/deVJm08D6OgRQdm5go8+Zpba apGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kPstaIQPIw+2x97scwvcI65CdFqpKkQGr7FCT5ZeuMo=; b=go5B0iuluV9oKNUZlykMhVENkcvvpVxjbZFeComDNcAooxELKr0VAhhlsSFltc82G5 KI27vBrrZ5RQqylhwMXSXBU6vNgSK42+PsshXYfgumPpr82qJ5UtbHonruMgukDAsxBf qSvU4TrXepjTALPAyTs/ZkHqbBsMeyr9QAyzqQG81OqKdIFeP62obHTDjwgEkRlc8wLi ehPx/G9tZCCFlwuYod6sRIW01Aa+JHKwVdsPl52oELfMVJUWTS09auBmErgQ3lWnmORs UEPqIvQVz7ueRVmKFa72xZStyrbkQ7/nFDvaPhkyvYM3Eo9VBVUtHDDZDtZfXBEnngXA hLFQ== X-Gm-Message-State: AOAM531ltZ/2f+Mj3l4WLQxEN8SmyjO5rky9gXyo8GJOxIpajT5j9ond XDl5Dg6bH5qirilrPWsXLvkpd3QhgzNLzQ== X-Received: by 2002:a17:90a:af98:b0:1d4:67d4:d122 with SMTP id w24-20020a17090aaf9800b001d467d4d122mr4403111pjq.166.1650477981963; Wed, 20 Apr 2022 11:06:21 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id i2-20020a17090a058200b001d2fc489b8asm56681pji.25.2022.04.20.11.06.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 11:06:21 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 02/39] target/hexagon: Remove qemu_set_log in hexagon_translate_init Date: Wed, 20 Apr 2022 11:05:41 -0700 Message-Id: <20220420180618.1183855-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220420180618.1183855-1-richard.henderson@linaro.org> References: <20220420180618.1183855-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::102a; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This code appears to be trying to make sure there is a logfile. But that's already true -- the logfile will either be set by -D, or will be stderr. In either case, not appropriate here. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson Message-Id: <20220417183019.755276-3-richard.henderson@linaro.org> --- target/hexagon/translate.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index b6f541ecb2..98f1452cad 100644 --- a/target/hexagon/translate.c +++ b/target/hexagon/translate.c @@ -874,12 +874,6 @@ void hexagon_translate_init(void) opcode_init(); - if (HEX_DEBUG) { - if (!qemu_logfile) { - qemu_set_log(qemu_loglevel); - } - } - for (i = 0; i < TOTAL_PER_THREAD_REGS; i++) { hex_gpr[i] = tcg_global_mem_new(cpu_env, offsetof(CPUHexagonState, gpr[i]),