From patchwork Wed Apr 27 04:39:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 566746 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6886:0:0:0:0 with SMTP id m6csp4181304map; Tue, 26 Apr 2022 21:41:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxF4QvALshHPa6uVj7lA0qUUPMRzV+atmFvDjw8t2F0iHCzkbEvi9Ljq7dnO2LTtqN1MY9z X-Received: by 2002:a0c:8151:0:b0:42c:2329:91a0 with SMTP id 75-20020a0c8151000000b0042c232991a0mr18887326qvc.107.1651034473672; Tue, 26 Apr 2022 21:41:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651034473; cv=none; d=google.com; s=arc-20160816; b=pfYAkZ2HxWvcqT4qhCn6I1lhcFv5NTDXJrBZRYc+Ufo+Dznu6VSOnkz9Gi9eph90s8 0EfWbBx3rTBZG7S4s8IcRZQUKG4KxIz3ZqQf81YdxqsL7uiCd92RkBiFNurVs4zttupM D89g87VLFKqiGYQax0ncr2hRPDX5NpzX2XD9sgu31lDwAsvsVcudfIqBrGJxBgNMDp7l nMFAjsJnseM06p5RMtQ7XpThqk1wZRY6KIEV/gLv/Bk4yLgk6Jg/mWgHpHTjBD2mVDgP EWv9qMRo+TLMVD0bS/M9zL+NZZJB5rR65K9uoLocJ3y2QBTY8vPXpZw/Ih7m+TyQiMeT 8rFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=NRYF+Ra7iYksoyhTCV0mNo+OicYLHFeWp8iuqZeYmls=; b=bKFtCbmDTRmEGrcIDvHuQ5bffFOti/ueDdMMMuL4MNyTntGGsPQ0W7qQRhES6eQ2uw 3g5kE4G2kwhAH/gmPgE5mVMByLR2XzclirgCx8BskwN75DHhsHZ3CQ2iAbbWYq6sDVwT oQrOpPZQwkUpxC9I28ElnnDABlHN4l9wAOFe/UZeVj8clmKBjYh5wTmO847t3kzR/TZZ 8WhsOKXO1W9XjyGRQA4TUa9RpzOK1pGFcc0Io/yzv9ue+ocmGTukfjqGQPXuUe3LKJo8 T5A6DpxcE4RF0+0yG3WqCgmvEXIsD5bHoJHpGPiKRZjQaPG1VWSmlAmgLfaBJ7UEvESL piRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=n7xxUqpF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id im6-20020a056214246600b0044bdfe660f8si87745qvb.494.2022.04.26.21.41.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Apr 2022 21:41:13 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=n7xxUqpF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:48276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njZUH-0001Ip-5n for patch@linaro.org; Wed, 27 Apr 2022 00:41:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njZSx-0001IR-1N for qemu-devel@nongnu.org; Wed, 27 Apr 2022 00:39:51 -0400 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]:34482) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njZSt-0007SO-EX for qemu-devel@nongnu.org; Wed, 27 Apr 2022 00:39:49 -0400 Received: by mail-pg1-x52f.google.com with SMTP id z21so556261pgj.1 for ; Tue, 26 Apr 2022 21:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NRYF+Ra7iYksoyhTCV0mNo+OicYLHFeWp8iuqZeYmls=; b=n7xxUqpFJ3DQeo68209tgAQSatM8OP+ppHOMQSb6Mfw4ZtQXuKWaOtRCtb5hCErxj0 J9rHwIUbrVPUNXOKuDD2VV+jJdboHdQ9D/mJ3NJENqnuu8Nk1FePYGbYmTESe/0Kp3sl 1K9wop/GoEW4AL4Q4q7KiQW9am6UZnnlg3IdLDnF2cUOoaVvXw7Va4v11nLAmlwdudM/ UgXDOxdxj66KJ2pVdbkGO/GfBtu2DlM0JrscJqwZXhnBtjcsnYbdD6RSt/JTQb7dmsTB DIY1gU1rsPU4Jfspg4EKLrlX4xIMSyOgHMCOdFkd55Hg6H0pLGM8Pgezc/MuJaW4DeIN NlAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NRYF+Ra7iYksoyhTCV0mNo+OicYLHFeWp8iuqZeYmls=; b=EhVQ5sXXMvQiH9E3ElNH2n8MenO4njZbnSG9DTmkfK6XcqJYR3u3hwuY1vqaJXwX82 52VaATcw4LFC0sW/fXwXUMyQY1mTSPG50a9BAXlK4jsHe3xaYkVBcV17jn2q1tBdnwn/ pxwgRuCrM1YtgkgD7AXIGvXrg4ndivP/rVNsIZVd0jSnVtwJUTI9us1W3FEQARNBMgoR VIXjR3DPg02X8Z7F5OUEPe8LFnA3cQ4QaYQe3LjPqxnOBA60mRYZLQJy19Byn4keImD2 H1q2TXzKJVfr595J+El4EpuHyqccyWakvTxDkCENhR89QkXe0FN++djq+hpvUM83xzu7 x4gg== X-Gm-Message-State: AOAM5320XFTt95DbXf/FXxSKtYNDqTd7pDXHBEHqxY4dauEhMJ901t3M /C+XPgHF+fIWD6SImpdlUp1Y/nrFClsjnQ== X-Received: by 2002:a65:6093:0:b0:373:9c75:19ec with SMTP id t19-20020a656093000000b003739c7519ecmr23146630pgu.539.1651034386201; Tue, 26 Apr 2022 21:39:46 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id f16-20020aa78b10000000b0050a81508653sm16875632pfd.198.2022.04.26.21.39.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 21:39:45 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 3/6] target/i386: Suppress coverity warning on fsave/frstor Date: Tue, 26 Apr 2022 21:39:39 -0700 Message-Id: <20220427043942.294654-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220427043942.294654-1-richard.henderson@linaro.org> References: <20220427043942.294654-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::52f; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Hedde Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Coverity warns that 14 << data32 may overflow with respect to the target_ulong to which it is subsequently added. We know this wasn't true because data32 is in [1,2], but the suggested fix is perfectly fine. Fixes: Coverity CID 1487135, 1487256 Signed-off-by: Richard Henderson Reviewed-by: Damien Hedde Message-Id: <20220401184635.327423-1-richard.henderson@linaro.org> --- target/i386/tcg/fpu_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/tcg/fpu_helper.c b/target/i386/tcg/fpu_helper.c index ebf5e73df9..30bc44fcf8 100644 --- a/target/i386/tcg/fpu_helper.c +++ b/target/i386/tcg/fpu_helper.c @@ -2466,7 +2466,7 @@ static void do_fsave(CPUX86State *env, target_ulong ptr, int data32, do_fstenv(env, ptr, data32, retaddr); - ptr += (14 << data32); + ptr += (target_ulong)14 << data32; for (i = 0; i < 8; i++) { tmp = ST(i); do_fstt(env, tmp, ptr, retaddr); @@ -2488,7 +2488,7 @@ static void do_frstor(CPUX86State *env, target_ulong ptr, int data32, int i; do_fldenv(env, ptr, data32, retaddr); - ptr += (14 << data32); + ptr += (target_ulong)14 << data32; for (i = 0; i < 8; i++) { tmp = do_fldt(env, ptr, retaddr);