From patchwork Fri May 27 16:47:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 576508 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:8607:0:0:0:0 with SMTP id bb7csp803855mab; Fri, 27 May 2022 09:49:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx5IxNT2YvRcAhICokGXvCu0hbk6dS9v4key18WhkQkz7S33/SFnSBRwS+138e821AntMBN X-Received: by 2002:a05:620a:a9c:b0:6a3:8411:6c78 with SMTP id v28-20020a05620a0a9c00b006a384116c78mr18190604qkg.689.1653670180662; Fri, 27 May 2022 09:49:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653670180; cv=none; d=google.com; s=arc-20160816; b=lXJANG7QuOLU2SFpf/a1sM22tZNlKjYbHRUfpiDKjBwyUziJ2PaJvlVk4P6wfVTjr0 DF+LZ1MraVFWRz+18+AOfXUuXwVPE4RdT0+ngqqQFIt3TkseH6T5bgifr5x8Q7UrF4Hj VoPfixIlOEq4830NVIU1NJllaJkrMHxup4+tfuI3nGDtTsCWnQqny41IUgvceLOiOd2E lyda27ieBZLLN85tou6EdDmNRO5xzOdC57+7qt/g+8Swp5LSptRB8wXQ3YX4WHntzKao Vj8z7XLBZomhNxQJwvacb96f2lI/cDywbRixl4avnqfo+PkiVtfT4rJqdB3jLR464IGO tmOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=mCzaU+JrOI2uB5gjGXQ6lDaHwnlMpGfIPzqc07MdKqM=; b=ROGQu3+TOHhCQFTw3Eztz/TvQgDWqjyyDxlyUGu4jsdfTE9k/R13TaWMjEFU/Ioueq JztCv6cMGIlj9hKvaVVFfEyqegJ2sixGqjmeuOsMrPA6YK+CgxovLcSmX+EKLeQrwOQ1 I4Q16Gtm/naif99mwObeEr9nvL/YD9hXRk84MG/u64LX36xdQJXolIeJ5/dMsUR17FYq cIqHrGpPq/4g8Mu234bSzf460X7z44OhpJe4ycsdUnjxGaeZs9Har0V7src/OAYWjS5G fgk/eQESuzh/rMoyu5QkPusCmrEy+vkM/koaDuzUqICX8qgZK8tZ+C4dbPE0D7Z5lIIR h0WQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="EPjKqx/M"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a8-20020a0562140c2800b004622a2cd4c2si2493979qvd.66.2022.05.27.09.49.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 May 2022 09:49:40 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="EPjKqx/M"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:39540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nud9g-0001MK-9A for patch@linaro.org; Fri, 27 May 2022 12:49:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52822) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nud8J-0001Ir-Aq for qemu-devel@nongnu.org; Fri, 27 May 2022 12:48:15 -0400 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]:41801) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nud8H-0005Nr-Py for qemu-devel@nongnu.org; Fri, 27 May 2022 12:48:15 -0400 Received: by mail-pf1-x432.google.com with SMTP id p8so4774294pfh.8 for ; Fri, 27 May 2022 09:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mCzaU+JrOI2uB5gjGXQ6lDaHwnlMpGfIPzqc07MdKqM=; b=EPjKqx/MU/ieambM1J14JB9lO9dxRYulwb8Sl/kSACBXKKWfh1gO20pmO2lpJ3xH6t MWyZntcuSTQmYA445ndSKmUn5ubFlXIZZUXYDRFM69Xnht1A7MkEJcguBCZd0fVNSgAh v7RqQf+6ptCFuuXF/k4SW+O7I1+ccZMcifqecGgyT3b7LY1g/d28n1vf2L9N92gI4OaI e/XA+6nqcKfmsfzNDvj7fv/XcMcaJCKQlvl+8djnTZDccys/jIC4alHPiXmLhy+MhdGE TGolE7iUDvyH/c5v3COSYkfOcEl/psaVjZQCPPQ0MwzpgB3rVE3PSI/RJu+D1ANn+zd6 3L7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mCzaU+JrOI2uB5gjGXQ6lDaHwnlMpGfIPzqc07MdKqM=; b=urukG6g34XhtA7BIei0ScoFUkY4Qjv2kVFjRTgfoLkyjV2giv2EvvohuMh1WLdbEyL lEkeEUEsl0WEVIsOpqMFPUKrKHg7kBLlhFBaJayjknV0i/fPr20jdzHHfqAfe9JzZbI7 D83HLFQRh23QAxy0LJ/Qz8NJZMVOaBEJN+Iy9Z5stzb3ldrhpG8gaFwpfcscUUavag9D YE75mr8c7uVlr0Q49TjjGCPLRJIFm1lm2MwipD/p4+Cp2QlbbvhD3xyEB8NROpFQBD2M Bt1WR3Fkp07JUVVd9CcL4DZHRv3GVhDn/aWAVsnkDxGPPiUfKgEZIVCL7+ri3UlY5UsY CrPQ== X-Gm-Message-State: AOAM5309CaLmuVGUVbkBWb+uDeQR++Sd0FXAUEkl/YaHJCMGjlLUdFww ZalNdGg4wxRHE8QLV9DlwuvNV6SjOU2lWA== X-Received: by 2002:a65:404c:0:b0:3c6:4018:ffbf with SMTP id h12-20020a65404c000000b003c64018ffbfmr38437520pgp.408.1653670091474; Fri, 27 May 2022 09:48:11 -0700 (PDT) Received: from stoup.. (174-21-71-225.tukw.qwest.net. [174.21.71.225]) by smtp.gmail.com with ESMTPSA id j11-20020aa7928b000000b0050dc7628133sm3861420pfa.13.2022.05.27.09.48.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 May 2022 09:48:11 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: laurent@vivier.eu, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v5 03/17] target/m68k: Fix coding style in m68k_interrupt_all Date: Fri, 27 May 2022 09:47:53 -0700 Message-Id: <20220527164807.135038-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220527164807.135038-1-richard.henderson@linaro.org> References: <20220527164807.135038-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::432; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Add parenthesis around & vs &&. Remove assignment to sr in function call argument -- note that sr is unused after the call, so the assignment was never needed, only the result of the & expression. Suggested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson --- target/m68k/op_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/m68k/op_helper.c b/target/m68k/op_helper.c index 2b94a6ec84..0f41c2dce3 100644 --- a/target/m68k/op_helper.c +++ b/target/m68k/op_helper.c @@ -408,11 +408,11 @@ static void m68k_interrupt_all(CPUM68KState *env, int is_hw) break; case EXCP_SPURIOUS ... EXCP_INT_LEVEL_7: - if (is_hw && oldsr & SR_M) { + if (is_hw && (oldsr & SR_M)) { do_stack_frame(env, &sp, 0, oldsr, 0, retaddr); oldsr = sr; env->aregs[7] = sp; - cpu_m68k_set_sr(env, sr &= ~SR_M); + cpu_m68k_set_sr(env, sr & ~SR_M); sp = env->aregs[7]; if (!m68k_feature(env, M68K_FEATURE_UNALIGNED_DATA)) { sp &= ~1;