From patchwork Thu Oct 6 03:10:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 612848 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp1192799pvb; Wed, 5 Oct 2022 20:20:20 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4gMigMBJ3i8/x1viiv+0rCXY4HVe1IgFlIH48Hfw37ra/z8CJNuGm2KrVoYNcaYSQ7P+Or X-Received: by 2002:a05:622a:296:b0:35d:52ee:2af3 with SMTP id z22-20020a05622a029600b0035d52ee2af3mr2100830qtw.72.1665026419880; Wed, 05 Oct 2022 20:20:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665026419; cv=none; d=google.com; s=arc-20160816; b=eT2rPvWEa6MDrCS0owqS6PhVpkqEzMOMgxqZ07uxULmRcd2ts5OXngOCz7gpMn8XyI 1Y+2Rfypf8VhYZbdC59FIjmCR00vx1uYgQGY7cikdSScGx+c8d4H0bZPM2fPui8/r9j0 VOQvJ92EYr9dxs3jZgFvYs9rveUriSsv8UZhV0ffpBRbx1IIuvpbL9MzPvveUGpsOts/ MOrvPQUN23XZo6QxACgNgge9dIreqwUfzyDBplGsCPlT+oxdrwT/syukIjh5aXnSIf/4 FGbreoTCBXq//J1xxHFSNWfNQj42D5p0FW+glF1flm0IIc9KMuPsYlpf0hFPz4x54xyK Hszg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=l6SGav8RwfN0SUmZjlh737YnehkKC7vRUo7OZ2eZuSg=; b=g3zSyY6523XelaNjXgRzHzS63HiBf18qnKZa/vTdS189v3Sl0V8quWI7G1efMLkxdv Rtt3zbWL6L3DCUaWyNLH0uIpkWLqETKrFTSoDHIK6+woCK1U6ve5+a7W0HVY5QxeY157 7cy5VMmKjSk0IEon7MmX9KslqfmgT6KXJzE92Fk5++f+DzpuUqewadYeaPk2d+rE83Go oHhO5tdMCW81TadXErk/yYwbfTqPRYdHVb5PHZIRdLsfYD4nmCzm9YomottraGYjrZPu SSspRoXyNK3I8OXX7a7pOQtpYda8gnt7YWJU11ytN2req39lEvO0A4OANn8+LSNVL0RA wxcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZCGKacZF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id bk9-20020a05620a1a0900b006b94a6bf76esi7031751qkb.239.2022.10.05.20.20.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Oct 2022 20:20:19 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZCGKacZF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:52474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogHQp-0000Dd-Bv for patch@linaro.org; Wed, 05 Oct 2022 23:20:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogHIG-0005Ri-Ka for qemu-devel@nongnu.org; Wed, 05 Oct 2022 23:11:28 -0400 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:37501) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ogHIE-0006xB-Th for qemu-devel@nongnu.org; Wed, 05 Oct 2022 23:11:28 -0400 Received: by mail-pl1-x62c.google.com with SMTP id d24so545193pls.4 for ; Wed, 05 Oct 2022 20:11:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=l6SGav8RwfN0SUmZjlh737YnehkKC7vRUo7OZ2eZuSg=; b=ZCGKacZFlV0nBNaXAAxZOkmNJDH1XuNpmYDaZWSm937Tzz86KQuWHqtCVxWtAbl/1m LrWYcG1pUrMQrRYQjm8AmX8ZD+9swhLAADQSA5LxEyzp21RamkWQnAS1oW0+VRWKvn44 JNy+LvhYY4k0rSiPCBAQeW/Z7ug7q3qtWRh5hehFsc2U1bB/o/RSEqdAUJBbYsy3FO4f lwRPDlRIDfKfG7KhbzK5CCd/QN+b2T9VA7I9hgkjmkDM7A1cnOu0ua6ELEkIs48qr2j/ D9axU++FVh1G1zuROgaPZIMU1a3QZcjkEWTkXid0NJjwhQuecSAHb4BOf9Erz+AErX4Y zomA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=l6SGav8RwfN0SUmZjlh737YnehkKC7vRUo7OZ2eZuSg=; b=s0/wUsj2WZYi6AwkCCfhrSXAgyY4teiCXzj9PRhQ2xRptuE2huzrY4BpRuBRleZ+E2 qmBN9Q9qzUb5ZLxxHmtWEINTJZLKdEaLLuQSL7cAoI0jOEb5pFgb/Vpxdo5RX33nN7qc yQx4l4BoLx3hFKMGWD32h979yFAym8f2QepjEXYL/VrZHuGoWmoAWwrwUEGlxHukCaiu RVSRYA2H44Xod3rnItTH9pIMH/+D7iUivFO3ZP1JTemv8vaHinrFBf1/G/G72fIj6zl2 VwnClrK4aDCB/WY4kc/P5/yPX0K7mkxJLODD0r2xwWY7/skKAwmrh243J6WV1JaZ2t57 53xA== X-Gm-Message-State: ACrzQf3akMQphT1Xhtj5xE3wsUWUepTTFUvbuhEfLf0B6yAW6MbH8r7P WpbmvOYir1sJJY2Ml2oty3IfQVWXx5gZPw== X-Received: by 2002:a17:90b:1b52:b0:202:c1e3:7e9f with SMTP id nv18-20020a17090b1b5200b00202c1e37e9fmr8276005pjb.68.1665025885579; Wed, 05 Oct 2022 20:11:25 -0700 (PDT) Received: from stoup.. ([2602:47:d49d:ec01:9ad0:4307:7d39:bb61]) by smtp.gmail.com with ESMTPSA id u128-20020a627986000000b0056281da3bcbsm58360pfc.149.2022.10.05.20.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Oct 2022 20:11:25 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: alex.bennee@linaro.org, laurent@vivier.eu, pbonzini@redhat.com, imp@bsdimp.com, f4bug@amsat.org Subject: [PATCH 08/24] accel/tcg: Remove duplicate store to tb->page_addr[] Date: Wed, 5 Oct 2022 20:10:57 -0700 Message-Id: <20221006031113.1139454-9-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221006031113.1139454-1-richard.henderson@linaro.org> References: <20221006031113.1139454-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" When we added the fast path, we initialized page_addr[] early. These stores in and around tb_page_add() are redundant; remove them. Fixes: 50627f1b7b1 ("accel/tcg: Add fast path for translator_ld*") Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée --- accel/tcg/tb-maint.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/accel/tcg/tb-maint.c b/accel/tcg/tb-maint.c index 9af5cb49e0..7f4e1e1299 100644 --- a/accel/tcg/tb-maint.c +++ b/accel/tcg/tb-maint.c @@ -405,7 +405,6 @@ static inline void tb_page_add(PageDesc *p, TranslationBlock *tb, assert_page_locked(p); - tb->page_addr[n] = page_addr; tb->page_next[n] = p->first_tb; #ifndef CONFIG_USER_ONLY page_already_protected = p->first_tb != (uintptr_t)NULL; @@ -461,8 +460,6 @@ TranslationBlock *tb_link_page(TranslationBlock *tb, tb_page_addr_t phys_pc, tb_page_add(p, tb, 0, phys_pc); if (p2) { tb_page_add(p2, tb, 1, phys_page2); - } else { - tb->page_addr[1] = -1; } /* add in the hash table */