From patchwork Mon Oct 10 17:28:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Michael S. Tsirkin" X-Patchwork-Id: 613762 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp2120255pvb; Mon, 10 Oct 2022 10:39:54 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7GifouBNjVlb7FL5wkPfooNikq+hFyxSZ3oh06PpvBLUXVUZNmlyD3qLxh3r0cQDjyCnzX X-Received: by 2002:a05:622a:14d3:b0:35c:ccc3:eb2c with SMTP id u19-20020a05622a14d300b0035cccc3eb2cmr16335638qtx.77.1665423594223; Mon, 10 Oct 2022 10:39:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665423594; cv=none; d=google.com; s=arc-20160816; b=JH8pOMJn7JnXarSeb4m/WmRXqZsvLlrdPxQDh+VLclc2tU78BpgcD0dboe7cqd4jHy JK6MGEyxHHcWqEz7dO0xH5MDQdMHlHksFY4sviB6nUiX6A+60eSLjq0rJxnlvOJkgyUh UrVkb1mHXQx8s5Z4X0uhxu2XXI2EJxSiQ62B2W3U7UKJS7Tytnl1M18QuDIcKo+iTzcN duRU3xp5s+bgC42jYteq23hM3jg/2OpxnfSnPVK3fiSJd2spLEVk832PVwVNxKYChz9t PETXdjo/E+NCfzWSeIjM7JT2qnuA9gKuk1mUT002ox2aEPR0YGoPqeiROnq0RIIm080t pkVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=hp8rI8ket4FMKJXRLF3s2rnrP8cE0bwnLy3PoafAv4c=; b=S4FTnl1h2eI9G+svXDp1z2t+JGkwwzCrLIzAqmji4CnE2okRzpeGBgZ4EX8BrSUjq7 VuRbk3vkUeZywmvgmWADyHMEcP/WVIqRRLvApyr3KX9qhxbfVolhkvCrKqf1z8ld2Ese HOLruR94hPHQYrLT2Q8YpxdJqww2+KKXAbDVZTlFwPEtxX1jxVbGaW57PER4rulhf+0c HiKuYB6uuDGqLbeVI3TEI3Y0Og5pVGvABMTuBQTlsWZ0rJxeaGZdKB9QaBxeMKc8uw8+ 5LpAnmJs6b5C5pi0VyLtm0utK/HyNKAWEvLBc0nmkyXLl5p6MZOiaceViSq40v28fDH6 XfAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DUYSiBSt; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id z28-20020a05620a261c00b006ea4e9101b4si4671559qko.510.2022.10.10.10.39.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Oct 2022 10:39:54 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DUYSiBSt; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:40246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohwkr-00080D-MV for patch@linaro.org; Mon, 10 Oct 2022 13:39:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohwaI-0007nA-PJ for qemu-devel@nongnu.org; Mon, 10 Oct 2022 13:28:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:43208) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohwaD-0006PP-In for qemu-devel@nongnu.org; Mon, 10 Oct 2022 13:28:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665422932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hp8rI8ket4FMKJXRLF3s2rnrP8cE0bwnLy3PoafAv4c=; b=DUYSiBStfh3SHd8+QzXKHxloKBX91ht9u/W3Qkm4qE6XLhj1jsrgeMC/L8XybIQES1OI11 n0p4/Y3w1dxnITsRlTjMwRvdEiBo0SmwNNNz3Dap37foRUC4qFc0jKEpUaOZHC/UwBYSDw kvoBZhK+Hd8E4dcv26U/SrekHgu8j/o= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-556-9lUqtD4aMJusv94hmeqVxg-1; Mon, 10 Oct 2022 13:28:51 -0400 X-MC-Unique: 9lUqtD4aMJusv94hmeqVxg-1 Received: by mail-wm1-f69.google.com with SMTP id t20-20020a7bc3d4000000b003c6bfea856aso477717wmj.1 for ; Mon, 10 Oct 2022 10:28:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hp8rI8ket4FMKJXRLF3s2rnrP8cE0bwnLy3PoafAv4c=; b=ira3tzNat8Zs4DAr0+7q9yos3U0nMs5I2p1jhkR5RQQli42Km09jgiVGNgEPF2gj2K 7lI7c16Pz+bMAsYDh6OnruzcciQEf7wcT1oa9KwxVLCR0t5AdZeOPKeMWWzftm5bYeOT h3vl3BPucpGPMg/WhCE1UPbRmzRyeS0dzs4M+Q/if7jHtxWBg9koDRGzs/m4qw5x8nrz wMW8zE2i0hdrfc8rmsoC74pQzarPDFiSihxpkRF0BxzAuK2+263v6UerXwWHgdNj6jfW UGifTbeUwc0DjhV+lWnj4CPoc8SGkA1whmDFQekLNMyt+0YKa9T5yCbvN1vQBRqX0sww fhUw== X-Gm-Message-State: ACrzQf2C5UJJvvOz3vDXHIsjfU7UG8XKy5HZya8dNAPpVTNTKqOtj+NY TPeSDaox8ef5u/2t7XL0C59iitxaCY/D3Zv3gY9BxkUO7rRjQVpSd2z6eC5Rkgul6CuH2NhsGil KWTYiEijZ6u4MKg3JffX6t0g8ZfyCSZUswsMZwZPSoPurqIG97jKQs40NOiFz X-Received: by 2002:a05:600c:46c6:b0:3b4:cad4:7d3e with SMTP id q6-20020a05600c46c600b003b4cad47d3emr20971370wmo.78.1665422930123; Mon, 10 Oct 2022 10:28:50 -0700 (PDT) X-Received: by 2002:a05:600c:46c6:b0:3b4:cad4:7d3e with SMTP id q6-20020a05600c46c600b003b4cad47d3emr20971342wmo.78.1665422929768; Mon, 10 Oct 2022 10:28:49 -0700 (PDT) Received: from redhat.com ([2.55.183.131]) by smtp.gmail.com with ESMTPSA id m29-20020a05600c3b1d00b003a1980d55c4sm914699wms.47.2022.10.10.10.28.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Oct 2022 10:28:49 -0700 (PDT) Date: Mon, 10 Oct 2022 13:28:46 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Cc: Peter Maydell , Alex =?utf-8?q?Benn=C3=A9e?= Subject: [PULL 02/55] include/hw/virtio: more comment for VIRTIO_F_BAD_FEATURE Message-ID: <20221010172813.204597-3-mst@redhat.com> References: <20221010172813.204597-1-mst@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221010172813.204597-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Alex Bennée When debugging a new vhost user you may be surprised to see VHOST_USER_F_PROTOCOL getting squashed in the maze of backend_features, acked_features and guest_features. Expand the description here to help the next poor soul trying to work through this. Signed-off-by: Alex Bennée Message-Id: <20220802095010.3330793-6-alex.bennee@linaro.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h index db1c0ddf6b..9bb2485415 100644 --- a/include/hw/virtio/virtio.h +++ b/include/hw/virtio/virtio.h @@ -24,7 +24,12 @@ #include "qom/object.h" #include "hw/virtio/vhost.h" -/* A guest should never accept this. It implies negotiation is broken. */ +/* + * A guest should never accept this. It implies negotiation is broken + * between the driver frontend and the device. This bit is re-used for + * vhost-user to advertise VHOST_USER_F_PROTOCOL_FEATURES between QEMU + * and a vhost-user backend. + */ #define VIRTIO_F_BAD_FEATURE 30 #define VIRTIO_LEGACY_FEATURES ((0x1ULL << VIRTIO_F_BAD_FEATURE) | \