From patchwork Fri Nov 11 07:40:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 623684 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp616453pvb; Thu, 10 Nov 2022 23:44:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf5VRUfqh/6+0meWE9Ba9MGZm+QIM+WPQI+aC+e2b2p4UjxMtJYRB0f7Ezho/GjFJ/RdwgN3 X-Received: by 2002:a0c:e84b:0:b0:4b4:4f9:1776 with SMTP id l11-20020a0ce84b000000b004b404f91776mr951293qvo.116.1668152659498; Thu, 10 Nov 2022 23:44:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668152659; cv=none; d=google.com; s=arc-20160816; b=KERlnvEiz0EqfDXBr6SO8uVKfFFo9/ES4UszjqaKIa6CmjPWZfL9jcHKm4Q7pWEp9d 0lts834RN9a5bwRzLeRfddC86M/890cILELeVSX78wJHI3JxCzdQY9VRJqqrbAyrzSz5 zcrS90eME0OgHdPaHALbtHUn7haS9Z3RIrblUAcv6igUUw4y74Cb6QBjQ8pYDNKHXZjU sZLQDmkUckPZlAFUHl1aCK34GpWtjphQQU/9gs2EqEhbS1ni3XOUGKPV1FuHj2Ft4aW7 sV3hYaQAL6DklAoLSqBiQSkfNCXJuV6Z8SOiRZqIBRTJAEWxFRb67LLjiIKTfvBBERzc nK/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=9Jpwsf6+2qL2tkXL6kSO45vZ0jCGkW11UYFWxCwtIV0=; b=oAIqiz7JOiXhjWf+YGBX65vZLA+TGgFB4aE1ZUIwWm8Kx52MP/W2G2qi9uK8EAeOfe a7vfwNJLwIPG2YzOu4W1xCs5epTWA/EE0D5Je5Cb9a8IydYtkSvaR83J5hnjB/k9Dg3U 5ZIv0CKeUbkPSwKTm1QlTu5kSg+B3v3C8wBkgXmeiLBnIhggyPUpOKUXKAkiwYnrp+nj j1gG51EOkVJFjns2qxneTeDV6knS1B1MZBivdaYTpQpZD3H1qi9TrJI9ho5EfG26HT7V JZtjxJW62FGfLrJFcVxWNNfK2zBJaNeEVheDnXwXwIBr0+H0Xy8l6cm5HN/K3PeQYxZ/ WjpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=lU2qM7dN; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c20-20020ac87d94000000b003a5504674e8si743496qtd.278.2022.11.10.23.44.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Nov 2022 23:44:19 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=lU2qM7dN; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otOgJ-00070L-Qe; Fri, 11 Nov 2022 02:42:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otOgA-0006pm-Kn for qemu-devel@nongnu.org; Fri, 11 Nov 2022 02:42:23 -0500 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otOg6-0000HE-V3 for qemu-devel@nongnu.org; Fri, 11 Nov 2022 02:42:22 -0500 Received: by mail-pj1-x1032.google.com with SMTP id z5-20020a17090a8b8500b00210a3a2364fso7370936pjn.0 for ; Thu, 10 Nov 2022 23:42:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=9Jpwsf6+2qL2tkXL6kSO45vZ0jCGkW11UYFWxCwtIV0=; b=lU2qM7dNR1+4xpakBfuq3ZgoiSDPrl5YlXaipkyrSiwuRD4baI71swryBYPKpilltA 6lxVBE+xDQMhaU5fofoQp6BDWngucwwQVyw52pO5IGtSSCS1Hq7NbyOL0ZYyt/YEQH72 26RGGAYbilidsRVj7T7AG644zkusCMfi/+t5tAC1BbvGWj66DWKF+8Rj05iVsNh21oDV mhAOStB3HxWLShja2bvcQ9ZLtHAGxGDsJZkiG320QvSYwsiLRlIzJ+gl5W21M1cIZzsz Z2YUzm6rS/tRyslggb0qDPi8uNB44ajkk+yKhEbWbx1Y3BG0Croad817cUUUGYxDQXNd V+rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9Jpwsf6+2qL2tkXL6kSO45vZ0jCGkW11UYFWxCwtIV0=; b=RNW37tkB8uaXuSmhr4pnyqoDKkcdTsdseMt58UN7GgG13eHSiE/FkG+7/aCZPbTt6n GA2Y3bmWU0Q59mHT2JR1/B7G/wIqRYDqz1dFFzsDpu2CLVJCqUUyGqiw6v4uoeWe0C/8 Qp4nh/0ZrTKLEeS39YrBJQiTRUTcDvL/BbbmxsnRRbHeuOKFicPSTeTZudoOGYpkLBu5 kV1LKQ+qoxgVqN9HipfL1MT5mwwUtpMfW52MSV9BdWHgpcw7cVkFkjPZbWu8HwoWl3W9 If3UiO5Amy9etI6ppLx131wwe3kstk283AsRCw/Yraw1y9jltkvzJjPoitnR3syr1rgw bW9Q== X-Gm-Message-State: ANoB5pkHbEskzZkbMBcfEcKZB+S8Cky7wzag+l0yblkq0hw1+PsJcd2v vu/y8eO3Qdg8xSvIXqkZYR1zNnfYKw0VRABX X-Received: by 2002:a17:903:3286:b0:187:a98:7eea with SMTP id jh6-20020a170903328600b001870a987eeamr1122854plb.109.1668152537327; Thu, 10 Nov 2022 23:42:17 -0800 (PST) Received: from stoup.lan (2001-44b8-2176-c800-0aef-59aa-1faf-7e61.static.ipv6.internode.on.net. [2001:44b8:2176:c800:aef:59aa:1faf:7e61]) by smtp.gmail.com with ESMTPSA id o15-20020a170902d4cf00b001754fa42065sm976069plg.143.2022.11.10.23.42.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 23:42:16 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH for-8.0 v3 30/45] tcg: Handle dh_typecode_i128 with TCG_CALL_{RET, ARG}_NORMAL Date: Fri, 11 Nov 2022 17:40:46 +1000 Message-Id: <20221111074101.2069454-31-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221111074101.2069454-1-richard.henderson@linaro.org> References: <20221111074101.2069454-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Many hosts pass and return 128-bit quantities like sequential 64-bit quantities. Treat this just like we currently break down 64-bit quantities for a 32-bit host. Signed-off-by: Richard Henderson --- tcg/tcg.c | 33 +++++++++++++++++++++++++++++---- 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index c5f8f4ac2c..11948256f2 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -685,11 +685,22 @@ static void init_call_layout(TCGHelperInfo *info) case dh_typecode_s64: info->nr_out = 64 / TCG_TARGET_REG_BITS; info->out_kind = TCG_CALL_RET_NORMAL; + assert(info->nr_out <= ARRAY_SIZE(tcg_target_call_oarg_regs)); + break; + case dh_typecode_i128: + info->nr_out = 128 / TCG_TARGET_REG_BITS; + info->out_kind = TCG_CALL_RET_NORMAL; /* TODO */ + switch (/* TODO */ TCG_CALL_RET_NORMAL) { + case TCG_CALL_RET_NORMAL: + assert(info->nr_out <= ARRAY_SIZE(tcg_target_call_oarg_regs)); + break; + default: + qemu_build_not_reached(); + } break; default: g_assert_not_reached(); } - assert(info->nr_out <= ARRAY_SIZE(tcg_target_call_oarg_regs)); /* * Parse and place function arguments. @@ -736,6 +747,18 @@ static void init_call_layout(TCGHelperInfo *info) case dh_typecode_ptr: layout_arg_1(&cum, info, TCG_CALL_ARG_NORMAL); break; + case dh_typecode_i128: + switch (/* TODO */ TCG_CALL_ARG_NORMAL) { + case TCG_CALL_ARG_EVEN: + layout_arg_even(&cum); + /* fall through */ + case TCG_CALL_ARG_NORMAL: + layout_arg_normal_n(&cum, info, 128 / TCG_TARGET_REG_BITS); + break; + default: + qemu_build_not_reached(); + } + break; default: g_assert_not_reached(); } @@ -1653,11 +1676,13 @@ void tcg_gen_callN(void *func, TCGTemp *ret, int nargs, TCGTemp **args) op->args[pi++] = temp_arg(ret); break; case 2: + case 4: tcg_debug_assert(ret != NULL); - tcg_debug_assert(ret->base_type == ret->type + 1); + tcg_debug_assert(ret->base_type == ret->type + ctz32(n)); tcg_debug_assert(ret->temp_subindex == 0); - op->args[pi++] = temp_arg(ret); - op->args[pi++] = temp_arg(ret + 1); + for (i = 0; i < n; ++i) { + op->args[pi++] = temp_arg(ret + i); + } break; default: g_assert_not_reached();