From patchwork Mon Nov 28 16:41:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 628996 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp3098584pvb; Mon, 28 Nov 2022 08:42:18 -0800 (PST) X-Google-Smtp-Source: AA0mqf4dpzwEDrfvO2zuG55fKK5+iGuHsKB6j+ma+bUFDrXcTphDQkfbPY+RnCqqhzb99dFIzwFy X-Received: by 2002:a05:6214:3a01:b0:4ac:8568:12bb with SMTP id nw1-20020a0562143a0100b004ac856812bbmr48947086qvb.35.1669653738266; Mon, 28 Nov 2022 08:42:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669653738; cv=none; d=google.com; s=arc-20160816; b=uvao4JRSQOBIn+KrWp99n26Ff0PfqwyNdKz1SfKrFtmG2tcpq8OAq1hFlpOYJgw71l bs64XC45R9Jven4vPLThGDQbXNSJk1RTnumrmD7ZFUWg7QBaF/1uf/BHqqXHqBAYMtFC BPdlGm+qXR+i3iSqcM0Jhz393AFEYQiu8uhROlqfafju/9avqfQIbEkPnum1WU9cWWQ+ RxfWIZA7pVeodtyLtK5GYA2XLwPNX55Iu4VwxXiCwX3ey+LWjn2iBRQS036PZY0MJ8Wg DHWKDveIFnFcsz/iUft0JRJgb/KOVcCYKuWlraRQLfIEHPx2XfAGWmI6Or/tj3CzUucx B7gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=KhIII14ps0nVEVy/8MmJ4sK/j5eE6abuNMevIXJoNIs=; b=TDvTc4RWOtYwpNFCBzS5VfAmM2fIxvyL5uWXFdu7RgqOVNCRKJmLu6xuqfK+sG2E2u sTrNkR9zCgDfsIIuiB2YKLaoOv4UcjjZZvJLhinhL5n8plv2UCf+G6p5f+DIPYi6chWC /e+WDwjB3Jh1pgVSYdzlGRjP0qx54Xa0ikkxnKmN6/Ii+JAy0y1fqwLY1tlkM0fGeohl Cw+fWiY1WWQ5x4sg0qRk6ZRVWhqjzfdscSOgQB7nMmd5QWwKkd+mPzBBmYUzsZROMr/v xOAOwo4BAH8DytVcwEKkDZKImBig5aajgngeilWHlzMf9XK1NpelfCp35YMX/cRHsyR0 +zzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F+GdSezC; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id j21-20020ac85515000000b003a52649329asi6777697qtq.286.2022.11.28.08.42.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Nov 2022 08:42:18 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F+GdSezC; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozhC9-0005gp-Jt; Mon, 28 Nov 2022 11:41:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozhBz-0005ek-7X for qemu-devel@nongnu.org; Mon, 28 Nov 2022 11:41:16 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozhBw-0004oY-35 for qemu-devel@nongnu.org; Mon, 28 Nov 2022 11:41:14 -0500 Received: by mail-wr1-x429.google.com with SMTP id v1so17774859wrt.11 for ; Mon, 28 Nov 2022 08:41:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KhIII14ps0nVEVy/8MmJ4sK/j5eE6abuNMevIXJoNIs=; b=F+GdSezCZ2NzoGKt88dnbT1O33cHzKPhUKDNBv3kM7FUe8eOWCGhyFcqnDkCjMBpxS Kt7UcGNnVuf7NC7PRDX3l1f7IA0FgBgWX3R3KDqVwDV9LQrxtXwbsWG7sqAVm4RUUMmY 0Fdyqcs7RMmcAuHOqqlMOLXX52bcMDBWdGY8VL+x4nYvX+FO19lxYzpI/fLW2VswDeQx dzanrYtazIq4tsp3W95Q2eVl/yEqwQN6ytD18+uqU2NLYHilzUDdzLBX5aCsjUoobk+L BKUBYxe04rEhhFZ2jppd4KG2xsbQ54E4LUHGccFS89gse/quaHCw/OsFsJ4pj4HOlZ5u /GiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KhIII14ps0nVEVy/8MmJ4sK/j5eE6abuNMevIXJoNIs=; b=2y7rRvwhUm0KqCeRZyqoUdjKL+OVTe5T2B2ZuXaTO2wirJ9nvAwiB+9ZcrEWwV84mX Xn58U9nVyMeFBFvlXMh106MMfZ2sANGBgr6PN/yWP+ucU+BjRupkXTDQRVds3TUGBBl5 6bSrC1oFQuYDTDoeNAE3FAUZ/hmoEDYKL4Ff7gMwRFJ6XYLsOfWZ9w3YO/KWl3nX1dcZ mbfdJ13opJ2Ii8q+5dNyTzWf5FudimrCCgeZiWmepFhaDcEynz1BrBr2CkIHI17KpFcF Gf3QNWWd6yjEiAV/hiMrUMsvnM0R2eW+pcoMF4oCnLVbRRizAjGBoul/25REvobIAtfs h45A== X-Gm-Message-State: ANoB5pnQIDSVfDKFbcG0f94QH3Emj7MfQ5503/atqrJL8tULw65cELkx J6D5QABaiGKKh9+PPm0QBIfmkg== X-Received: by 2002:a5d:6646:0:b0:242:164b:c58a with SMTP id f6-20020a5d6646000000b00242164bc58amr4176182wrw.45.1669653668634; Mon, 28 Nov 2022 08:41:08 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id e9-20020adff349000000b0023657e1b980sm11360381wrp.53.2022.11.28.08.41.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 08:41:07 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 12C031FFBB; Mon, 28 Nov 2022 16:41:06 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: slp@redhat.com, mst@redhat.com, marcandre.lureau@redhat.com, stefanha@redhat.com, mathieu.poirier@linaro.org, viresh.kumar@linaro.org, sgarzare@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?= , Thomas Huth , Laurent Vivier , Paolo Bonzini Subject: [PATCH v3 3/7] tests/qtests: override "force-legacy" for gpio virtio-mmio tests Date: Mon, 28 Nov 2022 16:41:01 +0000 Message-Id: <20221128164105.1191058-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221128164105.1191058-1-alex.bennee@linaro.org> References: <20221128164105.1191058-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The GPIO device is a VIRTIO_F_VERSION_1 devices but running with a legacy MMIO interface we miss out that feature bit causing confusion. For the GPIO test force the mmio bus to support non-legacy so we can properly test it. Signed-off-by: Alex Bennée Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1333 --- tests/qtest/libqos/virtio-gpio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qtest/libqos/virtio-gpio.c b/tests/qtest/libqos/virtio-gpio.c index 762aa6695b..f22d7b5eb5 100644 --- a/tests/qtest/libqos/virtio-gpio.c +++ b/tests/qtest/libqos/virtio-gpio.c @@ -154,7 +154,8 @@ static void virtio_gpio_register_nodes(void) QOSGraphEdgeOptions edge_opts = { }; /* vhost-user-gpio-device */ - edge_opts.extra_device_opts = "id=gpio0,chardev=chr-vhost-user-test"; + edge_opts.extra_device_opts = "id=gpio0,chardev=chr-vhost-user-test " + "-global virtio-mmio.force-legacy=false"; qos_node_create_driver("vhost-user-gpio-device", virtio_gpio_device_create); qos_node_consumes("vhost-user-gpio-device", "virtio-bus", &edge_opts);