From patchwork Fri Dec 30 00:01:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 637857 Delivered-To: patch@linaro.org Received: by 2002:a17:906:1189:b0:7d5:1b03:224a with SMTP id n9csp4174472eja; Thu, 29 Dec 2022 16:23:11 -0800 (PST) X-Google-Smtp-Source: AMrXdXvyHluyo+Kb4quqAcF1l67J1oMfrehqgXRNaIuqQLHxZNERWDYWy2CMWnLhssoA70t/VfuD X-Received: by 2002:ac8:518f:0:b0:3a8:137e:2963 with SMTP id c15-20020ac8518f000000b003a8137e2963mr41801401qtn.20.1672359790839; Thu, 29 Dec 2022 16:23:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672359790; cv=none; d=google.com; s=arc-20160816; b=XZbt/to6jKL7YO+B0Px5E1Q7z/nZsVBoMXCnUTJyvUKmOHQ2w+UBBtCPtOO3mRfqhS J2E23gw53G20x+cR5CgvWmHKbnuEkMQ/AX2P1E/ZZVMmoAUC3JWWRbabk7HOCen+iLvZ j6Va4/F4+oqkiHt3AAm6tFftbjlCJqm9j4m3h81ggMvjS/Bx9Miv1BlTnl1W+COF0aQu kzlbGTdkR9BLnec5Mb2itIJdtWjvWifUfXPYdymVb9qb7l9AaOSCPCPI9TFUZut7owvh e2cGdZn3t5sIpSLpThMUaQYYt4K349dXfGkplOaFC+HYnlTrd5KEQihf8hnDLlZdUkf1 +fow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=l2AYVfOigGNcWueyGcFEAyNre3J/WgPqkB4M4xEOEGc=; b=BYOVl+0Qj7msdeHoo+a0fMaIBaJPVTe00KZ3fQWGYDEkz798kkaCm5K9RvgsLTWTIS JDBxcQx8iSW+b4+Va3oCMhcWHw0HTyFHMgznf8XN4DiNxSNtRJi0QNKrFSkZLn2t+a5Y TOadYQ0Tugkp+kXbSOjfUDGwRo0byBucUXiUVFANz5OExR2nnH1P30ahLFTjRFg+XaOW NPeianmsX+TOlKbN4r9KcIjSpd73i1WU2O3Beq2hfNoKbYleF1xdIM8mBWAuIa5QGANH EddnwCkHKt0YPQFNZvS0+GbvYWT9BbCxulX5qT0q+PQg5OpbYpfJgLuHNz7ihBcFqENq x8dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sIHIfodG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c10-20020ac8110a000000b003a6a4dd14c7si9056422qtj.442.2022.12.29.16.23.10 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Dec 2022 16:23:10 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sIHIfodG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pB2r7-00030C-8m; Thu, 29 Dec 2022 19:02:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pB2r2-0002xJ-Iu for qemu-devel@nongnu.org; Thu, 29 Dec 2022 19:02:33 -0500 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pB2qz-0002fG-9o for qemu-devel@nongnu.org; Thu, 29 Dec 2022 19:02:32 -0500 Received: by mail-pl1-x629.google.com with SMTP id g16so10694430plq.12 for ; Thu, 29 Dec 2022 16:02:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=l2AYVfOigGNcWueyGcFEAyNre3J/WgPqkB4M4xEOEGc=; b=sIHIfodGP7l5hxQJ/RX0cdNtQwZCFEFhML628ZQj0AMZWbD8mflMl+79F8UtCoRQxE VZiJ68vnzHSZz2xEIBciFWyettPWj8pw/q0iOatQ1g12RwHyNILV/Cts3NZq2eHhGEcQ NsPPMltFhN5y6yD24zMKvbiBiKR2DEDo5N7iUgg10C7U7oBy2rf+QU2fQPik2Yj7pJeF apSDdBdW1+FZFvNOaiL/kmgonNz6TpeFQHMD6G1nBSRBh61RLuz7tE+GpilwiHKw0uTr XdrEsQrpvxIFCHyTxWHKRGW7qxxhX5lrsEUz/yzXdhIkPGTgim58dfMn6WKtLU5cs6pv 7dvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l2AYVfOigGNcWueyGcFEAyNre3J/WgPqkB4M4xEOEGc=; b=Tr4XsbKrGej+tvqknHbD+ghYrkteHk4yh1CoDfyJIYhQDSXGYLB2Y/oLVNIwBwNr1X hyFAgrPEQNsX/L0x4TKgTLT4St0m9dK35xld+x6phWZiC6kirQObXNeYdVeW+Pa19bV3 owy71QmJnZzKPrE4u61u3uc9q1MvciCUwurNIYnfbs9pDc30SUSO1O+srrpq5cMloPbH U7S2hWwRR6CTYwSLMxXVQRYzGbrkPTx/mc/ISILRssGpactiJt1TO6iaFJQsLCZFcBO8 csHKXmqeh6low4uDbFKxZRVPliQX77Cvl6uPfsHLhrbA4dKw+hXW9nS43VtFg2g0RXkt wfrQ== X-Gm-Message-State: AFqh2kqFK/m9iGLwBFJlHIlrMHNjYrCesl/N91AXqN5+pCFjh3PqLcMw bXzB4vZFlpOXC2OOXr5tvzPEsdP1YUt5iCQu X-Received: by 2002:a17:902:c943:b0:192:a3f5:18eb with SMTP id i3-20020a170902c94300b00192a3f518ebmr4349762pla.10.1672358545939; Thu, 29 Dec 2022 16:02:25 -0800 (PST) Received: from stoup.. (76-14-210-194.or.wavecable.com. [76.14.210.194]) by smtp.gmail.com with ESMTPSA id j14-20020a170903028e00b00192849e1d0asm7343953plr.116.2022.12.29.16.02.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Dec 2022 16:02:25 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Wilfred Mallawa Subject: [PULL 03/47] tcg/s390x: Fix coding style Date: Thu, 29 Dec 2022 16:01:37 -0800 Message-Id: <20221230000221.2764875-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221230000221.2764875-1-richard.henderson@linaro.org> References: <20221230000221.2764875-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé We are going to modify this code, so fix its style first to avoid: ERROR: spaces required around that '*' (ctx:VxV) #281: FILE: tcg/s390x/tcg-target.c.inc:1224: + uintptr_t mask = ~(0xffffull << i*16); ^ Reviewed-by: Wilfred Mallawa Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20221130132654.76369-2-philmd@linaro.org> Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index 33becd7694..f1d3907cd8 100644 --- a/tcg/s390x/tcg-target.c.inc +++ b/tcg/s390x/tcg-target.c.inc @@ -802,9 +802,9 @@ static bool maybe_out_small_movi(TCGContext *s, TCGType type, } for (i = 0; i < 4; i++) { - tcg_target_long mask = 0xffffull << i*16; + tcg_target_long mask = 0xffffull << i * 16; if ((uval & mask) == uval) { - tcg_out_insn_RI(s, lli_insns[i], ret, uval >> i*16); + tcg_out_insn_RI(s, lli_insns[i], ret, uval >> i * 16); return true; } } @@ -1221,9 +1221,9 @@ static void tgen_andi(TCGContext *s, TCGType type, TCGReg dest, uint64_t val) /* Try all 32-bit insns that can perform it in one go. */ for (i = 0; i < 4; i++) { - tcg_target_ulong mask = ~(0xffffull << i*16); + tcg_target_ulong mask = ~(0xffffull << i * 16); if (((val | ~valid) & mask) == mask) { - tcg_out_insn_RI(s, ni_insns[i], dest, val >> i*16); + tcg_out_insn_RI(s, ni_insns[i], dest, val >> i * 16); return; } } @@ -1231,9 +1231,9 @@ static void tgen_andi(TCGContext *s, TCGType type, TCGReg dest, uint64_t val) /* Try all 48-bit insns that can perform it in one go. */ if (HAVE_FACILITY(EXT_IMM)) { for (i = 0; i < 2; i++) { - tcg_target_ulong mask = ~(0xffffffffull << i*32); + tcg_target_ulong mask = ~(0xffffffffull << i * 32); if (((val | ~valid) & mask) == mask) { - tcg_out_insn_RIL(s, nif_insns[i], dest, val >> i*32); + tcg_out_insn_RIL(s, nif_insns[i], dest, val >> i * 32); return; } } @@ -1279,9 +1279,9 @@ static void tgen_ori(TCGContext *s, TCGType type, TCGReg dest, uint64_t val) /* Try all 32-bit insns that can perform it in one go. */ for (i = 0; i < 4; i++) { - tcg_target_ulong mask = (0xffffull << i*16); + tcg_target_ulong mask = (0xffffull << i * 16); if ((val & mask) != 0 && (val & ~mask) == 0) { - tcg_out_insn_RI(s, oi_insns[i], dest, val >> i*16); + tcg_out_insn_RI(s, oi_insns[i], dest, val >> i * 16); return; } } @@ -1289,9 +1289,9 @@ static void tgen_ori(TCGContext *s, TCGType type, TCGReg dest, uint64_t val) /* Try all 48-bit insns that can perform it in one go. */ if (HAVE_FACILITY(EXT_IMM)) { for (i = 0; i < 2; i++) { - tcg_target_ulong mask = (0xffffffffull << i*32); + tcg_target_ulong mask = (0xffffffffull << i * 32); if ((val & mask) != 0 && (val & ~mask) == 0) { - tcg_out_insn_RIL(s, oif_insns[i], dest, val >> i*32); + tcg_out_insn_RIL(s, oif_insns[i], dest, val >> i * 32); return; } }