From patchwork Mon Feb 27 05:24:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 656851 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp2184598wrb; Sun, 26 Feb 2023 21:50:34 -0800 (PST) X-Google-Smtp-Source: AK7set9tqjxDXRIJwRyUH/rr00h2+ddXGgVoXxNAuqeeOyzW6J4Gk9Zy7eLC7e8XXy9yucy8ZIkl X-Received: by 2002:ad4:5bae:0:b0:56e:957f:dd5f with SMTP id 14-20020ad45bae000000b0056e957fdd5fmr39496358qvq.50.1677477033881; Sun, 26 Feb 2023 21:50:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677477033; cv=none; d=google.com; s=arc-20160816; b=l/kocvd1gCRoPGyuE2h/TkzgkBqIJV3tQfOBYdNMRLifpEr6xOMQq6ui2PpBl9go4w vG++j+0ROqOpMg/W8k2+MLt7XOFPVGUI21XzUqOWPqC/tIS2xNZjJLA6Bl9ZrGXdUKy4 dZ2f8YfBwqe2kfEoWGXRkB6c07WVBtUrTD2/h2icpd75OlvgMI2GSkxFB/DXT7Dmz9kP OJ62DYDGyB5Za82Rj+rOjjEAUAvt2vbZJiKCyJ95tFb3BPW6d0gQKogm8c9XKl2MbMfb F9sObcU4L5ddY+A0OpipMrv+d1JSJGKDfKwg8kKZgMEm6WKOdJEZUhTHC6Re0YAB0Ywj Z5BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=niO44Co69efms0IVc6R/k9jlve0XAcHkzZjYqfu6blc=; b=YHi02kPhWGNC45XBcccdQxhfZKAH9ZJ2fnyyEmFfjw3qXKo+M5G5gEYHMbF31o7XZE Pbb16QJVkXs+3C+3s5ShoZt+lLQQVxRuH1JrIvzA/G92z5DI19cvWHw1zfoG1l7K7ETX hQkayFGNHE3xAMceTCeIA6zEEAbgLpvkzrXflv1PoIST4rop4f+/+i6Q6QUd+HZ5aFjJ XuV+meQqDb1v26MMSSxWJYSF+Vin62LBxEUh46Zf8Xk4oWd9g7o7hEfQNQ+A1uG/trjg 2/c7zuMxR6l4kpzn2p+1MU/2HGG4CMBGrBY8c6osK6k/2SVSd0+fX62BkTU2P8845ttl BF1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sb+cdnbY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id b30-20020a0cb3de000000b0056e93ac474bsi5645273qvf.82.2023.02.26.21.50.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 26 Feb 2023 21:50:33 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sb+cdnbY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWW6R-0005l6-3Q; Mon, 27 Feb 2023 00:31:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWW5b-0003FS-5a for qemu-devel@nongnu.org; Mon, 27 Feb 2023 00:30:21 -0500 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pWW5Y-0000OJ-MP for qemu-devel@nongnu.org; Mon, 27 Feb 2023 00:30:18 -0500 Received: by mail-pj1-x1033.google.com with SMTP id h11-20020a17090a2ecb00b00237c740335cso3984081pjs.3 for ; Sun, 26 Feb 2023 21:30:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=niO44Co69efms0IVc6R/k9jlve0XAcHkzZjYqfu6blc=; b=sb+cdnbYsOXgn8MD7Pzyjou0dbcOJ6CQcx+rfjPxAQP/dUd5Mv5R+jTjMsYx2nee7t ruA8Ohas6ptT3YroJF0m97t5clvLSotWXkWElrGlMM8iQVfSdoEdp2U3+++1K0YYFBGP 0tkR6oAMS+KjaMuoyxRC18LNqfaZrNvs+oYOYiJyxqL6ZNo4brXKAnERH+MiMhypEEAi rDOS7P9PgVefPFAPPIBObDLZIU2hqziB53qQX8rNrBeIo89U2KFwewRssXL5fC1CXl2V BPwA4DVyRg0Zwti0K1Y7RN4vYuSzvJYzQg5zbS3ltY7f9JBQd7VnuL1ZFWwHHP/Edtxy R/VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=niO44Co69efms0IVc6R/k9jlve0XAcHkzZjYqfu6blc=; b=1hIqXCBJMuGTczmadU/Uy3d32wPg+y2oZ4QadjAc3M4mTN8FY62Rmt9KRMUT/ueKi0 dDF5hE67VbrFWXDSvK4ozqpQfbtgdEieIhHYz9Y0k+dkFqC1XgN3c6vDpVL0Mv5ANQMg G75TLRb3/nqQfHF9q+LRt/LvYqnL+EYsqAN0oAix+4q0oR+7N5XE6B4B0z7Nv4WS+FEA jbfrc4JxP/Y/g+VGZDd2mbdB7e1fSGCEmmi2rmGp1k/FF3m5DDxhKivEbK8llzQrWd15 U/QNyNwoBk0hT1P37LRgWWKRgQi5S1UuXVfsEwyfbhMKeV4qG8O8lXXUntfFE58rGZcT k5wQ== X-Gm-Message-State: AO0yUKXKZmM5wOM5Kk8T1lxne1tjrYsAeR+VNt3gJ6LgfDj183V/iXt+ BoRvgUKrE9/YMNitFHMw33HhphTjDnLAXzw8KXM= X-Received: by 2002:a17:90a:e7cc:b0:230:86de:f390 with SMTP id kb12-20020a17090ae7cc00b0023086def390mr24155960pjb.42.1677475815415; Sun, 26 Feb 2023 21:30:15 -0800 (PST) Received: from stoup.. (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id v4-20020a17090a520400b002369e16b276sm5172926pjh.32.2023.02.26.21.30.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Feb 2023 21:30:14 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, jcmvbkbc@gmail.com, kbastian@mail.uni-paderborn.de, ysato@users.sourceforge.jp, gaosong@loongson.cn, jiaxun.yang@flygoat.com, tsimpson@quicinc.com, ale@rev.ng, mrolnik@gmail.com, edgar.iglesias@gmail.com, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 45/76] target/mips: Fix trans_mult_acc return Date: Sun, 26 Feb 2023 19:24:34 -1000 Message-Id: <20230227052505.352889-46-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230227052505.352889-1-richard.henderson@linaro.org> References: <20230227052505.352889-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1033; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1033.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Success from trans_* subroutines should be true. Fixes: 5fa38eedbd ("target/mips: Convert Vr54xx MACC* opcodes to decodetree") Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/mips/tcg/vr54xx_translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/mips/tcg/vr54xx_translate.c b/target/mips/tcg/vr54xx_translate.c index 3e2c98f2c6..a7d241e4e7 100644 --- a/target/mips/tcg/vr54xx_translate.c +++ b/target/mips/tcg/vr54xx_translate.c @@ -53,7 +53,7 @@ static bool trans_mult_acc(DisasContext *ctx, arg_r *a, tcg_temp_free(t0); tcg_temp_free(t1); - return false; + return true; } TRANS(MACC, trans_mult_acc, gen_helper_macc);