From patchwork Mon Mar 6 00:39:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 659194 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp1575317wrb; Sun, 5 Mar 2023 16:52:18 -0800 (PST) X-Google-Smtp-Source: AK7set8xxcJEU7kaGD+ZPPvV4HddMUYcfqcSxhK59dMlS7xyDaFBWYbgXTW/VDeDLYZaBy4wxdzd X-Received: by 2002:a05:6214:21ac:b0:56e:b5a1:b521 with SMTP id t12-20020a05621421ac00b0056eb5a1b521mr14749947qvc.51.1678063938240; Sun, 05 Mar 2023 16:52:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678063938; cv=none; d=google.com; s=arc-20160816; b=TRQCtajVTvi5pYVfrSAs4xzcjGWIMMNqdEAiWSqiCUvtIzQaHb0TdUftldkDh15MqE rAueWr8kLe3KL1xZxnar/bceC7PCDAT7u12t6Xutpb8TeVMaDL71tHbdRlgpxNp3Wv5s ZTngJazTeCydPS1dwYK4sZQrc+d4ZY0v5InXDTqakfHVURZeyZoILTATHsiPVHVRwtTd KfsCAVLjDQCz2ln8DzKf/ukLYhqwvuZKJMhHRec8fnSDo+3G8bD6zTG6R12cByUMxf3w YnSy/XkPBtOoYcdGCWWs5cCcq/UCo6hMRN4MBiIfS7n3XN/OcLoOF0rpgDkhDILhVWSm K6/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=gqHQnIXQuU7WvdYNKGsRU9JQ3hqtUaL0pq9Pxj9E05Q=; b=rWVuAV6wDlfvbmIamhVub+VP7rdMj3m+5u3NL1etQ28cJ6fayUdnOm4ZG9Xj9EMGqu kAxr2KbEYNFh50zodJR7eJYwZSs2pYRUpqlZEAdIVFfnVU3Pd+65t5dHDzR8//73CDi6 6i0yiD86OFUbdYdBae11W+iDWaoAcYGktgdrkcUtcDEX7i+EeWcgfOrdR0YDO5eqo0T3 vZsl8YppeJhQQ1vGmtDG8Qopfidzgon96Vxa69kSu9oA/Wy0d4CE4knDxw8cO5ra6B+I RaYMRteN0qEpIuoGGzFqQPF6t00SjczXexK0B/grZ9UHIA76xg9ZXdi9/pJk0eB2cb/5 NjPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ojfJIsfY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id o6-20020a0c8c46000000b005351bc2cf4fsi5808632qvb.535.2023.03.05.16.52.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 05 Mar 2023 16:52:18 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ojfJIsfY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYyxA-0000oo-IA; Sun, 05 Mar 2023 19:43:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYywy-0000V4-Hh for qemu-devel@nongnu.org; Sun, 05 Mar 2023 19:43:42 -0500 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYyww-0007Do-Pr for qemu-devel@nongnu.org; Sun, 05 Mar 2023 19:43:36 -0500 Received: by mail-pj1-x1032.google.com with SMTP id p3-20020a17090ad30300b0023a1cd5065fso7422174pju.0 for ; Sun, 05 Mar 2023 16:43:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678063413; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gqHQnIXQuU7WvdYNKGsRU9JQ3hqtUaL0pq9Pxj9E05Q=; b=ojfJIsfYgicUnWablUxM7L1Hhq76jjH8mly6DLIsEHbsRH9GTLCpVTjfGx7elG5jUQ anmRoNdwfsm6bORNNm09ZWA9CyhUV3i/69s0ALaI8WeRRR6k2i40FbYi+k3kYb5GYQQw g7QJPoSf8vNyusBowvzsjFcPIF/ejXJLbIh7dQFm1lTakqhT1oErQ9VqUfAQueywjJU4 5HUaW6FC+TbA9MGy3RN+Yotq5B3eq79D5M1aOwweel3NWa9Ch+SwwnE30f4vsbFE/18p OLAfq6eP0b+oiL1BLFrC6i0abORdEvVxuK4ymupXJIUPTLGpS9q0VVryhitvv45XqSrH f0xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678063413; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gqHQnIXQuU7WvdYNKGsRU9JQ3hqtUaL0pq9Pxj9E05Q=; b=B1ryZIvAsjM848rvMQGydsk0KbYwOM/ywCfYKXOq8NGEVpyujS2lzxlw89IQXQcms2 E5Gi6w0RuzZpioW1RL6Yc14GpcgqrpzeArOoPviL8Vh4vxqpuvtmmqGYOaVa3cu9Z7Xr 0YXLi7DHt+SJYeLQI2rvwk0D9rH8Evq67DpzmwNiQT3eP3cKa4Pq+KygxHVvhRBYVW2t s1BTnQrZ5m4otqCoZ/fmLzb4WwAvp86Hl5iVNvEdP/E3TJjWfRQmuSHlZysJZmQZ7cXd /JmoVFjp78Xh4jr3mX+mus/jErPwpiinfRsDyer6Khzk0w3lGPSzj2VLKsUYsXfEgWES GJoA== X-Gm-Message-State: AO0yUKW1GqfgwbQ0w31uT0Os34TiNRmucKNeHp21z/xNkHckH3MyryLl rt2UXLkne3sE0w0qOIT/UroyvunOcPoQs9yH/bPBVw== X-Received: by 2002:a05:6a20:6a1d:b0:c7:6f26:ca0 with SMTP id p29-20020a056a206a1d00b000c76f260ca0mr10018653pzk.54.1678063412813; Sun, 05 Mar 2023 16:43:32 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:87cc:49bb:2900:c08b]) by smtp.gmail.com with ESMTPSA id x52-20020a056a000bf400b005895f9657ebsm5045726pfu.70.2023.03.05.16.43.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Mar 2023 16:43:32 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Song Gao Subject: [PULL 41/84] target/loongarch: Drop temp_new Date: Sun, 5 Mar 2023 16:39:11 -0800 Message-Id: <20230306003954.1866998-42-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230306003954.1866998-1-richard.henderson@linaro.org> References: <20230306003954.1866998-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Translators are no longer required to free tcg temporaries, therefore there's no need to record temps for later freeing. Replace the few uses with tcg_temp_new. Reviewed-by: Song Gao Signed-off-by: Richard Henderson --- target/loongarch/translate.h | 3 --- target/loongarch/translate.c | 21 +++---------------- .../insn_trans/trans_privileged.c.inc | 2 +- 3 files changed, 4 insertions(+), 22 deletions(-) diff --git a/target/loongarch/translate.h b/target/loongarch/translate.h index 6d2e382e8b..67bc74c05b 100644 --- a/target/loongarch/translate.h +++ b/target/loongarch/translate.h @@ -32,9 +32,6 @@ typedef struct DisasContext { uint16_t mem_idx; uint16_t plv; TCGv zero; - /* Space for 3 operands plus 1 extra for address computation. */ - TCGv temp[4]; - uint8_t ntemp; } DisasContext; void generate_exception(DisasContext *ctx, int excp); diff --git a/target/loongarch/translate.c b/target/loongarch/translate.c index 2a43ab0201..f443b5822f 100644 --- a/target/loongarch/translate.c +++ b/target/loongarch/translate.c @@ -85,9 +85,6 @@ static void loongarch_tr_init_disas_context(DisasContextBase *dcbase, bound = -(ctx->base.pc_first | TARGET_PAGE_MASK) / 4; ctx->base.max_insns = MIN(ctx->base.max_insns, bound); - ctx->ntemp = 0; - memset(ctx->temp, 0, sizeof(ctx->temp)); - ctx->zero = tcg_constant_tl(0); } @@ -110,12 +107,6 @@ static void loongarch_tr_insn_start(DisasContextBase *dcbase, CPUState *cs) * * Further, we may provide an extension for word operations. */ -static TCGv temp_new(DisasContext *ctx) -{ - assert(ctx->ntemp < ARRAY_SIZE(ctx->temp)); - return ctx->temp[ctx->ntemp++] = tcg_temp_new(); -} - static TCGv gpr_src(DisasContext *ctx, int reg_num, DisasExtend src_ext) { TCGv t; @@ -128,11 +119,11 @@ static TCGv gpr_src(DisasContext *ctx, int reg_num, DisasExtend src_ext) case EXT_NONE: return cpu_gpr[reg_num]; case EXT_SIGN: - t = temp_new(ctx); + t = tcg_temp_new(); tcg_gen_ext32s_tl(t, cpu_gpr[reg_num]); return t; case EXT_ZERO: - t = temp_new(ctx); + t = tcg_temp_new(); tcg_gen_ext32u_tl(t, cpu_gpr[reg_num]); return t; } @@ -142,7 +133,7 @@ static TCGv gpr_src(DisasContext *ctx, int reg_num, DisasExtend src_ext) static TCGv gpr_dst(DisasContext *ctx, int reg_num, DisasExtend dst_ext) { if (reg_num == 0 || dst_ext) { - return temp_new(ctx); + return tcg_temp_new(); } return cpu_gpr[reg_num]; } @@ -195,12 +186,6 @@ static void loongarch_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs) generate_exception(ctx, EXCCODE_INE); } - for (int i = ctx->ntemp - 1; i >= 0; --i) { - tcg_temp_free(ctx->temp[i]); - ctx->temp[i] = NULL; - } - ctx->ntemp = 0; - ctx->base.pc_next += 4; } diff --git a/target/loongarch/insn_trans/trans_privileged.c.inc b/target/loongarch/insn_trans/trans_privileged.c.inc index 40f82becb0..56f4c45e09 100644 --- a/target/loongarch/insn_trans/trans_privileged.c.inc +++ b/target/loongarch/insn_trans/trans_privileged.c.inc @@ -243,7 +243,7 @@ static bool trans_csrwr(DisasContext *ctx, arg_csrwr *a) dest = gpr_dst(ctx, a->rd, EXT_NONE); csr->writefn(dest, cpu_env, src1); } else { - dest = temp_new(ctx); + dest = tcg_temp_new(); tcg_gen_ld_tl(dest, cpu_env, csr->offset); tcg_gen_st_tl(src1, cpu_env, csr->offset); }