From patchwork Mon Mar 6 00:39:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 659184 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp1575161wrb; Sun, 5 Mar 2023 16:51:47 -0800 (PST) X-Google-Smtp-Source: AK7set98L+DNH1dV3qvmg+WxXqH4ZD4ivOjC4yCiXYDd6PztxEXLhgwB05ZbjB2rMsW7Fx+OMyei X-Received: by 2002:ac8:57cd:0:b0:3b9:b619:42c1 with SMTP id w13-20020ac857cd000000b003b9b61942c1mr15162749qta.27.1678063907700; Sun, 05 Mar 2023 16:51:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678063907; cv=none; d=google.com; s=arc-20160816; b=DauQqDPFOsCGu03LykcRWAm+vqxzLK3I41N3qjKX5yUvN5G8tioTPuTHD8yr7h6qsT fM23EkcKZSFLJ0J4mT23DvIm6cGht11kBCGShu8xxnExDaJejEFIC9Z+LPTKWq/iKDms 2h/IhzlQDN222jtHYr6cyFXK1vZcXbbZUFp//fArF2+RvCazm+YiuOw+JwmarSfhqd/r EYEkDUy5rl4fqkBPzF3xV5lf9d05LyOczVMHOhGNTb5ahWbvATipN4CeBi9Whkfhhqf4 TNReyrP0QMcGN9Ne5NPSJ6KKbpEzGCiu3MsPuCPU1MKkMff8gCqitaFycb1JKh0Wu+YI nBZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=sGckcAd8KrkWUx1ApDFxDLHhhOLWQ/0K4f2UW/fGtYI=; b=dYLJvhQyXLkWwhnr90CE+0YH5gXpOePmz7439qx23xYDysgji5P200iMRPDjG8mClm 3BbRvMuBoaVVRRglUY2vT75hxI+sjiJJA9kKZGSeUximLOLRGoU71+3H9Cna+FyGxwcs HtuMH38HlZwmF0M/tgB64jaDwrTEjGbQHYcV+tUZdoo+bxSmPC1BeTIVOQiHRAQPxBko LkNuUmK+/5mnE3S/XF5MH2jK8milTTaZ5ZOODLrlUkWW83VZAPxg0Ix8gpifO7CvYhVu 9GznyToc/whJEY1SOXJtM+mWVnzDnb1I4Tpv/FsA9WnvsUNQCqesW9pzAr5JOjAlC1jm L5kQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=o3DQvBKz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v2-20020ac85782000000b003bfba5e65a7si6244167qta.54.2023.03.05.16.51.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 05 Mar 2023 16:51:47 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=o3DQvBKz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYyyV-0004ox-AY; Sun, 05 Mar 2023 19:45:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYyxn-0002zy-10 for qemu-devel@nongnu.org; Sun, 05 Mar 2023 19:44:27 -0500 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYyxi-0007MG-MK for qemu-devel@nongnu.org; Sun, 05 Mar 2023 19:44:25 -0500 Received: by mail-pj1-x1032.google.com with SMTP id x20-20020a17090a8a9400b00233ba727724so9711265pjn.1 for ; Sun, 05 Mar 2023 16:44:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678063459; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sGckcAd8KrkWUx1ApDFxDLHhhOLWQ/0K4f2UW/fGtYI=; b=o3DQvBKz4ut2Hdx63/d48retH+AL/a3mQkvTzFeHgPhGZ/HFw4AXMskVPhPRAZAkQ0 6uPNtjRd/5zu2apF4AsLwsf7OMxco+KqpR3chL4Qxs2ek2Q5/oOeG1O9ay2FXIpq+2KR cNQCeieWt0brBK2SIBDQ5UzmaRdHPK38wYxWdcusZjJsS/UStT3lNf4Z1iydrgPIKeUd ZKsa7uLHlzYyYa7x6DkQnJAG+2ztsEyRECnVVQEGNUOZcMhwfoymBPLEVc2bEMb7hYBZ fGLfikFob62omf+Sud8cWXdXdDlJM4T4bN0SlT2AaNA03bgctaF3wJCVJXv/l4bvINN8 hFMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678063459; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sGckcAd8KrkWUx1ApDFxDLHhhOLWQ/0K4f2UW/fGtYI=; b=xPRVSLlVZaCivTo9F/vLKQSCyV8b/EGj7juUtm61VXewwdWDKvnXFn79OL4vQmGgZ0 bKFIlLKcIacMdEVuOCIRa8u697f1BQ4+UFhBoQhAJu5Dy4cnxQxYmhHsnItKrNkCcKvI sTHKgAfe8GUF/GXu+VSaPcFz6y036+I5NPS41tX/7Ux+9XWsMNOfv//yM1EtBNAMTGkn At96Mo6nBvu10aR2OxgVNtsI0Tt765v/BvQQL12CKMf0Z5Qv11QYnFdx6xiu2kVLI1Kt PTnaY8m8QdbizXzcjd0VjJEVXd7tJP3+kvuzweqAgB4QJqUrCBj5MCfBoDYfPM8E7IMQ 5Lng== X-Gm-Message-State: AO0yUKVBlvsl/Zk4p8M/kKHEC4+i51ONxT74qFGaIeCt412hsJgCFj5K b8nsj4gmtMOHVzNgtQp8+af9NHVqUfeUs42Mk/g5yA== X-Received: by 2002:a05:6a20:3954:b0:cb:af96:ace7 with SMTP id r20-20020a056a20395400b000cbaf96ace7mr11535880pzg.46.1678063459308; Sun, 05 Mar 2023 16:44:19 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:87cc:49bb:2900:c08b]) by smtp.gmail.com with ESMTPSA id x52-20020a056a000bf400b005895f9657ebsm5045726pfu.70.2023.03.05.16.44.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Mar 2023 16:44:18 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Taylor Simpson Subject: [PULL 71/84] target/hexagon/idef-parser: Use gen_tmp for gen_pred_assign Date: Sun, 5 Mar 2023 16:39:41 -0800 Message-Id: <20230306003954.1866998-72-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230306003954.1866998-1-richard.henderson@linaro.org> References: <20230306003954.1866998-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The allocation is immediately followed by tcg_gen_mov_i32, so the initial assignment of zero is discarded. Reviewed-by: Taylor Simpson Signed-off-by: Richard Henderson --- target/hexagon/idef-parser/parser-helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hexagon/idef-parser/parser-helpers.c b/target/hexagon/idef-parser/parser-helpers.c index be979dac86..760e499149 100644 --- a/target/hexagon/idef-parser/parser-helpers.c +++ b/target/hexagon/idef-parser/parser-helpers.c @@ -1743,7 +1743,7 @@ void gen_pred_assign(Context *c, YYLTYPE *locp, HexValue *left_pred, "Predicate assign not allowed in ternary!"); /* Extract predicate TCGv */ if (is_direct) { - *left_pred = gen_tmp_value(c, locp, "0", 32, UNSIGNED); + *left_pred = gen_tmp(c, locp, 32, UNSIGNED); } /* Extract first 8 bits, and store new predicate value */ OUT(c, locp, "tcg_gen_mov_i32(", left_pred, ", ", &r, ");\n");