From patchwork Wed Apr 12 11:43:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 672612 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:184:0:0:0:0 with SMTP id p4csp287389wrx; Wed, 12 Apr 2023 04:44:43 -0700 (PDT) X-Google-Smtp-Source: AKy350YEh5KO6RwuVIM8BDUCqKKD8C6t0vz+ADknYRR+P6CZx6x8ewQc2CYKsyRlYLLbU5yO3Ous X-Received: by 2002:a05:6214:23c8:b0:5e9:752:766b with SMTP id hr8-20020a05621423c800b005e90752766bmr25506971qvb.47.1681299883013; Wed, 12 Apr 2023 04:44:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681299882; cv=none; d=google.com; s=arc-20160816; b=iA8/0yTUz2f1aeUoFULrP/pVXCE5/ezADp9arG5lvddp0+GPilUHvBGYXa7crEvWM8 JBeHKuCgn7FUxzI3ww8vgcw2Px0AfABBqWj4Qf9Z2CMJogFcpA5ITdUm3NjNwmi4X3iF Z8ZDaS8zDqGWAx7B/hRJdJsrRzRhPZ9oAbwpB3RPFSB5Ffe/bq36cOqcah6tZq1wGvI2 cDmpnQm7zdI3H/bQI+nxK8n8eROg3xXLYKur8dl8XVbLB655sENuhGqQC34Ef37nJv5g c/9XoWwdym2xyh4jCKjPwaMWpOHEStNooJpoY/OZ826rLl6JNnUiCGBzv4JQuw649Km5 T3gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Zn52Ufb7DRbVaQ81Qm+6XQB/991khVVrBH6/wkfCyPw=; b=Zd9ojrR6WZJukFnSIxzSozqD8/QXZRreITQuk0RRthOpAfUP1EMfqJu4D0ho+/91KE onZWQ4PNG/quUkRhYH1LPQbAXdkDswuNW5FGM0GN+uwMrs+HmQyLRdq6zDAP2kZ1aZvI nQz6kiqWc99Nz0RvUbY5S4b3AqAevRVRQLcNN2RPpi3AAb5MpL27fjXRk4xAebXzGNSk WJ9PlMx8kE5UpRq3oOMoA789SRMoIwo8/mLZhh/dWX1fC3KrVHatgoHWeqrc7YCHOjs5 w/NUdAe/WszUWd8wZirlbkFqPEmPtT1mfvSed+74ix22bFZdXtQUO5IJTlq1s3+nABXl 3VWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tct9DIzA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id jo16-20020a056214501000b005ddc55f5c48si10703718qvb.171.2023.04.12.04.44.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Apr 2023 04:44:42 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tct9DIzA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmYtk-0006aU-Rw; Wed, 12 Apr 2023 07:44:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmYtJ-0004z4-UD for qemu-devel@nongnu.org; Wed, 12 Apr 2023 07:43:59 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pmYtI-0002NQ-Ai for qemu-devel@nongnu.org; Wed, 12 Apr 2023 07:43:57 -0400 Received: by mail-wr1-x430.google.com with SMTP id e7so494456wrc.12 for ; Wed, 12 Apr 2023 04:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681299835; x=1683891835; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Zn52Ufb7DRbVaQ81Qm+6XQB/991khVVrBH6/wkfCyPw=; b=tct9DIzAzD/uENt4eA2Cqn0Fmd8KmINwv3jrPeu7YUoQLVUOVMPtzAs11P6KlHoEBq psbFabdJIBPWD8DQTUYlUO5bBp6p39SwcTmPc665VJgPvKHUuOW+CqMdp8GkU0XJ9oPj 7ul9MXh2162cSexD4qFLsIoMAFyFaVC4ZBRwsAz1P016MjhKtLo95qBEvRVU3AP3CaKX nDJFB10/mTbU4jfLUWHkqxm0ZIcYbCSBiVXXCFptlpFk2L9542vlDyh/zh6bnFMuTR1J P0A7IWrKn80LU++ix5yPdWrYQtInz+oRSBp+3hDDaFa8/fwnedql3nDOcE9P+A5Y7Ev9 z38w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681299835; x=1683891835; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zn52Ufb7DRbVaQ81Qm+6XQB/991khVVrBH6/wkfCyPw=; b=q7CKL8ehhIdCmhydA2w6AKL9fYmpFTf1feAKCCMMb4AMg4OXbNBDHOdUESbj/0LvNC 5YOrMI+1CGrsFFKiZDjm4NGwerASDW2PVmWGm+DKUk6xIiFpxwB9QDK+lCi6qvODDsga zN0T9naOk/MGajOlWGUuzAe6NthLGn9YvuzjRN4CYGB/YQp7tjl7xoZ6zaC9EcEm1/+G mAgv4MNwxXq90Gbv4ts0+Lz4wMjKrkJDL1x4//6c1feivt06ceiqLAGpiXoCy2nHFgok 3IlJO0L7iyZCQ2kdP19dC5FrRebk+IdYuI+1BrsCg5mvlkBI/LMKZb7YGa517q3ynZ/y 3HvQ== X-Gm-Message-State: AAQBX9cKOWZXwGl19s3OtpJZa6vsIdjq0HaxMWCP8dKn8JEho0cn/5bH XBhy9r7ryweJXRCDtfYlvU4++/PXw3kq3WIZEU+q+pJC X-Received: by 2002:a5d:4902:0:b0:2c7:d575:e8a4 with SMTP id x2-20020a5d4902000000b002c7d575e8a4mr9580924wrq.65.1681299835563; Wed, 12 Apr 2023 04:43:55 -0700 (PDT) Received: from stoup.hotel.gast (ip-037-024-010-236.um08.pools.vodafone-ip.de. [37.24.10.236]) by smtp.gmail.com with ESMTPSA id k9-20020a5d4289000000b002d21379bcabsm16980826wrq.110.2023.04.12.04.43.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Apr 2023 04:43:55 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: alistair23@gmail.com, qemu-riscv@nongnu.org, Alistair Francis , Weiwei Li , Daniel Henrique Barboza Subject: [PATCH v7 22/25] target/riscv: Don't modify SUM with is_debug Date: Wed, 12 Apr 2023 13:43:30 +0200 Message-Id: <20230412114333.118895-23-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230412114333.118895-1-richard.henderson@linaro.org> References: <20230412114333.118895-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org If we want to give the debugger a greater view of memory than the cpu, we should simply disable the access check entirely, not simply for this one corner case. Signed-off-by: Richard Henderson Reviewed-by: Alistair Francis Reviewed-by: Weiwei Li Tested-by: Daniel Henrique Barboza Message-Id: <20230325105429.1142530-23-richard.henderson@linaro.org> --- target/riscv/cpu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index 6dc3fdf594..9a2b944990 100644 --- a/target/riscv/cpu_helper.c +++ b/target/riscv/cpu_helper.c @@ -823,7 +823,7 @@ static int get_physical_address(CPURISCVState *env, hwaddr *physical, } widened = 2; } - sum = mmuidx_sum(mmu_idx) || is_debug; + sum = mmuidx_sum(mmu_idx); switch (vm) { case VM_1_10_SV32: levels = 2; ptidxbits = 10; ptesize = 4; break;