From patchwork Tue May 2 13:57:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 678402 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp522608wrs; Tue, 2 May 2023 06:58:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4CMvy4FNnEtJUhig0W8ZA2ZKcslPsybpr/lwmEKd/srYWjLmDveCv/tmH+2zCW7SSGeaRD X-Received: by 2002:a05:6214:e48:b0:61b:62cb:193a with SMTP id o8-20020a0562140e4800b0061b62cb193amr2394310qvc.22.1683035917922; Tue, 02 May 2023 06:58:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683035917; cv=none; d=google.com; s=arc-20160816; b=IYBkpW5Z4/8a6Awt8453vvnjk8HHNT4XKoPO0YhiRslT/vp+4+ggojKCjhiX2z29t5 Jg+m0GdmSH+bFPScVK1aZYIuxigNqe//Hv8LB5zgILWcD69j9Ms7i2cyLuveLaCQ/7N9 zsFDlmON3z/nC5hwGZt9YE0RI8c0ldhpBHxg3wxHLnVcXeLVF9JOVkkXP0GHCgnBIdFR Ir/TmRcylCLVf6+qm5alNQ9f5shc/JrzciPK0yoZZYi/FUwvVGdmBrRKHzatZt7s6tDN ypszXTw/JY+Fky2ShNgWQAGdyeNp5MEhyfMQhFfhnKjy5fm7purxNIySPJqTKTW2rkAM wCfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dfJMs6FCtKRZODwBO9HSA4c3kE+GfezaVHX9yu/D5TM=; b=KCunkvOfyczY5rGqC4n5iK2yU6qO4WT2mgeLTaTpFhM6XPi/VPax/oZ5dknRZxO9Ej s61c0Hr3Enn7nKaKnnj0x4sMER8g/oxRfakp+qBSMhIdiTtjYX+DNgouWxxe9OXO8b+2 7Tra5xPIHK1IbjswQNIAsbAzbiEOln7zP9Uf7/CqSX+pkVfAKls/VTSI00e5hyLOwpa6 /6BKHK/fRmBmj6cR9ApmTHPNFF58iFw+TphDE6JUvhPHElfTFywl2+hp0FKalegRaMrw nSOEJqrVnwerVRDepUIikgNFm31HdTEvXdHLseXlCRwXqPAFXUgpNeKqFYEKVQHU42gg 1sqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=t1t2vSCW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q10-20020a05621419ea00b005ef470bb7c8si18119924qvc.366.2023.05.02.06.58.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 May 2023 06:58:37 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=t1t2vSCW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptqVo-00018K-6m; Tue, 02 May 2023 09:57:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptqVn-000182-6T for qemu-devel@nongnu.org; Tue, 02 May 2023 09:57:47 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptqVl-0003T8-H7 for qemu-devel@nongnu.org; Tue, 02 May 2023 09:57:46 -0400 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3f1728c2a57so38427675e9.0 for ; Tue, 02 May 2023 06:57:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683035864; x=1685627864; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dfJMs6FCtKRZODwBO9HSA4c3kE+GfezaVHX9yu/D5TM=; b=t1t2vSCW4zQx8saFIiwbvyg4iXI/Y8dDrOxEV8q5bv+UQxqDpmZnwsmOTsJMJ0Unm1 9+iyFES5QoVEqdLN8+JXj1jYjXrUhX/d759MIWsmf18TOfEpzjrYqLaiSQ7hWB2a37m2 lYwSPE6aBa9JQfq99soTCFMO6MK+7wtan2/2XwlFMXuOckY+PtZRPXI0VxU+D7Ulc4xD kA8+Ufnq1pulvQDysvYA03ii/Oeg7uM38e9ZJe1AvY47RNzXxSK04HwWogqDXr1Z/gzZ vZP+7aUINsIZ0wjH52e0yRsHxEZemGUaIa9archDdXR10n71Xfb0pUyWUVND7YNb1eBr h2uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683035864; x=1685627864; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dfJMs6FCtKRZODwBO9HSA4c3kE+GfezaVHX9yu/D5TM=; b=I9gAToJsqTyGMMvt6ZkspkV+HIF5oT83ZVW/KVZ4GZqFNxxyIUanriXquTP4roDlaS ghAOiwEknGs+vkbn10Ly3koOhndDQo/X5T5Ok90WK1yDM1bMoV7qPvThKk70INRIIxLt Egm9ZqT12+V+eUZFrLfIAx/wFqlCE72yCYfewS3UO3K5WcWyJEG+A96OcsmgaA21lFrW x1+e3mdvUBitvAhFwthmktf4eqSKkXez0jui8/Ly8TnCRIllZBAoEnpLfIMZyaZHnFZY ks+nXbQP5KjoTbuXisXlMIzT5QMQ3a5TW+R5IMRVYx71y1ZejrmPL2kyCR5Ur4iGXAFt aGuA== X-Gm-Message-State: AC+VfDw7mXFl6umlKpqXByeffVWQ3uPoHztlJwMeT3Uvx8LQR6I+bewG LKJEuvUBfzZqFkrpo+rb7WfIFeQHi8OL1iCXwlfalg== X-Received: by 2002:a7b:c408:0:b0:3f2:5999:4f47 with SMTP id k8-20020a7bc408000000b003f259994f47mr12723218wmi.14.1683035863997; Tue, 02 May 2023 06:57:43 -0700 (PDT) Received: from stoup.Home ([2a02:c7c:74db:8d00:ad29:f02c:48a2:269c]) by smtp.gmail.com with ESMTPSA id j32-20020a05600c1c2000b003f173987ec2sm39461140wms.22.2023.05.02.06.57.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 06:57:43 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: mrolnik@gmail.com, edgar.iglesias@gmail.com, tsimpson@quicinc.com, ale@rev.ng, anjo@rev.ng, laurent@vivier.eu, philmd@linaro.org, jiaxun.yang@flygoat.com, david@redhat.com, iii@linux.ibm.com, thuth@redhat.com, mark.cave-ayland@ilande.co.uk, atar4qemu@gmail.com, jcmvbkbc@gmail.com Subject: [PATCH 1/9] target/avr: Finish conversion to tcg_gen_qemu_{ld,st}_* Date: Tue, 2 May 2023 14:57:33 +0100 Message-Id: <20230502135741.1158035-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502135741.1158035-1-richard.henderson@linaro.org> References: <20230502135741.1158035-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Convert away from the old interface with the implicit MemOp argument. Signed-off-by: Richard Henderson Reviewed-by: Anton Johansson --- target/avr/translate.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target/avr/translate.c b/target/avr/translate.c index a6aeae6dfa..cd82f5d591 100644 --- a/target/avr/translate.c +++ b/target/avr/translate.c @@ -1492,7 +1492,7 @@ static void gen_data_store(DisasContext *ctx, TCGv data, TCGv addr) if (ctx->base.tb->flags & TB_FLAGS_FULL_ACCESS) { gen_helper_fullwr(cpu_env, data, addr); } else { - tcg_gen_qemu_st8(data, addr, MMU_DATA_IDX); /* mem[addr] = data */ + tcg_gen_qemu_st_tl(data, addr, MMU_DATA_IDX, MO_UB); } } @@ -1501,7 +1501,7 @@ static void gen_data_load(DisasContext *ctx, TCGv data, TCGv addr) if (ctx->base.tb->flags & TB_FLAGS_FULL_ACCESS) { gen_helper_fullrd(data, cpu_env, addr); } else { - tcg_gen_qemu_ld8u(data, addr, MMU_DATA_IDX); /* data = mem[addr] */ + tcg_gen_qemu_ld_tl(data, addr, MMU_DATA_IDX, MO_UB); } } @@ -1979,7 +1979,7 @@ static bool trans_LPM1(DisasContext *ctx, arg_LPM1 *a) tcg_gen_shli_tl(addr, H, 8); /* addr = H:L */ tcg_gen_or_tl(addr, addr, L); - tcg_gen_qemu_ld8u(Rd, addr, MMU_CODE_IDX); /* Rd = mem[addr] */ + tcg_gen_qemu_ld_tl(Rd, addr, MMU_CODE_IDX, MO_UB); return true; } @@ -1996,7 +1996,7 @@ static bool trans_LPM2(DisasContext *ctx, arg_LPM2 *a) tcg_gen_shli_tl(addr, H, 8); /* addr = H:L */ tcg_gen_or_tl(addr, addr, L); - tcg_gen_qemu_ld8u(Rd, addr, MMU_CODE_IDX); /* Rd = mem[addr] */ + tcg_gen_qemu_ld_tl(Rd, addr, MMU_CODE_IDX, MO_UB); return true; } @@ -2013,7 +2013,7 @@ static bool trans_LPMX(DisasContext *ctx, arg_LPMX *a) tcg_gen_shli_tl(addr, H, 8); /* addr = H:L */ tcg_gen_or_tl(addr, addr, L); - tcg_gen_qemu_ld8u(Rd, addr, MMU_CODE_IDX); /* Rd = mem[addr] */ + tcg_gen_qemu_ld_tl(Rd, addr, MMU_CODE_IDX, MO_UB); tcg_gen_addi_tl(addr, addr, 1); /* addr = addr + 1 */ tcg_gen_andi_tl(L, addr, 0xff); tcg_gen_shri_tl(addr, addr, 8); @@ -2045,7 +2045,7 @@ static bool trans_ELPM1(DisasContext *ctx, arg_ELPM1 *a) TCGv Rd = cpu_r[0]; TCGv addr = gen_get_zaddr(); - tcg_gen_qemu_ld8u(Rd, addr, MMU_CODE_IDX); /* Rd = mem[addr] */ + tcg_gen_qemu_ld_tl(Rd, addr, MMU_CODE_IDX, MO_UB); return true; } @@ -2058,7 +2058,7 @@ static bool trans_ELPM2(DisasContext *ctx, arg_ELPM2 *a) TCGv Rd = cpu_r[a->rd]; TCGv addr = gen_get_zaddr(); - tcg_gen_qemu_ld8u(Rd, addr, MMU_CODE_IDX); /* Rd = mem[addr] */ + tcg_gen_qemu_ld_tl(Rd, addr, MMU_CODE_IDX, MO_UB); return true; } @@ -2071,7 +2071,7 @@ static bool trans_ELPMX(DisasContext *ctx, arg_ELPMX *a) TCGv Rd = cpu_r[a->rd]; TCGv addr = gen_get_zaddr(); - tcg_gen_qemu_ld8u(Rd, addr, MMU_CODE_IDX); /* Rd = mem[addr] */ + tcg_gen_qemu_ld_tl(Rd, addr, MMU_CODE_IDX, MO_UB); tcg_gen_addi_tl(addr, addr, 1); /* addr = addr + 1 */ gen_set_zaddr(addr); return true;