From patchwork Wed May 3 06:57:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 678582 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp899783wrs; Wed, 3 May 2023 00:00:44 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7k3cBXWRVrtBHrK11Cskkd5oy4ZjimCYqTp1Cj6Vg9cuoBGPbDd6Sj3+l2NhNqibzPZM2i X-Received: by 2002:a05:6214:518a:b0:5ef:4823:a949 with SMTP id kl10-20020a056214518a00b005ef4823a949mr7900499qvb.45.1683097243721; Wed, 03 May 2023 00:00:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683097243; cv=none; d=google.com; s=arc-20160816; b=e+cHEbYqDcdW8Cflr7f5s9d0X/3FoagXLjbuBLN204sRp3XphyXlC5sKRnIA6VgCOx qnxd2eK/+XpH0gPZzbf+Cf0Pi4037d70q125Vc9UrJ+AXyKKIQRtPHMSMNIHazrotZhi MjNG00BvDptbdhemi82Hfa3seTD1Cwy0ZXdTM+GrhIQW9YNZRqQgeq/Us+p471C2fhJ7 gmanP0O3NcVp0A9UgvZkSsl7VQgDAoppoXOiyUKHogBeQaAI4hvBrIZGvX3Q/nR+wCd7 wo2CtrAwuS40uVEs1T7sopQN5w7YuCP18gQf2Fp++B6Kd6qwlwtS38Xb2R6ptf7xDBiG icLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ePGQgjAgeqBpbV0KhHIgImg7evASXxc6+J4X6wS7qUw=; b=D5SxTZ3R3SGYrscZFF8MoiXiaZwczxTRiUvIXeV6sUggXA2Dq1s6SKTMI2cGPJVeqS oIGHpDtQfhVNonqE3RNtyJdOTIvjtG620g55PU5+f8pNYiIsdJsENP1cS/Aq/FyCZoCc x7Z6+g6qqNhWNChhCc696xJ45fpzSPz93HffcGv2YPz/nAQ9u4Ll/stHfNA0LmclaxoR ok7W455lcmcqoDXRYRQ0RgimQqAKCy5b8bdIuCQ/ePKJSxub8naa/+OI0RZ5r4YUIiS6 SXq51riI+N8YHn0EgPoaI+GRiAM50Jvg9UfVpT3OiMK58tMvxCsZfS6MybHw4A6TO2zd 6DlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=d1CH305R; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id fn15-20020ad45d6f000000b005dda9d0227fsi18649523qvb.596.2023.05.03.00.00.43 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 May 2023 00:00:43 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=d1CH305R; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pu6SF-0000hQ-9p; Wed, 03 May 2023 02:59:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pu6RY-0008OO-2e for qemu-devel@nongnu.org; Wed, 03 May 2023 02:58:28 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pu6Qz-0001ip-EQ for qemu-devel@nongnu.org; Wed, 03 May 2023 02:58:27 -0400 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-2f55ffdbaedso2874679f8f.2 for ; Tue, 02 May 2023 23:57:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683097072; x=1685689072; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ePGQgjAgeqBpbV0KhHIgImg7evASXxc6+J4X6wS7qUw=; b=d1CH305R62rgu4Qpl2EjVg4x+Jf755qK1sKeoS7tYe5xRPE07GWrF3diHGXs5uES+c g2TPDi1sfmAW5dAKg0t7AVRcfBjmJ6T42qVGtyNzFIAFUz/hLgt2IeuCoehzR2NtnUx2 mqUPK15rukGrC+pIqYaVuikS2v7rvEQ4f6EjFvPEHsHzjde8eRCcd/NeMlEPVsY1d2MF DICS+np0HJ4ZqyFlwfFFFBXptqStXCHpyGeID66tqIjWx3XiVc9gQ+8OEOCtDG/FHI4+ E4FkQQlJruInJjH4YoPfxO1jRax208GqzjgjxQslNK9OYLgBcNc26HHND/9oGa6ypuyH N6Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683097072; x=1685689072; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ePGQgjAgeqBpbV0KhHIgImg7evASXxc6+J4X6wS7qUw=; b=lC450ZBPtbHHUCxzJ+5G122wY2ppTeKKzL47Q/IFxq+Z1WEYUErxXk9bScqV6c+yTN L54F9ubzj0eGPUJfAv2JjhTqdPnBEN+/GxhjXDrmev57LKS+K1mdaHqPFfm+Ux6ZtH2N 1hiejVyn7GSPqA7/7b2gN4GCbmqggl9XF0KIzQ5VA77HArGB6azEsTp/Bxp0G+jnNCQK hJ6x0lyXOjcw4zsVenzktKQFffw67smIDKPUSpwwnwMLLxPLrzWRKMZV4tH99AHYP/w7 b9v026gZWJxGvPgL8ZQ8YvHwBdYEs90FmsJosEaWOJG5CDPqJA6C6vxCBpDOWeVNAA6h FCmA== X-Gm-Message-State: AC+VfDy87qqoMP36ZAiMbahUlBjH3642x8o1e6Nbsn3h4fMeefZtQgdE JnVuDNhD/Rpbt5UZCLuIV+jQBQes4dqBhi4WmlJPJQ== X-Received: by 2002:adf:f752:0:b0:306:2b9f:fa4c with SMTP id z18-20020adff752000000b003062b9ffa4cmr7884781wrp.3.1683097072478; Tue, 02 May 2023 23:57:52 -0700 (PDT) Received: from stoup.Home ([2a02:c7c:74db:8d00:c01d:9d74:b630:9087]) by smtp.gmail.com with ESMTPSA id f6-20020a5d6646000000b002f6dafef040sm32796617wrw.12.2023.05.02.23.57.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 23:57:52 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: git@xen0n.name, philmd@linaro.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org Subject: [PATCH v4 28/54] tcg/sparc64: Drop is_64 test from tcg_out_qemu_ld data return Date: Wed, 3 May 2023 07:57:03 +0100 Message-Id: <20230503065729.1745843-29-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230503065729.1745843-1-richard.henderson@linaro.org> References: <20230503065729.1745843-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org In tcg_canonicalize_memop, we remove MO_SIGN from MO_32 operations with TCG_TYPE_I32. Thus this is never set. We already have an identical test just above which does not include is_64 Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/sparc64/tcg-target.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/sparc64/tcg-target.c.inc b/tcg/sparc64/tcg-target.c.inc index 4f477d539c..dbe4bf96b9 100644 --- a/tcg/sparc64/tcg-target.c.inc +++ b/tcg/sparc64/tcg-target.c.inc @@ -1220,7 +1220,7 @@ static void tcg_out_qemu_ld(TCGContext *s, TCGReg data, TCGReg addr, tcg_out_movi(s, TCG_TYPE_I32, TCG_REG_O2, oi); /* We let the helper sign-extend SB and SW, but leave SL for here. */ - if (is_64 && (memop & MO_SSIZE) == MO_SL) { + if ((memop & MO_SSIZE) == MO_SL) { tcg_out_ext32s(s, data, TCG_REG_O0); } else { tcg_out_mov(s, TCG_TYPE_REG, data, TCG_REG_O0);