diff mbox series

[20/22] gitlab: enable minimal device profoile for aarch64 --disable-tcg

Message ID 20230503091244.1450613-21-alex.bennee@linaro.org
State Superseded
Headers show
Series testing/next: cirrus, docker, docs, ci, configs, gitlab | expand

Commit Message

Alex Bennée May 3, 2023, 9:12 a.m. UTC
As this is likely the most common configuration people will want once
the --disable-tcg patches land.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Fabiano Rosas <farosas@suse.de>
---
 .gitlab-ci.d/custom-runners/ubuntu-22.04-aarch64.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Henderson May 3, 2023, 10:30 a.m. UTC | #1
On 5/3/23 10:12, Alex Bennée wrote:
> As this is likely the most common configuration people will want once
> the --disable-tcg patches land.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Fabiano Rosas <farosas@suse.de>
> ---
>   .gitlab-ci.d/custom-runners/ubuntu-22.04-aarch64.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Typo in $SUBJECT.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
Juan Quintela May 3, 2023, 10:34 a.m. UTC | #2
Alex Bennée <alex.bennee@linaro.org> wrote:
> As this is likely the most common configuration people will want once
> the --disable-tcg patches land.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Fabiano Rosas <farosas@suse.de>

s/profoile/profile/ on $subject

> ---
>  .gitlab-ci.d/custom-runners/ubuntu-22.04-aarch64.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.gitlab-ci.d/custom-runners/ubuntu-22.04-aarch64.yml b/.gitlab-ci.d/custom-runners/ubuntu-22.04-aarch64.yml
> index f8489dd3fc..374b0956c3 100644
> --- a/.gitlab-ci.d/custom-runners/ubuntu-22.04-aarch64.yml
> +++ b/.gitlab-ci.d/custom-runners/ubuntu-22.04-aarch64.yml
> @@ -145,7 +145,7 @@ ubuntu-22.04-aarch64-notcg:
>   script:
>   - mkdir build
>   - cd build
> - - ../configure --disable-tcg
> + - ../configure --disable-tcg --with-devices-aarch64=minimal
>     || { cat config.log meson-logs/meson-log.txt; exit 1; }
>   - make --output-sync -j`nproc --ignore=40`
>   - make --output-sync -j`nproc --ignore=40` check

I have no clue about what arm users want or not.

Later, Juan.
Fabiano Rosas May 3, 2023, 1:01 p.m. UTC | #3
Alex Bennée <alex.bennee@linaro.org> writes:

> As this is likely the most common configuration people will want once
> the --disable-tcg patches land.

I don't think sbsa-ref works with KVM, sbsa_ref_init has:

    if (kvm_enabled()) {
        error_report("sbsa-ref: KVM is not supported for this machine");
        exit(1);
    }
diff mbox series

Patch

diff --git a/.gitlab-ci.d/custom-runners/ubuntu-22.04-aarch64.yml b/.gitlab-ci.d/custom-runners/ubuntu-22.04-aarch64.yml
index f8489dd3fc..374b0956c3 100644
--- a/.gitlab-ci.d/custom-runners/ubuntu-22.04-aarch64.yml
+++ b/.gitlab-ci.d/custom-runners/ubuntu-22.04-aarch64.yml
@@ -145,7 +145,7 @@  ubuntu-22.04-aarch64-notcg:
  script:
  - mkdir build
  - cd build
- - ../configure --disable-tcg
+ - ../configure --disable-tcg --with-devices-aarch64=minimal
    || { cat config.log meson-logs/meson-log.txt; exit 1; }
  - make --output-sync -j`nproc --ignore=40`
  - make --output-sync -j`nproc --ignore=40` check