From patchwork Fri May 5 21:24:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 679339 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp579637wrs; Fri, 5 May 2023 14:28:01 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5E4ZXk2NE+d9FhKVChZM/KeKUFHrq3syMW2xMtEYfCwomZTvzE683g2xyG/l4R/z7ccgsc X-Received: by 2002:a05:6214:48d:b0:621:54d:23e1 with SMTP id pt13-20020a056214048d00b00621054d23e1mr3671949qvb.14.1683322081550; Fri, 05 May 2023 14:28:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683322081; cv=none; d=google.com; s=arc-20160816; b=LCM8WWDtKmAd1fE+GALw51cRdz0d/G8xy7RW7ZyRFZgs6oD2e755vGtwHvCaTV6o1D WVBdWtuby0tSWn/tuNnZ37pm1BMn/OOVwNEp6rlSMptWiMAYw61lx7yf8SZ1+dBCd6Ya gFNANaMdZvybcyRw7+0+T0RGGiUYJ9bFI8KkTwsQF59zfVanWpyX0jciU08civs4pbKd I9f/qe4B4J10K5sFS7UrWsbDlrK/QdsToFTZK4WcX2yPfaqvXvSiTx0ZUyLAB54yE19X HFOcWlQNfymRqI67Bx7JYnEM9M+YO8Syu90IHXBvGZXLmZ31MyOgMx43ryvNNJqiFnjq BJFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ePGQgjAgeqBpbV0KhHIgImg7evASXxc6+J4X6wS7qUw=; b=EGU3AJO0irvmcpLWLGA2w/BmzGHutxL4DHbBsBI6OwtfBu6aHeY9F2Cm+7/WVN34CL t5qjMslvuYP5FNJgpYdhW319qy/jxSOXCoUI8vcOeq1b/EKCyIESzjKAvpIFqM1+Ojp1 m6PYlFHOxAJp1JYkiuKMjh9WfLzVOq5QJidfNGJY1Cn4XAztjd3hkaAnrBV92Vw1KeGL tMslF24qHuppIKi0sDpW6uO0fgL5ieFbOEvQHYD1WFJnxD5pyqVZazj7BJ5Vihug0bwe 0qM1QgwWev3tMg48mvS4Nd1uyUrFbbXOs6Xd4wvurz5J51/ad2Vdt2VoDGmaiq47OcOy PdSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PoJFVQmN; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 2-20020ad45ba2000000b006210472fb87si485610qvq.256.2023.05.05.14.28.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 May 2023 14:28:01 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PoJFVQmN; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pv2ve-0000sO-Ji; Fri, 05 May 2023 17:25:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pv2vW-0000pi-Td for qemu-devel@nongnu.org; Fri, 05 May 2023 17:25:18 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pv2vP-0004fn-0y for qemu-devel@nongnu.org; Fri, 05 May 2023 17:25:18 -0400 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-306281edf15so2130124f8f.1 for ; Fri, 05 May 2023 14:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683321909; x=1685913909; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ePGQgjAgeqBpbV0KhHIgImg7evASXxc6+J4X6wS7qUw=; b=PoJFVQmNC4JODmzmFFJcuuY9BoF2sBO0MY4msxPJWJsLpHwEj8inGAdm3uqcZS0wvD pj+MgPjUwr/RrXKD3jweYq2tQngH/8PQtvqeoKCoRco6iEkaescFYjjAZzcYEpQ3oHia wOXSLkie7RtM5DvZYACKUR2k/9a7i0FOdSY02hfNECl9+LXTCH4EBeKS4nUqjH85igm7 Gb/qXJuuw+vKzD5zynNJRWjmcAPFQ8xGf1V/wR8U1dLFutwsBiE9O5upyCwsicLRWan+ CaaZGhmPBCxQRtMf2BZtsFpX2oEi0E3/FYXyPbF4WgA4Z0YPHbEUfZNb+4ATyM3iJ6rJ Cjiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683321909; x=1685913909; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ePGQgjAgeqBpbV0KhHIgImg7evASXxc6+J4X6wS7qUw=; b=XQK9zSem0kWNglDiUALXQII1h9HSrF874OEQuH8BznyU2U0fbc/dbNUOS9PIQ9jA2Y IRPayB6d4fHkoDkO+ulZLRfd3wISIu5gUjpOAVdsyUIzaQGvFZhhSTCu0X7N3NFQTXpp HoUVxR89oK3vJuWILZKq/UdqB/CWsu6tsXLFPvIicmwOwWUxxxVdk4Qh8zDi8KmHQCTL o5enuHIxTrdvlyN5maJvgQN9PaPdNRj0sxOTVJpZ0fsxcKsB5uR3Wp/qgkr4zX4up+91 Bd5CkqSVklbjtE/9QcgennWXF8uv2DQ86vBlR3T8S5wBhydyjyjX4ohL2CHDZSSoHHv7 dl9A== X-Gm-Message-State: AC+VfDz7lO0QdqTIJIphplRpep5SlqTgLR1tCKa5AzWiZYt+uARt8Zc3 fx2OkstorShJPp2Gdh4E3fhFKM2Eetjzfo3rPJyA4Q== X-Received: by 2002:adf:fcc7:0:b0:2fa:36db:8060 with SMTP id f7-20020adffcc7000000b002fa36db8060mr2267977wrs.60.1683321909631; Fri, 05 May 2023 14:25:09 -0700 (PDT) Received: from stoup.. ([212.241.182.8]) by smtp.gmail.com with ESMTPSA id t14-20020a5d460e000000b003047ae72b14sm3426709wrq.82.2023.05.05.14.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 14:25:09 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PULL 37/42] tcg/sparc64: Drop is_64 test from tcg_out_qemu_ld data return Date: Fri, 5 May 2023 22:24:42 +0100 Message-Id: <20230505212447.374546-38-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230505212447.374546-1-richard.henderson@linaro.org> References: <20230505212447.374546-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org In tcg_canonicalize_memop, we remove MO_SIGN from MO_32 operations with TCG_TYPE_I32. Thus this is never set. We already have an identical test just above which does not include is_64 Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/sparc64/tcg-target.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/sparc64/tcg-target.c.inc b/tcg/sparc64/tcg-target.c.inc index 4f477d539c..dbe4bf96b9 100644 --- a/tcg/sparc64/tcg-target.c.inc +++ b/tcg/sparc64/tcg-target.c.inc @@ -1220,7 +1220,7 @@ static void tcg_out_qemu_ld(TCGContext *s, TCGReg data, TCGReg addr, tcg_out_movi(s, TCG_TYPE_I32, TCG_REG_O2, oi); /* We let the helper sign-extend SB and SW, but leave SL for here. */ - if (is_64 && (memop & MO_SSIZE) == MO_SL) { + if ((memop & MO_SSIZE) == MO_SL) { tcg_out_ext32s(s, data, TCG_REG_O0); } else { tcg_out_mov(s, TCG_TYPE_REG, data, TCG_REG_O0);