From patchwork Sat May 6 07:22:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 679589 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp745611wrs; Sat, 6 May 2023 00:28:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7WEgCEnyN46WTRTtGAKOTvYl60Mi7nEWb2BDIU5XdcGncyNosUD37JSAd7ruxto6IwvGWB X-Received: by 2002:a05:6214:518f:b0:621:7a4:cd09 with SMTP id kl15-20020a056214518f00b0062107a4cd09mr3474001qvb.46.1683358129387; Sat, 06 May 2023 00:28:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683358129; cv=none; d=google.com; s=arc-20160816; b=px6dmInvOveHezbKUHpDeOShl8e5AWccLjzmNfwtF2atIbN83qA5N18R+Tdf4yNVRz VYSDcd3ePUUx0gIkZJ9k1noFVmIPTLpOgZ+8DiwLdE9ejldimY2LdJrLSpCRN5fAzNWg /p8+u+g2QA9uXhuejTMrd3XtfdRUiguJktbHFWZqgBH1nLfj7m+rM8M5XHuRLZAGRn1R tfpEh6PuGJLa3EPrIZHeQXnVthz3v2YpH6dtWm0tICNt9csq0ito+aFgURtoIeVC76R1 ocgeqDcO6cMXIY/jJn+aeh+Z2roO2OkUFg1drv2YEb2GsJDAWvIDrn9fljzM6+dFD9vF 1AiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WrmqAOuR2/yJANGPopXn5FwM+vXCIwdTliCaNgd+uz0=; b=txkWt3223jICoNpqm2Fw3PC94GLYkuyfp4tqz7RWR8Oq8WHIzP4EELmDWu45kNfkYL cFCiIHMOYfkwXbV/waBWaJt1tMLPw3Gf3n+qYdLmxrxax/xoAzd4ve+4ltJBz5t6hAN6 2iGeFzUXnxYH8Pdg9enKHBifhlI3hqAKYGEDFwlLveRB9Sc696AEYRqNt1Zfrv4c7glB AwuEs0hJC4/jroIsp2xey1uzKsYg1d65HRMe2daJhR/BnrWXhnPPuwn9kvEY5DtVdBVm Qqy9rctTSEOEeU4svnr+dk+Tsgwdog9SVPQ2jVFsSlL+58bAQA6yzeD1zxSBxFXvZkjn NZXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AlTo+1iI; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id pn16-20020a056214131000b005ef6a8e45cdsi1234889qvb.510.2023.05.06.00.28.49 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 06 May 2023 00:28:49 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AlTo+1iI; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvCGd-00063V-6F; Sat, 06 May 2023 03:23:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvCGY-0005ny-9W for qemu-devel@nongnu.org; Sat, 06 May 2023 03:23:38 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvCFv-0004Lx-Np for qemu-devel@nongnu.org; Sat, 06 May 2023 03:23:37 -0400 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-2f55ffdbaedso1705226f8f.2 for ; Sat, 06 May 2023 00:22:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683357779; x=1685949779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WrmqAOuR2/yJANGPopXn5FwM+vXCIwdTliCaNgd+uz0=; b=AlTo+1iIaFMaKTLUngVBwZ7LoNaDenv9K07t7v4Drur3M+qp3yNmfrrwBBARTUlOVG TP789aXPGsX1hnLD1vfJimaK76dMQS40aecOt7gjlhwq6gtVY4j2dYhSF9jhWx3+yZM3 sEHSmzKFPNvIIu3x0N/XkqqIeaA+W0d2ilsRAP8v6ljc8sJttI4rWg7hHxuNfzKHYA6z 0AmT1SEbQ/k9UEBBlloPGtxLlhNPM2PqeWykt0i4fvdSzQb26X6GFT/35nFqihBnHIz6 E0Y0N1SB65JbVUZQlRr/UmS1Rc7qU7UcFmCzd6v7E7vKlBRCbL3iTSZX2FNhqTi+yggA 08lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683357779; x=1685949779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WrmqAOuR2/yJANGPopXn5FwM+vXCIwdTliCaNgd+uz0=; b=Y4SSC4Tcngh1qESAafz96846LdKocTxCBkLjjWtDyGjsKyfAahYqR9orZHzoA1gwo6 Up8QFPZklzH3jWrzOKURyHCDO+zK0pfs/BiaTFdtX58xQJwf6TFuKzChDqayBF8Uz2MU bqVa332MQHLhwnU5uGbXHtfL3smrRpOvHTT3nadvWV2dVDHFnECliQJI5Ks6kPPTro7t pyi9uw1edWgOrOXl0u8OnzEKLV2dosi30IwXWEzc6xG2RNQfTn6Qjo34Lei0IZyNEdvJ nsyUc0NiVF9FstjCPuyi7BeOcTbdgM/G9ytWUVYVrFgjCX37OrmO6xzGgtoMJ/ujCZL7 +/Hg== X-Gm-Message-State: AC+VfDxT4z+oZCb6iuS778bqx5eFTUkGKAaq6ABPck2XtXEziy7Abq+n hCdAfGxDPQu3lS02uyEfiQOMxQT8lGT6U/MVPp3nFA== X-Received: by 2002:adf:df0c:0:b0:307:5912:789 with SMTP id y12-20020adfdf0c000000b0030759120789mr2872297wrl.66.1683357778828; Sat, 06 May 2023 00:22:58 -0700 (PDT) Received: from stoup.. ([212.241.182.8]) by smtp.gmail.com with ESMTPSA id x9-20020adfec09000000b002faaa9a1721sm4481223wrn.58.2023.05.06.00.22.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 May 2023 00:22:58 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: git@xen0n.name, gaosong@loongson.cn, philmd@linaro.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org Subject: [PATCH v5 29/30] tcg/s390x: Use ALGFR in constructing softmmu host address Date: Sat, 6 May 2023 08:22:34 +0100 Message-Id: <20230506072235.597467-30-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230506072235.597467-1-richard.henderson@linaro.org> References: <20230506072235.597467-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Rather than zero-extend the guest address into a register, use an add instruction which zero-extends the second input. Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée --- tcg/s390x/tcg-target.c.inc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index dfcf4d9e34..dd13326670 100644 --- a/tcg/s390x/tcg-target.c.inc +++ b/tcg/s390x/tcg-target.c.inc @@ -149,6 +149,7 @@ typedef enum S390Opcode { RRE_ALGR = 0xb90a, RRE_ALCR = 0xb998, RRE_ALCGR = 0xb988, + RRE_ALGFR = 0xb91a, RRE_CGR = 0xb920, RRE_CLGR = 0xb921, RRE_DLGR = 0xb987, @@ -1853,10 +1854,11 @@ static TCGLabelQemuLdst *prepare_host_addr(TCGContext *s, HostAddress *h, tcg_out_insn(s, RXY, LG, h->index, TCG_REG_R2, TCG_REG_NONE, offsetof(CPUTLBEntry, addend)); - h->base = addr_reg; if (TARGET_LONG_BITS == 32) { - tcg_out_ext32u(s, TCG_REG_R3, addr_reg); - h->base = TCG_REG_R3; + tcg_out_insn(s, RRE, ALGFR, h->index, addr_reg); + h->base = TCG_REG_NONE; + } else { + h->base = addr_reg; } h->disp = 0; #else